Re: Review Request 114328: re-add customstyleelement suite to kstyle

2013-12-07 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114328/#review45335 --- Ship it! Code looks good, you are the master of QStyle if you

Tier 3 depending between eachother

2013-12-07 Thread Albert Astals Cid
Looking at Aurélien's graphs i see that there seem to be a few Tier 3 things depending on other Tier 3 things. Why is that? And what's the difference between a Tier 3 thing that depends on another Tier 3 thing and a Tier 4 thing? Cheers, Albert ___

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-07 Thread Stephen Kelly
Aurélien Gâteau wrote: > > >> On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote: >> > Just wondering, should include/KF5 also be the include dir for >> > applications that install headers e.g. for writing plugins? Since I >> > guess they will also be using KDEInstallDirs.cmake > > Good que