Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Aurélien Gâteau
> On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote: > > Just wondering, should include/KF5 also be the include dir for applications > > that install headers e.g. for writing plugins? Since I guess they will also > > be using KDEInstallDirs.cmake Good question. This was not discussed in t

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Aurélien Gâteau
> On Dec. 6, 2013, 5:06 p.m., Michael Palimaka wrote: > > kde-modules/KDEInstallDirs.cmake, line 131 > > > > > > Is the capitalisation intentional? Most other stuff seems to be in > > lowercase. It was agreed to

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/#review45278 --- Just wondering, should include/KF5 also be the include dir for

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/#review45275 --- How about to make it lowercase? - Johannes Huber On Dec. 6,

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/#review45274 --- kde-modules/KDEInstallDirs.cmake

Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: extra-cma

Re: Review Request 114328: re-add customstyleelement suite to kstyle

2013-12-06 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114328/ --- (Updated Dec. 6, 2013, 2:43 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

2013-12-06 Thread David Faure
On Friday 06 December 2013 10:00:08 Kevin Ottens wrote: > On Thursday 05 December 2013 17:02:13 Hugo Pereira Da Costa wrote: > > As a consequence: kde-workspace currently does not compile. > > We can: > > 1/ re-add the functionality inside kstyle (its a couple of static > > functions basically) > >

Review Request 114333: Add KF5 prefix for tier2

2013-12-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

2013-12-06 Thread Kevin Ottens
On Thursday 05 December 2013 17:02:13 Hugo Pereira Da Costa wrote: > As a consequence: kde-workspace currently does not compile. > We can: > 1/ re-add the functionality inside kstyle (its a couple of static > functions basically) > 2/ use K4Style but that would make oxygen-decoration depend on KDE4