Jenkins build is back to normal : plasma-framework_master_qt5 #918

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1770

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1769

See Changes: [aleixpol] makekdewidgets doesn't depend on i18n -- [...truncated 5096 lines...] Linking CXX shared library libKCrash.so [ 47%] Building CXX object tier2/kjobwidgets/src/CMakeFile

Build failed in Jenkins: kdelibs_frameworks_qt5 #1768

See Changes: [aleixpol] Integrate KAboutData and QCommandLineParser [aleixpol] Port makekdewidgets to KAboutData -- [...truncated 3959 lines...] [ 32%] Building CXX object tier3/kservice/src/

Re: imageformat plugins

On Tuesday 26 November 2013 01:54:16 Alex Merry wrote: > It occurred to me that KGuiAddons might not be the best place for > the imageformat plugins, and that they should maybe become their > own framework (either tier1 or tier4). > > The only thing that relates the KGuiAddons library and the > im

imageformat plugins

It occurred to me that KGuiAddons might not be the best place for the imageformat plugins, and that they should maybe become their own framework (either tier1 or tier4). The only thing that relates the KGuiAddons library and the imageformat plugins is that they are both to do with QtGui. Each can

Review requests

Review board doesn't appear to be sending emails for my review requests, so -- since some of them are a dependency of Kevin's repo splitting -- here they are: Fix KIO superbuild dependencies https://git.reviewboard.kde.org/r/114127/ Move kmediaplayer to tier3 https://git.reviewboard.kde.org/r/114

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

> On Nov. 25, 2013, 5:29 p.m., David Faure wrote: > > AFAIK the rule for Qt unittests is that they should run in under 5 seconds. > > They don't all manage that, nor do we, but it gives an indication. > > > > 30 seconds or more is definitely too much. > > "For the silent case the timeout - is f

Review Request 114116: [tier3/kservice] Improve dependency specification

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114116/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/#review44453 --- Ship it! I understood that it is important not to have to add

Re: Review Request 114038: Integrate KAboutData and QCommandLineParser

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/#review44452 --- Ship it! Ship It! - David Faure On Nov. 25, 2013, 4:26 p.m.

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

> On Nov. 25, 2013, 6:29 p.m., David Faure wrote: > > AFAIK the rule for Qt unittests is that they should run in under 5 seconds. > > They don't all manage that, nor do we, but it gives an indication. > > > > 30 seconds or more is definitely too much. > > "For the silent case the timeout - is f

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1767

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review6 --- AFAIK the rule for Qt unittests is that they should run in unde

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

> On Nov. 25, 2013, 1:48 p.m., Kevin Ottens wrote: > > Any chance for a review? We really need to tie up loose ends now. I think that this is a very nice piece of work, and the new data-driven test also looks good to me. The only thing I'm concerned about is the run time of the test - I like u

Re: Review Request 114090: [tier2/ki18n] Improve dependency specification

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114090/ --- (Updated Nov. 25, 2013, 4:44 p.m.) Status -- This change has been mar

Re: Review Request 114090: [tier2/ki18n] Improve dependency specification

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114090/#review3 --- This review has been submitted with commit 77f3ded7cad2f78de89

Re: Review Request 114038: Integrate KAboutData and QCommandLineParser

> On Nov. 24, 2013, 10:58 a.m., David Faure wrote: > > tier1/kcoreaddons/src/lib/kaboutdata.cpp, line 957 > > > > > > (LOL, most likely someone forgot to call addAuthor, but OK :) > > > > > > Wrong u

Re: Review Request 114038: Integrate KAboutData and QCommandLineParser

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114038/ --- (Updated Nov. 25, 2013, 4:26 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 114111: Fix KIconThemes standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114111/ --- (Updated Nov. 25, 2013, 9:50 p.m.) Status -- This change has been dis

Re: Review Request 114111: Fix KIconThemes standalone build

> On Nov. 25, 2013, 4:49 p.m., Maarten De Meyer wrote: > > Are you sure this is needed? KConfigWidgets already includes KGuiAddons and > > KIconThemes doesn't link with KGuiAddons directly. > > You say it "complains" so you are still able to build? > > Next version of CMake should fix this. > >

Re: Review Request 114111: Fix KIconThemes standalone build

> On Nov. 25, 2013, 3:49 p.m., Maarten De Meyer wrote: > > Are you sure this is needed? KConfigWidgets already includes KGuiAddons and > > KIconThemes doesn't link with KGuiAddons directly. > > You say it "complains" so you are still able to build? > > Next version of CMake should fix this. > >

Re: Review Request 114111: Fix KIconThemes standalone build

> On Nov. 25, 2013, 9:19 p.m., Maarten De Meyer wrote: > > Are you sure this is needed? KConfigWidgets already includes KGuiAddons and > > KIconThemes doesn't link with KGuiAddons directly. > > You say it "complains" so you are still able to build? > > Next version of CMake should fix this. > >

Re: Review Request 114111: Fix KIconThemes standalone build

> On Nov. 25, 2013, 3:49 p.m., Maarten De Meyer wrote: > > Are you sure this is needed? KConfigWidgets already includes KGuiAddons and > > KIconThemes doesn't link with KGuiAddons directly. > > You say it "complains" so you are still able to build? > > Next version of CMake should fix this. > >

Build failed in Jenkins: plasma-framework_master_qt5 #917

See Changes: [mklapetek] Reinstate the month name capitalization -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 114111: Fix KIconThemes standalone build

> On Nov. 25, 2013, 9:19 p.m., Maarten De Meyer wrote: > > Are you sure this is needed? KConfigWidgets already includes KGuiAddons and > > KIconThemes doesn't link with KGuiAddons directly. > > You say it "complains" so you are still able to build? > > Next version of CMake should fix this. No

Re: Review Request 114111: Fix KIconThemes standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114111/#review44430 --- Are you sure this is needed? KConfigWidgets already includes KG

Re: Review Request 114037: Split kfileaudiopreview out from kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114037/#review44429 --- This review has been submitted with commit ffe460b1ef46bc3812b

Re: Review Request 114037: Split kfileaudiopreview out from kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114037/ --- (Updated Nov. 25, 2013, 3:33 p.m.) Status -- This change has been mar

Re: Review Request 114037: Split kfileaudiopreview out from kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114037/#review44428 --- This review has been submitted with commit ab633b99dae2d57a4dc

Re: Review Request 113910: Add basic KArchive examples

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/ --- (Updated Nov. 25, 2013, 3:33 p.m.) Status -- This change has been mar

Re: Review Request 113910: Add basic KArchive examples

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44427 --- This review has been submitted with commit 5c4f98aff6bca46e152

Review Request 114111: Fix KIconThemes standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114111/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113910: Add basic KArchive examples

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44416 --- Ship it! Ship It! - Kevin Ottens On Nov. 25, 2013, 2:46 p.m

Re: Review Request 113910: Add basic KArchive examples

> On Nov. 25, 2013, 2:11 p.m., Kevin Ottens wrote: > > tier1/karchive/examples/tarlocalfiles/main.cpp, line 72 > > > > > > Put the } and the else if on the same line please. > > > > Sorry I didn't spot it

Re: Review Request 113910: Add basic KArchive examples

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/ --- (Updated Nov. 25, 2013, 2:46 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 113910: Add basic KArchive examples

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44406 --- tier1/karchive/examples/tarlocalfiles/main.cpp

Re: Review Request 114090: [tier2/ki18n] Improve dependency specification

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114090/#review44404 --- Ship it! Ship It! - Kevin Ottens On Nov. 24, 2013, 10:17 p.

Re: Review Request 114044: Remove unused dependencies in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114044/#review44402 --- This review has been submitted with commit 6a2020aa8c80c05d83f

Re: Review Request 114050: Add manual test app for enableBlurBehind.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/#review44403 --- tier1/kwindowsystem/tests/blurbehindtest.cpp

Re: Review Request 114044: Remove unused dependencies in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114044/ --- (Updated Nov. 25, 2013, 1:59 p.m.) Status -- This change has been mar

Re: Review Request 114037: Split kfileaudiopreview out from kmediaplayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114037/#review44401 --- Ship it! Ship It! - Kevin Ottens On Nov. 22, 2013, 5:52 p.m

Re: Review Request 113503: make dbus dependency optional in JobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/ --- (Updated Nov. 25, 2013, 1:56 p.m.) Status -- This change has been dis

Re: Review Request 114004: Install kio/connection_p.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114004/ --- (Updated Nov. 25, 2013, 1:57 p.m.) Status -- This change has been dis

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

> On Nov. 18, 2013, 5 p.m., Kevin Ottens wrote: > > After discussion on the mailing list, let's get that in for the time being. > > It is to be considered as a temporary solution and will be removed when > > CMake 3 will be available. Please push it ASAP, we need to tie up loose ends NOW. -

Re: Review Request 112880: Added KColorSchemeToken class.

> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review44397 --- Any chance for a review? We really need to tie up loose ends no

Build failed in Jenkins: kdelibs_frameworks_qt5 #1757

See Changes: [aleixpol] Rename includes following publication of KIconEngine -- [...truncated 7489 lines...]

Build failed in Jenkins: plasma-framework_master_qt5 #916

See Changes: [mklapetek] Revert capitalizing the month's name -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Build failed in Jenkins: kdelibs_frameworks_qt5 #1756

See Changes: [aleixpol] Add superbuild entries for tier4 -- [...truncated 5542 lines...] Linking CXX executable kptyprocesstest [ 53%] [ 53%] Built target kdeinit5 Building CXX object tier3/kde

Re: Review Request 113910: Add basic KArchive examples

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/ --- (Updated Nov. 25, 2013, 12:35 p.m.) Review request for KDE Frameworks. C

Build failed in Jenkins: kdelibs_frameworks_qt5 #1755

See Changes: [aleixpol] Fix some porting notes [aleixpol] Reduce private headers usage from KDE4Support [aleixpol] Install needed headers for FrameworksIntegration -- [...truncated 5607 lines

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/ --- (Updated Nov. 25, 2013, 12:26 p.m.) Status -- This change has been ma

Build failed in Jenkins: plasma-framework_master_qt5 #915

See Changes: [mklapetek] Make the calendar applet follow current locale with first day in week [mklapetek] Add some docs to Calendar binginds -- Started by remote host 127.0.0.1 with note

Re: Review Request 114003: Install private headers needed by kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- (Updated Nov. 25, 2013, 12:26 p.m.) Status -- This change has been ma

Re: Review Request 114003: Install private headers needed by kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44384 --- This review has been submitted with commit 12a3023c7134afd957e

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/#review44385 --- This review has been submitted with commit 6fd9c9878fdfc0d055b

Re: Review Request 113975: Make some KSSL files public API

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113975/ --- (Updated Nov. 25, 2013, 11:39 a.m.) Status -- This change has been di

Re: further coinstallability

On 25/11/2013 07:45, Stephen Kelly wrote: Jonathan Riddell wrote: developer files matter to some people to be co-installable. Header files and others can probably be moved to a separate directory Can you be more specific about why this is easy with header files? Does this refer to installi

KF5 Update Meeting 2013-w48 Reminder

Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed messa

Re: [Kde-pim] PIM Sprint: Porting PIM to Frameworks

On Sunday 24 November 2013 21:36:02 Stephen Kelly wrote: > Kevin Ottens wrote: > >> Tiers above 1 are not especially relevant. A tier is a fluid label. It > >> doesn't matter when we are using split repos. > > > > If you could stop spreading that it'd be nice. It's not because you see no > > value

Re: RFC Rules for installation of header files

On Monday 25 November 2013 00:43:52 Stephen Kelly wrote: > Aurélien Gâteau wrote: > > Looks like we have an agreement then. Let me recap: > > > > # Installation dir > > > > All header files are installed in $PREFIX/include/KF5/$Framework. > > This includes 'k' prefixed headers like kfoo and KFoo, >