Re: kdelibs/interfaces/khexedit

2013-11-11 Thread Kevin Ottens
Hwllo, On Monday 11 November 2013 15:43:08 Jeremy Whiting wrote: > I see, and agree. So the way forward with kspeech would be to make it > it's own framework. then at some point turn the header/dbus interface > into a library that can hide the implementation details of using the > dbus interface d

Jenkins build is back to normal : plasma-framework_master_qt5 #898

2013-11-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #897

2013-11-11 Thread KDE CI System
See Changes: [sebas] Navigation improvements [sebas] correct initial date setting, theming improvement -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Aleix Pol Gonzalez
> On Nov. 12, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote: > > Maybe I've missed something, but I would like to have it explained somehow. > > Why is it bad to define such values? How will g++ calls compare? > > Nicolás Alvarez wrote: > In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds withou

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Nicolás Alvarez
> On Nov. 11, 2013, 9:02 p.m., Aleix Pol Gonzalez wrote: > > Maybe I've missed something, but I would like to have it explained somehow. > > Why is it bad to define such values? How will g++ calls compare? In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without optimization and with debugging

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113805/#review43480 --- Maybe I've missed something, but I would like to have it explai

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113805/#review43479 --- Ship it! Yes please. - Nicolás Alvarez On Nov. 11, 2013, 7:

Re: kdelibs/interfaces/khexedit

2013-11-11 Thread Jeremy Whiting
I see, and agree. So the way forward with kspeech would be to make it it's own framework. then at some point turn the header/dbus interface into a library that can hide the implementation details of using the dbus interface directly, right? Something like libkspeech.so that has a class/namespace to

Re: Review Request 113696: Rename knewstuff private headers to _p.h

2013-11-11 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113696/ --- (Updated Nov. 11, 2013, 10:39 p.m.) Status -- This change has been ma

Re: Review Request 113696: Rename knewstuff private headers to _p.h

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113696/#review43476 --- This review has been submitted with commit d1059d857475e50a7e3

Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113805/ --- Review request for Build System and KDE Frameworks. Repository: extra-cmak

Re: Review Request 113801: note that binaries are for developer use

2013-11-11 Thread Richard Moore
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113801/#review43464 --- Ship it! Ship It! - Richard Moore On Nov. 11, 2013, 6:14 p.

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-11-11 Thread Stephen Kelly
Kevin Ottens wrote: > Any chance to see an update or it is abandonned? > Regarding what I wrote before, CMake is now (in master) able to extract the uic options from the KF5::KI18n target. The uic executable in Qt 5.3 accepts an -include argument https://codereview.qt-project.org/#change,70

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1644

2013-11-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113795: Cut dependency from KIO to KCoreAddons private headers

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113795/#review43456 --- This review has been submitted with commit 473faedc80a23a0164c

Re: Review Request 113795: Cut dependency from KIO to KCoreAddons private headers

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113795/ --- (Updated Nov. 11, 2013, 6:46 p.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #1643

2013-11-11 Thread KDE CI System
See Changes: [aleixpol] Let kio be included without a prefix -- [...truncated 6840 lines...] [ 83%] Building CXX object tier4/khtml/src/CMakeFiles/KHtml.dir/misc/kencodingdetector.cpp.o [ 83%]

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

2013-11-11 Thread Alex Merry
> On Nov. 11, 2013, 5:45 p.m., David Faure wrote: > > Thanks for implementing that. Indeed the TODO didn't mean adding a method > > to QApplication, but it was about the member that was there in qt4, and > > that is now in QXcbConnection. > > > > The optional dependency on QtGui breaks the rul

Review Request 113801: note that binaries are for developer use

2013-11-11 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113801/ --- Review request for KDE Frameworks and Richard Moore. Repository: kdelibs

Re: Review Request 113796: KDBusService: only register desktop activation object for Unique apps

2013-11-11 Thread Alex Merry
> On Nov. 11, 2013, 5:28 p.m., David Faure wrote: > > I'm not sure this is a good idea. > > > > Yes, the spec for this (e.g. for app launchers) is only about unique apps, > > but I still want to be able to start a konqueror instance > > (org.kde.konqueror-12345) and then make a dbus call to ha

Re: Review Request 113795: Cut dependency from KIO to KCoreAddons private headers

2013-11-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113795/#review43450 --- Ship it! Assuming tests pass :) - David Faure On Nov. 11, 2

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

2013-11-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113798/#review43449 --- Thanks for implementing that. Indeed the TODO didn't mean addin

Jenkins build is back to normal : plasma-framework_master_qt5 #894

2013-11-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #893

2013-11-11 Thread KDE CI System
See Changes: [aleixpol] Don't use KDE/ includes, they're deprecated [aleixpol] Make sure that plasma-framework is not using anything from kdelibs4 [aleixpol] Only include QCA includes where needed --

Re: Review Request 113796: KDBusService: only register desktop activation object for Unique apps

2013-11-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113796/#review43446 --- I'm not sure this is a good idea. Yes, the spec for this (e.g.

Re: kdelibs failure in cmake?

2013-11-11 Thread David Faure
On Monday 11 November 2013 15:23:02 Giorgos Tsiapaliokas wrote: > Hello, > > in two machines with no source, build and install dir > kdelibs fails in cmake with this error > > CMake Error at staging/kio/src/kpac/CMakeLists.txt:19 (find_package): > By not providing "FindKF5.cmake" in CMAKE_MODUL

Re: konsole build broken

2013-11-11 Thread David Faure
On Monday 11 November 2013 12:47:47 Harald Sitter wrote: > Would be great if someone could look at it. > > https://launchpadlibrarian.net/156314974/buildlog_ubuntu-saucy-i386.project-> > neon5-konsole_0.0%2Bgit2013%2Br5106~ffbca60%2Bneon6~ubuntu13.10.1_FAILED > TOBUILD.txt.gz http://build.kde

Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

2013-11-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113798/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Repositor

Review Request 113796: KDBusService: only register desktop activation object for Unique apps

2013-11-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113796/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Repositor

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1641

2013-11-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112874: Allow disabling of QCA plugins during build.

2013-11-11 Thread Ivan Romanov
> On Oct. 13, 2013, 11:03 p.m., Ivan Romanov wrote: > > Two issues. > > > > 1. all means all possible not all of them. If I haven't nss on my system > > qca-nss plugin won't built but all others will be built. > > 2. In INSTALL instructions. > > > > BUILD_PLUGINS - define which plugins shou

Build failed in Jenkins: kdelibs_frameworks_qt5 #1640

2013-11-11 Thread KDE CI System
See Changes: [de.meyer.maarten] Fix kcmutils standalone build -- [...truncated 6843 lines...] :2066:11: warnin

Re: Review Request 113708: Make kcmutils build standalone

2013-11-11 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113708/ --- (Updated Nov. 11, 2013, 2:51 p.m.) Status -- This change has been mar

Re: Review Request 113708: Make kcmutils build standalone

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113708/#review43439 --- This review has been submitted with commit e02250277de83c90628

Build failed in Jenkins: kdelibs_frameworks_qt5 #1639

2013-11-11 Thread KDE CI System
See Changes: [aleixpol] Fix KParts standalone build [aleixpol] Fix KDEWebKit standalone build [aleixpol] Fix KNotifyConfig standalone build [aleixpol] Fix KNewStuff standalone build -- [...t

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/ --- (Updated Nov. 11, 2013, 2:31 p.m.) Status -- This change has been mar

Re: Review Request 113686: Fix KParts standalone build

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/ --- (Updated Nov. 11, 2013, 2:31 p.m.) Status -- This change has been mar

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/#review43436 --- This review has been submitted with commit 25e6882a52b9e564a07

Re: Review Request 113694: Fix KNewStuff standalone build

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/#review43437 --- This review has been submitted with commit c3bdecbd045b720f5b3

Re: Review Request 113694: Fix KNewStuff standalone build

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/ --- (Updated Nov. 11, 2013, 2:31 p.m.) Status -- This change has been mar

Re: Review Request 113686: Fix KParts standalone build

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43434 --- This review has been submitted with commit d691d3fac78fcebdcb9

Re: Review Request 113695: Fix KDEWebKit standalone build

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/ --- (Updated Nov. 11, 2013, 2:31 p.m.) Status -- This change has been mar

Re: Review Request 113695: Fix KDEWebKit standalone build

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/#review43435 --- This review has been submitted with commit 08a55302afa6d19f879

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- (Updated Nov. 11, 2013, 2:15 p.m.) Status -- This change has been mar

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43433 --- This review has been submitted with commit 910459f0fd63c1336a0

kdelibs failure in cmake?

2013-11-11 Thread Giorgos Tsiapaliokas
Hello, in two machines with no source, build and install dir kdelibs fails in cmake with this error CMake Error at staging/kio/src/kpac/CMakeLists.txt:19 (find_package): By not providing "FindKF5.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file pro

Review Request 113795: Cut dependency from KIO to KCoreAddons private headers

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113795/ --- Review request for KDE Frameworks and David Faure. Repository: kdelibs D

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43421 --- Ship it! Ship It! - David Faure On Nov. 11, 2013, 11:40 a.m

KF5 Update Meeting 2013-w46 Reminder

2013-11-11 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

konsole build broken

2013-11-11 Thread Harald Sitter
Would be great if someone could look at it. https://launchpadlibrarian.net/156314974/buildlog_ubuntu-saucy-i386.project-neon5-konsole_0.0%2Bgit2013%2Br5106~ffbca60%2Bneon6~ubuntu13.10.1_FAILEDTOBUILD.txt.gz http://build.kde.org/job/konsole_frameworks_qt5/33/console Generating moc_Part.cpp /bu

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- (Updated Nov. 11, 2013, 11:40 a.m.) Review request for KDE Frameworks. C

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-11 Thread Aleix Pol Gonzalez
> On Nov. 11, 2013, 9:54 a.m., David Faure wrote: > > tier1/kcoreaddons/src/lib/jobs/kcompositejob_p.h, line 30 > > > > > > Err why did you remove the inheritance from KJobPrivate, which is > > in the same lib

Re: kdelibs/interfaces/khexedit

2013-11-11 Thread Kevin Ottens
On Monday 11 November 2013 11:13:37 David Faure wrote: > On Sunday 10 November 2013 15:28:27 Kevin Ottens wrote: > > On Sunday 10 November 2013 11:15:58 Dominik Haumann wrote: > > > On Sunday 10 November 2013 09:47:41 David Faure wrote: > > > > On Sunday 10 November 2013 04:32:12 Friedrich W. H. Ko

Re: Getting ecm files from the ECM package

2013-11-11 Thread Aaron J. Seigo
On Sunday, November 3, 2013 20:51:57 Alexander Neundorf wrote: > I wanted to release ECM as fast as possible, since this was one of the main > points I got from the platform meeting in Randa in June 2011: people want to > be able to use cmake stuff from KDE without depending on kdelibs. > Stephen a

Re: kdelibs/interfaces/khexedit

2013-11-11 Thread David Faure
On Sunday 10 November 2013 15:28:27 Kevin Ottens wrote: > On Sunday 10 November 2013 11:15:58 Dominik Haumann wrote: > > On Sunday 10 November 2013 09:47:41 David Faure wrote: > > > On Sunday 10 November 2013 04:32:12 Friedrich W. H. Kossebau wrote: > > > > So from my point of view, especially give

Re: Having a Tier 0 for cmake and git submodules

2013-11-11 Thread Ben Cooksley
On Mon, Nov 11, 2013 at 10:48 PM, David Faure wrote: > On Monday 11 November 2013 01:06:33 Michael Pyne wrote: > > On Sun, November 10, 2013 20:11:07 David Faure wrote: > > > On Sunday 10 November 2013 13:44:09 Michael Pyne wrote: > > > > I would highly recommend doing something similar to what w

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43411 --- I don't get the "dependency of a dependency" thing, surely once

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-11 Thread David Faure
> On Nov. 9, 2013, 12:47 a.m., David Faure wrote: > > tier1/kcoreaddons/src/lib/CMakeLists.txt, line 128 > > > > > > I think we should instead treat them as separate libs, and remove the > > inheritance from KCom

Re: Having a Tier 0 for cmake and git submodules

2013-11-11 Thread David Faure
On Monday 11 November 2013 01:06:33 Michael Pyne wrote: > On Sun, November 10, 2013 20:11:07 David Faure wrote: > > On Sunday 10 November 2013 13:44:09 Michael Pyne wrote: > > > I would highly recommend doing something similar to what was done for > > > strigi when it was split into 5 git modules.

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-11 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/#review43408 --- For me, it looks like it has the functionality I'd need for Kri