Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43247 --- tier2/knotifications/tests/CMakeLists.txt

Re: Use kde-runtime[frameworks]!

On Fri, Nov 8, 2013 at 3:45 AM, Sebastian Kügler wrote: > Hey all, > Hi Sebas, > > In order to achieve more consistency across repositories, we've renamed the > branch frameworks-scratch to frameworks in kde-runtime. Please do not push > to > frameworks-scratch anymore. (Ben, could you block t

Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/ --- (Updated Nov. 7, 2013, 9:33 p.m.) Review request for KDE Frameworks. Sum

Review Request 113713: Solid UDisks2 backend: fixes to propertiesChanged signal handling

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113713/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113711: Clean up API of KPassivePopup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113711/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113693: Fix KNotifyConfig standalone build

> On Nov. 7, 2013, 2:16 p.m., Alex Merry wrote: > > tier3/knotifyconfig/CMakeLists.txt, lines 20-35 > > > > > > Did I miss something? Why is CMake 3 relevant to these? KIO wasn't > > exporting its dependencies t

Re: Review Request 113693: Fix KNotifyConfig standalone build

> On Nov. 7, 2013, 2:16 p.m., Alex Merry wrote: > > tier3/knotifyconfig/CMakeLists.txt, lines 20-35 > > > > > > Did I miss something? Why is CMake 3 relevant to these? KIO wasn't > > exporting its dependencies t

Review Request 113708: Make kcmutils build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113708/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113702: Fix KEmoticons standalone build

> On Nov. 7, 2013, 12:47 p.m., Aurélien Gâteau wrote: > > superbuild/CMakeLists.txt, line 34 > > > > > > kemoticons should be listed after kservice, otherwise superbuild won't > > pick up the standalone version of

Re: Review Request 113692: Fix kjsembed standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113692/#review43229 --- This review has been submitted with commit 4aec111e99f81e0605d

Re: Review Request 113692: Fix kjsembed standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113692/ --- (Updated Nov. 7, 2013, 3:02 p.m.) Status -- This change has been mark

Use kde-runtime[frameworks]!

Hey all, In order to achieve more consistency across repositories, we've renamed the branch frameworks-scratch to frameworks in kde-runtime. Please do not push to frameworks-scratch anymore. (Ben, could you block this branch, if it hasn't already happened?). So, all commits go into the framewo

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 7, 2013, 3:42 p.m.) Review request for KDE Frameworks, Alexa

Re: Review Request 113693: Fix KNotifyConfig standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/#review43226 --- tier3/knotifyconfig/CMakeLists.txt

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/ --- (Updated Nov. 7, 2013, 2:12 p.m.) Status -- This change has been mark

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/#review43225 --- This review has been submitted with commit c43a7c0d6ba6e514ffa

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/#review43224 --- This review has been submitted with commit 1cefc67ca2da5f6f976

Re: Review Request 113692: Fix kjsembed standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113692/#review43223 --- Ship it! Ship It! - Alex Merry On Nov. 7, 2013, 1:12 p.m.,

Re: Review Request 113703: Fix KRoss standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/#review43222 --- Ship it! Ship It! - Alex Merry On Nov. 7, 2013, 1:45 p.m.,

Re: Review Request 113703: Fix KRoss standalone build

> On Nov. 7, 2013, 11:50 a.m., Alex Merry wrote: > > tier3/kross/CMakeLists.txt, lines 29-31 > > > > > > These shouldn't be needed; we should fix how KIO is generating > > KIOConfig.cmake first (it's not listing i

Re: Review Request 113703: Fix KRoss standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/ --- (Updated Nov. 7, 2013, 1:45 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 7, 2013, 1:30 p.m.) Review request for KDE Frameworks, Kevin

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

> On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote: > > It's going in the right direction, but I am wondering whether the > > Find*.cmake files should go to extra-cmake-modules instead of being part of > > the framework. You should add Steve (skelly) to the review to get his > > opinion. > >

Re: Review Request 113692: Fix kjsembed standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113692/ --- (Updated Nov. 7, 2013, 1:12 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113693: Fix KNotifyConfig standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/ --- (Updated Nov. 7, 2013, 1:07 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113694: Fix KNewStuff standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/ --- (Updated Nov. 7, 2013, 1:04 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113686: Fix KParts standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/ --- (Updated Nov. 7, 2013, 1:04 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113702: Fix KEmoticons standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43216 --- superbuild/CMakeLists.txt

Re: Review Request 113703: Fix KRoss standalone build

> On Nov. 7, 2013, 12:50 p.m., Alex Merry wrote: > > tier3/kross/CMakeLists.txt, lines 29-31 > > > > > > These shouldn't be needed; we should fix how KIO is generating > > KIOConfig.cmake first (it's not listing i

Re: Review Request 113695: Fix KDEWebKit standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/ --- (Updated Nov. 7, 2013, 12:38 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/#review43214 --- Ship it! Ship It! - Martin Gräßlin On Nov. 6, 2013, 12:54 p

Re: Review Request 113703: Fix KRoss standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/#review43213 --- tier3/kross/CMakeLists.txt

Review Request 113705: Remove unused TIFF kimgio code

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113705/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113704: Fix EPS plugin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113703: Fix KRoss standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113702: Fix KEmoticons standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43211 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 7, 2013, 10:

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

> On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote: > > It's going in the right direction, but I am wondering whether the > > Find*.cmake files should go to extra-cmake-modules instead of being part of > > the framework. You should add Steve (skelly) to the review to get his > > opinion. Wel

Review Request 113702: Fix KEmoticons standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113701: Fix KBookmarks standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: RFC Rules for installation of header files

> On 06/11/13 13:52, Aurélien Gâteau wrote: >> ## Most likely needed for SC >> >> Those headers were already there in KDE4. >> >> - conversion_check.h >> - fixx11h.h >> - kgenericfactory.tcc >> - netwm_def.h >> - netwm.h >> - predicateproperties.h >> - threadweaver installs headers as {lowercase}/{

Re: Review Request 113686: Fix KParts standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43205 --- works fine, but please add kparts to superbuild/CMakeLists.txt.

Re: kservice_to_json dependency troubles

Forgot the patch :/>From 097d935f32683a8c79dc09f6c7207af02ed8243d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aur=C3=A9lien=20G=C3=A2teau?= Date: Thu, 7 Nov 2013 10:37:22 +0100 Subject: [PATCH] Add test for kservice_desktop_to_json --- tier3/kservice/src/desktoptojson/CMakeLists.txt | 1 + tier3/k

kservice_to_json dependency troubles

Hi, I have been investigating some weird build failures on build.kde.org yesterday: http://build.kde.org/job/kde-workspace_master_qt5/1432/console (error is at 12:04:37) I found out this is a dependency issue: the new json system should run commands in this order (commands are simplified):

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43202 --- It's going in the right direction, but I am wondering whether t