Re: Review Request 113681: Fix xmlgui standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113681/ --- (Updated Nov. 7, 2013, 7:54 a.m.) Status -- This change has been mark

Re: Review Request 113681: Fix xmlgui standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113681/#review43197 --- This review has been submitted with commit 8d1f730409b695ac8fb

Re: KF5 Update Meeting Minutes 2013-w45

On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote: > * sandsmark cleaned up KTextEditorSpellingInterface; I think this was discussed before, but I forgot it again :( The KTextEditor stuff, will it stay in KDELibs for KF5? Or will it be moved to Kate as a public interface to its part? Th

Re: Review Request 113681: Fix xmlgui standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113681/#review43191 --- Ship it! Ship It! - Kevin Ottens On Nov. 6, 2013, 3:09 p.m.

Review Request 113696: Rename knewstuff private headers to _p.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113696/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113695: Fix KDEWebKit standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113684: Make KunitConversion build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113684/#review43181 --- This review has been submitted with commit 419c56101bb8e8f481a

Re: Review Request 113684: Make KunitConversion build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113684/ --- (Updated Nov. 6, 2013, 5:42 p.m.) Status -- This change has been mark

Review Request 113694: Fix KNewStuff standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

> On Nov. 6, 2013, 3:37 p.m., Martin Gräßlin wrote: > > tier1/kwidgetsaddons/src/kpassivepopup.h, line 203 > > > > > > I was wondering why the width an height are set to 0: wouldn't it be > > better to return a Q

Review Request 113693: Fix KNotifyConfig standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113692: Fix kjsembed standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113692/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113686: Fix KParts standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113681: Fix xmlgui standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113681/#review43172 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 6, 2013, 3:0

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1599

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

> On Nov. 6, 2013, 4:37 p.m., Martin Gräßlin wrote: > > tier1/kwidgetsaddons/src/kpassivepopup.h, line 203 > > > > > > I was wondering why the width an height are set to 0: wouldn't it be > > better to return a Q

Re: Review Request 113684: Make KunitConversion build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113684/#review43167 --- Ship it! Ship It! - Alex Merry On Nov. 6, 2013, 3:38 p.m.,

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

> On Nov. 6, 2013, 3:37 p.m., Martin Gräßlin wrote: > > The X related code looks fine to me as long as QDesktopWidget is working > > properly ;-) It returns the right value (_NET_WORKAREA) for availableGeometry() (both by inspection of the code and by testing). > On Nov. 6, 2013, 3:37 p.m.,

Re: Review Request 113684: Make KunitConversion build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113684/ --- (Updated Nov. 6, 2013, 3:38 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/#review43156 --- The X related code looks fine to me as long as QDesktopWidget i

Re: Review Request 113684: Make KunitConversion build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113684/#review43155 --- https://git.reviewboard.kde.org/r/113677/ was just committed.

Review Request 113685: New KColorSchemeManager to support changing color scheme in app

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/ --- Review request for KDE Frameworks, Gilles Caulier and Boudewijn Rempt. Rep

Re: Review Request 113677: Fix standalone build of KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113677/ --- (Updated Nov. 6, 2013, 3:20 p.m.) Status -- This change has been mark

Re: Review Request 113677: Fix standalone build of KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113677/#review43154 --- This review has been submitted with commit f22e36d3a4b071980bf

Review Request 113684: Make KunitConversion build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113684/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113681: Fix xmlgui standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113681/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: RFC Rules for installation of header files

On 06/11/13 13:52, Aurélien Gâteau wrote: > ## Most likely needed for SC > > Those headers were already there in KDE4. > > - conversion_check.h > - fixx11h.h > - kgenericfactory.tcc > - netwm_def.h > - netwm.h > - predicateproperties.h > - threadweaver installs headers as {lowercase}/{CamelCase}.

Re: Review Request 113646: Fix KTextWidgets standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113646/#review43151 --- This review has been submitted with commit d128665de1566606882

Re: Review Request 113646: Fix KTextWidgets standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113646/ --- (Updated Nov. 6, 2013, 2:24 p.m.) Status -- This change has been mark

Re: Review Request 113646: Fix KTextWidgets standalone build

> On Nov. 5, 2013, 4:04 p.m., Aleix Pol Gonzalez wrote: > > tier3/ktextwidgets/src/widgets/ktextedit.cpp, line 38 > > > > > > Maybe Sonnet is not exporting the include directories properly? I verified: Sonnet corr

RFC Rules for installation of header files

Yesterday frameworks meeting spawned a discussion regarding folders in header files. I think the consensus is there should be two different situations: 1. 'k' prefixed header files If the header files of a framework are prefixed with a 'k', then headers should be installed in include and conveni

Re: Review Request 113677: Fix standalone build of KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113677/#review43149 --- Ship it! Ship It! - Stephen Kelly On Nov. 6, 2013, 1:32 p.m

Re: Review Request 113650: Adopt ecm_generate_headers in KParts framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113650/ --- (Updated Nov. 6, 2013, 1:35 p.m.) Status -- This change has been mark

Re: Review Request 113650: Adopt ecm_generate_headers in KParts framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113650/#review43148 --- This review has been submitted with commit 60ef9f8b7ed7c72bb5f

Review Request 113677: Fix standalone build of KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113677/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113650: Adopt ecm_generate_headers in KParts framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113650/#review43147 --- Ship it! Ship It! - Stephen Kelly On Nov. 6, 2013, 1:14 p.m

Re: Review Request 113650: Adopt ecm_generate_headers in KParts framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113650/ --- (Updated Nov. 6, 2013, 1:14 p.m.) Review request for KDE Frameworks, Alexa

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/ --- (Updated Nov. 6, 2013, 11:54 a.m.) Review request for KDE Frameworks, Fred