Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Oct. 29, 2013, 3:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps? > > Fredrik Höglund wrote: > The default dept

Build failed in Jenkins: kdelibs_stable #893

See -- Started by remote host 127.0.0.1 with note: Triggered by commit Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

> On Nov. 4, 2013, 3:48 p.m., Kevin Ottens wrote: > > tier4/kde4support/tests/CMakeLists.txt, line 7 > > > > > > Shouldn't that be KF5::KNotifications? Yeah, that was copypasta. I guess I may as well change them a

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/ --- (Updated Nov. 4, 2013, 10:17 p.m.) Review request for KDE Frameworks. Ch

Review Request 113631: Allow compiling kwindowsystem on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps? The default depth is 30 when you're using the NVI

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43016 --- This review has been submitted with commit ba89f8a1dd8bf958c11

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43015 --- This review has been submitted with commit 10470bbdd1dd58f6537

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 4, 2013, 7:58 p.m.) Status -- This change has been mark

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43013 --- This review has been submitted with commit 3fc2059cfc863b5b99c

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 4, 2013, 7:59 p.m.) Status -- This change has been mark

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43019 --- This review has been submitted with commit a4f04712a73f46d740f

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43017 --- This review has been submitted with commit bd1734a09bb18ec9db1

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43018 --- This review has been submitted with commit 928e22dba193fc1b412

Re: Review Request 113589: Allow test-kconf_update to run before kconfig is installed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/ --- (Updated Nov. 4, 2013, 7:58 p.m.) Status -- This change has been mark

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43014 --- This review has been submitted with commit cced5d95d5b4ad47d88

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43003 --- This review has been submitted with commit 7d21b11b3cbb464e4ef

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43008 --- This review has been submitted with commit 66ada97096ef1b01af2

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43006 --- This review has been submitted with commit dc2ee505b6dbc3e11b9

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43010 --- This review has been submitted with commit 8404a524f2f99021440

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43002 --- This review has been submitted with commit 0c6dad468d06d45a68c

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43006 --- This review has been submitted with commit 4fa0949c5a60ed9d282

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43009 --- This review has been submitted with commit 0c5d856cade6fd0c06d

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43011 --- This review has been submitted with commit 7fcde34e2cb197250e4

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43005 --- This review has been submitted with commit 9b07bdb0fcf04ea7fa3

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43007 --- This review has been submitted with commit cf4ca76056d95f4a214

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43004 --- This review has been submitted with commit 586362f10e1a34f30df

Re: Review Request 113589: Allow test-kconf_update to run before kconfig is installed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/#review43012 --- This review has been submitted with commit cdde13df711e2e0f4ae

Re: Review Request 113500: make KNewStuff build on its own

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113500/ --- (Updated Nov. 4, 2013, 12:52 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113606: Fix standalone build of KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113606/#review42982 --- Ship it! Ship It! - Kevin Ottens On Nov. 4, 2013, 4:31 p.m.

Re: Review Request 113609: Fix standalone build of kservice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113609/#review42981 --- Ship it! Ship It! - Kevin Ottens On Nov. 4, 2013, 5:38 p.m.

Re: Review Request 113625: Prepare KHTML for moving into tier4.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/#review42979 --- khtml/src/CMakeLists.txt

Review Request 113625: Prepare KHTML for moving into tier4.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113609: Fix standalone build of kservice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113609/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/ --- (Updated Nov. 4, 2013, 4:54 p.m.) Status -- This change has been mark

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Nov. 4, 2013, 4:12 p.m., John Layt wrote: > > I've asked on the Qt Development list about Qt 5 Solaris support. I'm told > > it builds and works to some extent, and patches are welcome, but not > > without having been tested on a real Solaris build first, which I have no > > desire to do

Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/#review42975 --- This review has been submitted with commit 1e1b33ea862bcbcfdf2

Review Request 113606: Fix standalone build of KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113606/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Nov. 4, 2013, 4:12 p.m., John Layt wrote: > > I've asked on the Qt Development list about Qt 5 Solaris support. I'm told > > it builds and works to some extent, and patches are welcome, but not > > without having been tested on a real Solaris build first, which I have no > > desire to do

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42961 --- I've asked on the Qt Development list about Qt 5 Solaris suppor

KF5 Update Meeting 2013-w45 Reminder

Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/#review42960 --- Ship it! Ship It! - Kevin Ottens On Nov. 4, 2013, 11:33 a.m

Re: Review Request 113586: More general warning cleanups

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review42959 --- Ship it! Ship It! - Kevin Ottens On Nov. 3, 2013, 5:24 p.m.

Re: Review Request 113589: Allow test-kconf_update to run before kconfig is installed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/#review42958 --- Ship it! Ship It! - Kevin Ottens On Nov. 3, 2013, 3:05 p.m.

Re: Review Request 112896: Rework NETWM classes

> On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. > > Martin Gräßlin wrote: > my aim was to write the unit te

Re: Review Request 113536: General cleanups of kguiaddons/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review42957 --- Ship it! Ship It! - Kevin Ottens On Nov. 2, 2013, 2:32 p.m.

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/#review42956 --- Small nitpick, otherwise looks fine. tier2/kjobwidgets/src/kd

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42954 --- Looks OK to me, but I'd like John to give it a last look. - Ke

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/#review42955 --- tier4/kde4support/tests/CMakeLists.txt

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 30, 2013, 10:47 a.m., David Faure wrote: > > Looks good to me (apart from the expired pastebin links in the initial > > description). > > > > I can't "Ship it" because I'm not a cmake guru/maintainer though. Same here, looks OK, but I'd like Alex or Stephen to give it the ship it.

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 4, 2013, 4:41 p.m.) Review request for KDE Frameworks, Alexa

Re: KEmailSettings and ksendbugmail

On Monday, November 04, 2013 12:15:50 Kevin Ottens wrote: > > KEmailSettings definitely belongs to a "core" library, not to a "gui" one. > > OK then. > > I still think that semantically, it'd fit better in something more "PIM" or > "desktop consistency" related... but since I can't find anything

Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: KEmailSettings and ksendbugmail

On Monday 04 November 2013 11:24:37 David Faure wrote: > On Sunday 03 November 2013 13:05:09 Kevin Ottens wrote: > > Hello, > > > > On Sunday 03 November 2013 10:14:57 David Faure wrote: > > > KEmailSettings has historically been in KIO. > > > It's however, just a bunch of KConfig calls. > > > >

Re: Review Request 113522: Improve documentation in ECMInstallIcons.cmake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/#review42936 --- This review has been submitted with commit c4a1d70dc4e8501fbbf

Re: Review Request 113522: Improve documentation in ECMInstallIcons.cmake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/ --- (Updated Nov. 4, 2013, 11:13 a.m.) Status -- This change has been mar

Re: KEmailSettings and ksendbugmail

On Sunday 03 November 2013 13:05:09 Kevin Ottens wrote: > Hello, > > On Sunday 03 November 2013 10:14:57 David Faure wrote: > > KEmailSettings has historically been in KIO. > > It's however, just a bunch of KConfig calls. > > > > ksendbugmail is a separate program used by tier3/xmlgui/src/kbugrep

Re: Review Request 113533: Adapt KCMInit to use DBus to communicate with KSplash

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113533/ --- (Updated Nov. 4, 2013, 10:17 a.m.) Status -- This change has been mar

Re: Review Request 113533: Adapt KCMInit to use DBus to communicate with KSplash

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113533/#review42935 --- This review has been submitted with commit 4948675621c409d3b72

Re: Review Request 113530: Adapt KDED to use DBus to communicate with KSplash

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113530/ --- (Updated Nov. 4, 2013, 10:12 a.m.) Status -- This change has been mar

Re: Review Request 113530: Adapt KDED to use DBus to communicate with KSplash

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113530/#review42932 --- This review has been submitted with commit 501cc1c00994dbf6f3e

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Nov. 4, 2013, 9:14 a.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Oct. 29, 2013, 3:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. I'm lacking ideas on how to test this. Do you know any application which uses 30 bit pixmaps? - Martin --- This is an