Review Request 113436: Deprecate KEmoticonsTheme methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Jenkins build became unstable: kdelibs_stable #868

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_stable #867

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: cyclic dependency kinit - kservice

On Friday 25 October 2013 12:21:28 David Narvaez wrote: > On Fri, Oct 25, 2013 at 11:37 AM, Kevin Ottens wrote: > > Not that I know of, Alex never replied to that I think... > > What would be a proper fix for this? Separating kbuildsycoca and > putting it on top of kinit? I'd lean more toward ha

Re: Use of the WIN32 executable property

2013/10/25 David Faure : > On Wednesday 02 October 2013 23:52:08 Nicolás Alvarez wrote: >> In fact, I wonder if we should make all tests console applications by >> default (in ecm_mark_as_test?)... > > All unittests, yes. > > But interactive test apps are really just normal test apps, there's no re

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

> On Oct. 25, 2013, 5:40 p.m., Stephen Kelly wrote: > > Why does that library not install a Config.cmake file? Sebas put together a patch to do so, but it needs to be refined because it currently does not work for Qt4 (dbusmenu-qt is Qt4 and Qt5). Furthermore, the upstream project needs to acc

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/#review42361 --- Why does that library not install a Config.cmake file? - Steph

Re: cyclic dependency kinit - kservice

On Friday 25 October 2013 11:14:19 David Narvaez wrote: > On Mon, Oct 21, 2013 at 12:08 PM, Kevin Ottens wrote: > > On Monday 21 October 2013 17:01:44 Treeve Jelbert wrote: > >> kinit needs kservice and installs KInitMacros.cmake which defines > >> kf5_add_kdeinit_executable which is needed by kse

Review Request 113432: Install FindDBusMenuQt5.cmake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/ --- Review request for KDE Frameworks, Sebastian Kügler and Stephen Kelly. Rep

Re: Review Request 113402: Fix KI18n standalone build

> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Review Request 113430: More warnings fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Dirty CMake master content in install directory

Hello, If you use CMake master, then you may have unused stuff in your install directory versioned by commit sha: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8433 The issue is resolved in the CMake next branch, and will be merged to master next week probably. Thanks, S

Re: Review Request 113395: Enable KConfig on Windows

> On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: > > tier1/kconfig/src/core/kconfigini.cpp, line 425 > > > > > > Files have no owner on Windows. QFileInfo::ownerId() always returns -2 > > on Windows a

Re: Review Request 113391: Remove unnecessary #includes for moc files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/#review42344 --- This review has been submitted with commit 8a86b081e66726ffc45

Re: Review Request 113391: Remove unnecessary #includes for moc files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/ --- (Updated Oct. 25, 2013, 10:05 a.m.) Status -- This change has been ma

Re: Review Request 113378: Trivial warning fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42343 --- This review has been submitted with commit 139a09daf188129c470

Re: Review Request 113373: Enable C++11 support by default.

On Friday 25 October 2013 11:38:40 Stephen Kelly wrote: > Kevin Ottens wrote: > >> That could obsolete ecm_mark_as_test etc. > > > > Sure, I don't see how that's different from classes or methods we have in > > our libraries at the moment which will get obsoleted by some later Qt > > version. With

Re: Review Request 113373: Enable C++11 support by default.

Kevin Ottens wrote: >> That could obsolete ecm_mark_as_test etc. > > Sure, I don't see how that's different from classes or methods we have in > our libraries at the moment which will get obsoleted by some later Qt > version. With that line of thinking we'd never release. > > Just mark modules w

Re: Review Request 113373: Enable C++11 support by default.

On Friday 25 October 2013 11:22:26 Stephen Kelly wrote: > Kevin Ottens wrote: > >> Stephen Kelly wrote: > >>It's not my decision either. It's just a recommendation. > >> > >> Aleix Pol Gonzalez wrote: > >>I object. > >>What's the big impediment of releasing ECM? If there's an impediment, > >>let's

Re: Review Request 113373: Enable C++11 support by default.

Kevin Ottens wrote: >> Stephen Kelly wrote: >>It's not my decision either. It's just a recommendation. >> >> Aleix Pol Gonzalez wrote: >>I object. >>What's the big impediment of releasing ECM? If there's an impediment, >>let's fix it. > > I agree with Aleix here. I think it's important that the f

Re: Google Code-In

On Friday 25 October 2013 08:59:27 Sune Vuorela wrote: > On 2013-10-25, Kevin Ottens wrote: > > I got contacted by Lydia because the Google Code-In will soon start and= > > > > we=20 > > > > could maybe give out tasks to people. I think that's a good idea, and o= > > ne area=20 > > is "port kde

Re: Google Code-In

On 2013-10-25, Kevin Ottens wrote: > I got contacted by Lydia because the Google Code-In will soon start and= > we=20 > could maybe give out tasks to people. I think that's a good idea, and o= > ne area=20 > is "port kdeexamples to KF5". If we split it per example in the repo, i= > t makes=20 > f

Re: Review Request 113391: Remove unnecessary #includes for moc files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/#review42337 --- Ship it! Ship It! - David Faure On Oct. 22, 2013, 4:23 p.m.

Re: Review Request 113371: Kross: Remove the KJs backened

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/#review42338 --- Ship it! If he says so :) - David Faure On Oct. 21, 2013, 4

Re: Review Request 113395: Enable KConfig on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42335 --- Looks good to me (don't know about the ownerId() stuff. Maybe Q

Re: Review Request 113378: Trivial warning fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42334 --- Ship it! Looks good, except for one hunk. kioslave/file/file

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review42333 --- Ship it! tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovid

Re: Use of the WIN32 executable property

On Wednesday 02 October 2013 23:52:08 Nicolás Alvarez wrote: > In fact, I wonder if we should make all tests console applications by > default (in ecm_mark_as_test?)... All unittests, yes. But interactive test apps are really just normal test apps, there's no reason for them to behave differentl

Re: KDirWatch vs QFileSystemWatcher

On Thursday 24 October 2013 21:54:42 Sune Vuorela wrote: > Hi > > If your KDirWatch backend is QFileSystemWatcher, one of the testcases > fails. > > The last QVERIFY in testMoveTo never receives the signal dirty-signal it > is looking for. > > Apparantly, the watch.removeFile apparantly somehow

Re: extra-cmake-modules: remove ECMPrintVariables.cmake

On Thursday 24 October 2013 22:29:51 Alexander Neundorf wrote: > If somebody feels like it, I think it would be a good idea to remove > ECMPrintVariables.cmake, now that there is a replacement in cmake. Makes sense IMO. Thanks for pointing it out. Regards. -- Kévin Ottens, http://ervin.ipsquad.n

Re: Review Request 113402: Fix KI18n standalone build

> On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113373: Enable C++11 support by default.

> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote: > > As far as I know, only threadweaver and karchive will be released in > > December. The rest of the frameworks won't be released until summer. > > > > By summer, CMake 3.0.0 will most likely be out. > > Volker Krause wrote: > while th

Re: Porting away from KLocale

On Thursday 24 October 2013 19:22:02 Albert Astals Cid wrote: > El Dijous, 24 d'octubre de 2013, a les 17:44:01, Kevin Ottens va escriure: > > On Thursday 24 October 2013 16:56:47 John Layt wrote: > > > On 24 October 2013 07:33, Kevin Ottens wrote: > > > > On Wednesday 23 October 2013 20:40:19 Joh

Google Code-In

Hello all, I got contacted by Lydia because the Google Code-In will soon start and we could maybe give out tasks to people. I think that's a good idea, and one area is "port kdeexamples to KF5". If we split it per example in the repo, it makes for nice small tasks, is easy to have them in paral