Re: Review Request 113395: Enable KConfig on Windows

2013-10-22 Thread Andrius da Costa Ribas
> On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: > > tier1/kconfig/src/core/kconfigini.cpp, line 425 > > > > > > Files have no owner on Windows. QFileInfo::ownerId() always returns -2 > > on Windows a

Re: Review Request 113395: Enable KConfig on Windows

2013-10-22 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42192 --- tier1/kconfig/src/core/kconfigini.cpp

Review Request 113395: Enable KConfig on Windows

2013-10-22 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/#review42188 --- This review has been submitted with commit b2e2218bc7677ac8f34

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

2013-10-22 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 22, 2013, 10:09 p.m.) Status -- This change has been ma

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-22 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 22, 2013, 9:51 p.m.) Status -- This change has been mar

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review42187 --- This review has been submitted with commit 9d0d6b4b5fef67b2154

Review Request 113393: Get KPassivePopup positioning in a semi-working state

2013-10-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Keep the Things You Forgot

2013-10-22 Thread Aaron J. Seigo
hi :) (i stole the subject without shame. but it seemed appropriate given the topic) we’ve all gotten out of the habit of communicating with the outside world, with some notable exceptions. Martin, in particular, has become an outstanding blogger. the rest of us have been overly quiet. i’m wor

Jenkins build is back to normal : plasma-framework_master_qt5 #843

2013-10-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #842

2013-10-22 Thread KDE CI System
See -- [...truncated 538 lines...] :0: Note: No relevant classes found. No output generated. Built target Pla

Re: Review Request 113376: KDirWatch: don't check for symlinks on Windows.

2013-10-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113376/#review42172 --- Ship it! Inspecting the code, you don't seem to have changed t

Build failed in Jenkins: plasma-framework_master_qt5 #841

2013-10-22 Thread KDE CI System
See -- Started by user ervin Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [plasma-framework_master_qt5] $ /bin/

Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/#review42171 --- Ship it! Looks sane to me. - Alex Merry On Oct. 21, 2013, 1

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-22 Thread Jeremy Whiting
> On Oct. 22, 2013, 10:46 a.m., Alex Merry wrote: > > knewstuff/src/uploaddialog.cpp, lines 823-833 > > > > > > Does this actually produce a list of the right form? It looks like it > > will generate something l

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Fra

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/#review42163 --- knewstuff/src/uploaddialog.cpp

Review Request 113391: Remove unnecessary #includes for moc files

2013-10-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113391/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Build failed in Jenkins: plasma-framework_master_qt5 #840

2013-10-22 Thread KDE CI System
See Changes: [notmart] stub for activitySwitcher component [ervin] KLocale moved in KDE4Support [ervin] KDE4Attic is gone -- [...truncated 795 lines...] CMakeFiles/localebindingsplugin.di

Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-22 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113378: Trivial warning fixes

2013-10-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- (Updated Oct. 22, 2013, 4:01 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113378: Trivial warning fixes

2013-10-22 Thread Alex Merry
> On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote: > > tier3/xmlgui/autotests/kactioncategorytest.cpp, line 92 > > > > > > Maybe a better solution here would be to change the Q_ASSERT into > > QVERIFY or QCOMPA

Build failed in Jenkins: plasma-framework_master_qt5 #839

2013-10-22 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace Running Prebuild s

Re: Review Request 113378: Trivial warning fixes

2013-10-22 Thread Alex Merry
> On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote: > > interfaces/kimproxy/library/kimproxy.cpp, line 578 > > > > > > Not sure it is really useful to keep this line at all I left this commented because there i

KF5 Update Meeting Minutes 2013-w43

2013-10-22 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 43 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, dfaure, dMaggot, jpwhiting, mck182, PovAddict, sebas, teo, vHanda and myself. Announcement: * All new code should use qCDebug and friends

Re: Review Request 113378: Trivial warning fixes

2013-10-22 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42160 --- interfaces/kimproxy/library/kimproxy.cpp

Re: KF5 Update Meeting 2013-w43 Reminder

2013-10-22 Thread Mark
You "could" make an announcement that people should look into using the categorized debugging when porting new stuff. It is now documented on the wiki [1] to get people started. :) [1] http://community.kde.org/index.php?title=Frameworks/Porting_To_qCDebug On Tue, Oct 22, 2013 at 8:08 AM, Kevin Ot

Re: Porting away from KLocale

2013-10-22 Thread David Faure
On Thursday 17 October 2013 23:47:40 Aleix Pol wrote: > Well maybe I could help with this, but I'd need to know what do you think > it would be the most appropriate solution. I'd say, split it out into a separate function for KF5, and later on, if you feel like it, contribute it to Qt for 5.3. -

Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-22 Thread Sebastian Kügler
On Monday, October 21, 2013 21:28:18 Nicolás Alvarez wrote: > 2013/10/21 Sebastian Kügler > > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/113377/ > > > > Review request for KDE Frameworks and Stephen Kelly. > > By Sebastian Kügler. > > Repos

DBusMenuQt cmake *Config

2013-10-22 Thread Sebastian Kügler
Hi Aurelien, Let's try again to finally get this resolved. :) Attached, the necessary cmake foo to have find_package(DBusMenuQt NO_MODULE) work like other frameworks do. The .diff should work, but someone had problems applying it during testing, so I've attached the whole files as well. (Maybe

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1466

2013-10-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113266: introduce KMessageBoxNotifyInterface to support notifications

2013-10-22 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113266/ --- (Updated Oct. 22, 2013, 12:04 p.m.) Status -- This change has been ma

Jenkins build is back to normal : plasma-framework_master_qt5 #831

2013-10-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Forward includes

2013-10-22 Thread Ivan Čukić
> The above is pretty much it on my side, but I'd like to add something: > We should get those forwarding includes generated to not have to maintain Lets bring this topic back from the dead. I don't have a real preference between include/Module, include/KDE/Module and include/KF5/Module. Main

Build failed in Jenkins: plasma-framework_master_qt5 #830

2013-10-22 Thread KDE CI System
See Changes: [notmart] remove dead code -- [...truncated 327 lines...] Automoc for target fullmodelaccesstest Scanning dependencies of target plasmaextracomponentsplugin_automoc Scanning de

Include path issues in CMake

2013-10-22 Thread Ben Cooksley
Hi all, It seems after the recent activation of KActivities that the usual issue of include/ and include/KDE/ has once again reared it's head. Do we have a proper solution for this which can be broadly applied across all frameworks, no matter if they are included in kdelibs[frameworks] or other s

Jenkins build became unstable: kdelibs_frameworks_qt5 #1465

2013-10-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-22 Thread Milian Wolff
On Monday 21 October 2013 15:25:41 Michael Pyne wrote: > > On Sept. 23, 2013, 9:12 a.m., Kevin Ottens wrote: > > > Any reason why this patch isn't committed yet? Please do so ASAP. > > > > Kevin Ottens wrote: > > Any news? > > > > I'll close it as discarded if I don't see any activity

Re: Projects adding dependencies without clear indication of requirements

2013-10-22 Thread Ben Cooksley
On Tue, Oct 22, 2013 at 6:59 PM, Ivan Čukić wrote: > The dependency is kactivities/frameworks branch which does not depend on > nepomuk-core nor soprano. > > Deps for kactivities are: > > -- The following OPTIONAL packages have been found: > > * KDBusAddons > * KWindowSystem > * KCoreAddons >

Jenkins build is back to normal : plasma-framework_master_qt5 #829

2013-10-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #828

2013-10-22 Thread KDE CI System
See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [plasma-framework_master_qt5]