Re: Review Request 113267: Install kglobalshortcutinfo_p.h

2013-10-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267/ --- (Updated Oct. 18, 2013, 6:58 a.m.) Status -- This change has been dis

Re: Porting away from KLocale

2013-10-17 Thread Aleix Pol
On Thu, Oct 17, 2013 at 11:30 PM, John Layt wrote: > On 17 October 2013 01:51, Aleix Pol wrote: > > Hi, > > I was trying to port some application to Qt/KF5, then I realized that I > > didn't know how to port KLocale::formatByteSize. I don't see anything in > > QLocale for this, so I feel a bit s

Re: Porting away from KLocale

2013-10-17 Thread John Layt
On 17 October 2013 01:51, Aleix Pol wrote: > Hi, > I was trying to port some application to Qt/KF5, then I realized that I > didn't know how to port KLocale::formatByteSize. I don't see anything in > QLocale for this, so I feel a bit stuck. Also I don't see any information in > KDE5Porting.html >

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 17, 2013, 9:13 p.m.) Review request for KDE Runtime, KDE Fra

Re: Compile kdelibs-frameworks without tests

2013-10-17 Thread Aleix Pol
On Thu, Oct 17, 2013 at 8:23 AM, Bhushan Shah wrote: > Hello! > > I want to compile kde library without building tests or auto tests. > Reason behind this is I want to speed up compiling process.. Martin > Gräßlin suggested me to use > > -DKDE4_BUILD_TESTS=FALSE -DBUILD_TESTING=FALSE > > cmake op

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-17 Thread Martin Klapetek
> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
> On Oct. 17, 2013, 7:27 p.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 199 > > > > > > why did you choose "_path" instead of just "path"? > > Nicolás Alvarez wrote: > Becau

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4:53 p.m.) Review request for KDE Frameworks and k

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
> On Oct. 17, 2013, 4:27 p.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch.cpp, line 1225 > > > > > > I think this could be better as uncommenting the variable and using > > Q_UNUSED (and m

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41907 --- Good job! I think this can go in, but I'd like someone else app

Compile kdelibs-frameworks without tests

2013-10-17 Thread Bhushan Shah
Hello! I want to compile kde library without building tests or auto tests. Reason behind this is I want to speed up compiling process.. Martin Gräßlin suggested me to use -DKDE4_BUILD_TESTS=FALSE -DBUILD_TESTING=FALSE cmake options but this options are not working, with this option cmake fails t

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4:05 p.m.) Review request for KDE Frameworks and k

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4 p.m.) Review request for KDE Frameworks and kdel

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
> On Oct. 17, 2013, 4:46 a.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 183 > > > > > > Spaces inside -> "KDirWatch *, bool" I added the parameter names to kdirwatch_p.h too.

Re: Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem

2013-10-17 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/ --- (Updated Oct. 17, 2013, 5:33 p.m.) Status -- This change has been mar

Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/#review41895 --- This review has been submitted with commit 7b4c83df7f09e3585cf

Re: Review Request 113248: Cleanup KNotifyConfig

2013-10-17 Thread Aleix Pol Gonzalez
> On Oct. 15, 2013, 1:51 p.m., Aurélien Gâteau wrote: > > Standalone build fails here with this message: > > > > -- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake > > (found suitable version "5.0.0", minimum required is "5.0.0") found > > components: CMake Compiler Ins

Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/ --- (Updated Oct. 17, 2013, 3:04 p.m.) Status -- This change has been mar

Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-17 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Repositor

KI18n requires KJS internals

2013-10-17 Thread Aurélien Gâteau
Hi, Today I tried to ensure KI18n could build standalone, but I found out it builds a plugin library, ktranscript, which requires KJS internals: it generates a lookup table with a Perl script from KJS and #include a bunch of KJS uninstalled headers (see ktranscript.cpp). What should be done he

Re: Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem

2013-10-17 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/#review41881 --- Ship it! Ship It! - Stephen Kelly On Oct. 17, 2013, 10:04 a

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-17 Thread Sebastian Kügler
> On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote: > > KDE5PORTING.html, lines 290-295 > > > > > > This is not valid anymore. It should now be > > qC and with a category. I think it;s best to just > > link to the

Re: Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem

2013-10-17 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/ --- (Updated Oct. 17, 2013, 12:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 113300: Improve porting to Qt/KF5 scripts

2013-10-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113300/#review41874 --- Ship it! Looks good. Feel free to push your changes to these s

Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-17 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/#review41873 --- Ship it! Looks good to me. It's strange to have exported funct

Re: Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem

2013-10-17 Thread Aurélien Gâteau
> On Oct. 17, 2013, 1:16 a.m., Aleix Pol Gonzalez wrote: > > tier1/kidletime/CMakeLists.txt, line 5 > > > > > > really needed? I think it helps structuring the file, especially if it gets more widespread. - Aurél

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-17 Thread Martin Klapetek
> On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote: > > KDE5PORTING.html, lines 290-295 > > > > > > This is not valid anymore. It should now be > > qC and with a category. I think it;s best to just > > link to the

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-17 Thread Mark Gaiser
> On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote: > > KDE5PORTING.html, lines 290-295 > > > > > > This is not valid anymore. It should now be > > qC and with a category. I think it;s best to just > > link to the

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41860 --- There are couple issues still, I pointed only bunch of them as

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-17 Thread Martin Klapetek
> On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote: > > KDE5PORTING.html, lines 290-295 > > > > > > This is not valid anymore. It should now be > > qC and with a category. I think it;s best to just > > link to the