Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/#review41858 --- I find this a better solution. So if I compare my review with t

Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kdelibs

Re: CMake fails configuring KF5

2013-10-16 Thread David Gil Oliva
Hi! 2013/10/17 Nicolás Alvarez > 2013/10/17 David Gil Oliva : > > Hi! > > > > I'm getting this error from CMake while building KF5: > > > > -- Found KF5: > > /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake > > (found suitable version "5.0.0", minimum required is "5.0.0")

Re: Review Request 113267: Install kglobalshortcutinfo_p.h

2013-10-16 Thread Martin Gräßlin
> On Oct. 17, 2013, 6:36 a.m., David Edmundson wrote: > > Clients using this can build a header file from the installed XML service > > file using qt5_add_dbus_interface. > > try it! It doesn't work. That's the whole point why I opened the review request. The build fails because it needs to in

Re: KF5 Update Meeting Minutes 2013-w42

2013-10-16 Thread Kevin Ottens
On Wednesday 16 October 2013 19:17:06 Alexander Neundorf wrote: > On Tuesday 15 October 2013, Kevin Ottens wrote: > > Hello everyone, > > .. > > > * steveire recommends _LIBRARIES variables from Config files and the > > > > template, > > Is there a verb missing in this sentence ? Oops, yes in

Re: CMake fails configuring KF5

2013-10-16 Thread Nicolás Alvarez
2013/10/17 David Gil Oliva : > Hi! > > I'm getting this error from CMake while building KF5: > > -- Found KF5: > /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake > (found suitable version "5.0.0", minimum required is "5.0.0") found > components: CMake Compiler InstallDirs > C

Re: CMake fails configuring KF5

2013-10-16 Thread Aleix Pol
On Thu, Oct 17, 2013 at 6:59 AM, David Gil Oliva wrote: > Hi! > > I'm getting this error from CMake while building KF5: > > -- Found KF5: > /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake > (found suitable version "5.0.0", minimum required is "5.0.0") found > components: CM

Review Request 113300: Improve porting to Qt/KF5 scripts

2013-10-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113300/ --- Review request for KDE Frameworks. Repository: plasma-framework Descript

CMake fails configuring KF5

2013-10-16 Thread David Gil Oliva
Hi! I'm getting this error from CMake while building KF5: -- Found KF5: /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake (found suitable version "5.0.0", minimum required is "5.0.0") found components: CMake Compiler InstallDirs CMake Error at /home/david/devel/kf5-developme

Re: Review Request 113267: Install kglobalshortcutinfo_p.h

2013-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267/#review41855 --- Clients using this can build a header file from the installed X

Review Request 113299: KDirWatch code style: braces for one-liner conditionals

2013-10-16 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113299/ --- Review request for KDE Frameworks and kdelibs. Repository: kdelibs Descr

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-16 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 12:51 a.m.) Review request for KDE Frameworks and

Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-16 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- Review request for KDE Frameworks and kdelibs. Repository: kdelibs Descr

Review Request 113297: Remove 'override' from ThreadWeaver::IdDecorator destructor.

2013-10-16 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113297/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Porting away from KLocale

2013-10-16 Thread Aleix Pol
Hi, I was trying to port some application to Qt/KF5, then I realized that I didn't know how to port KLocale::formatByteSize. I don't see anything in QLocale for this, so I feel a bit stuck. Also I don't see any information in KDE5Porting.html Anybody has an idea of what's the solution? Thanks! Al

Re: Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem

2013-10-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/#review41850 --- Ship it! tier1/kidletime/CMakeLists.txt

Re: Helping out with Frameworks 5

2013-10-16 Thread Sebastian Kügler
Hi Casian, On Wednesday, October 16, 2013 14:35:39 Casian Andrei wrote: > I want to help out with Frameworks 5 and/or Plasma 2. Perhaps it is best to > start writing some unit tests, since I am not too familiar with the code. > My favorite activities include removing chunks of obsolete and ugly co

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-16 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/#review41837 --- KDE5PORTING.html

Helping out with Frameworks 5

2013-10-16 Thread Casian Andrei
Hello, I want to help out with Frameworks 5 and/or Plasma 2. Perhaps it is best to start writing some unit tests, since I am not too familiar with the code. My favorite activities include removing chunks of obsolete and ugly code, but this one should be left for another time :-) What should I loo

Re: KF5 Update Meeting Minutes 2013-w42

2013-10-16 Thread Alexander Neundorf
On Tuesday 15 October 2013, Kevin Ottens wrote: > Hello everyone, .. > * steveire recommends _LIBRARIES variables from Config files and the > template, Is there a verb missing in this sentence ? Alex ___ Kde-frameworks-devel mailing list Kde-framework

Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem

2013-10-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/#review41821 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 16, 2013, 7:

Re: Porting notice: kDebug and qDebug need to go to qCDebug.

2013-10-16 Thread David Faure
On Wednesday 16 October 2013 15:08:53 Mark wrote: > On Wed, Oct 16, 2013 at 2:39 PM, David Faure wrote: > > On Tuesday 15 October 2013 21:58:51 Mark wrote: > >> Also, by default when porting to a qCDebug line with a category you > >> won't see log output because custom categories have everything >

Review Request 113267: Install kglobalshortcutinfo_p.h

2013-10-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113266: introduce KMessageBoxNotifyInterface to support notifications

2013-10-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113266/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Porting notice: kDebug and qDebug need to go to qCDebug.

2013-10-16 Thread Mark
On Wed, Oct 16, 2013 at 2:39 PM, David Faure wrote: > On Tuesday 15 October 2013 21:58:51 Mark wrote: >> Also, by default when porting to a qCDebug line with a category you >> won't see log output because custom categories have everything >> disabled by default. > > This has just been fixed in Qt,

Re: Porting notice: kDebug and qDebug need to go to qCDebug.

2013-10-16 Thread David Faure
On Tuesday 15 October 2013 21:58:51 Mark wrote: > Also, by default when porting to a qCDebug line with a category you > won't see log output because custom categories have everything > disabled by default. This has just been fixed in Qt, though. https://codereview.qt-project.org/66744 -- Da

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-16 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review41816 --- Wow, there sure is a lot of code in there catering for all the

Re: Review Request 113256: KMessageBox: Remove last traces of notification support

2013-10-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113256/ --- (Updated Oct. 16, 2013, 11:46 a.m.) Status -- This change has been di

KModifierKeyInfo usage and API

2013-10-16 Thread David Faure
We are still a bit unsure what to do about KModifierKeyInfo in KF5: * It's currently only implemented on X11 (PovAddict says querying for modifiers on Windows is easy to add, but getting notified of changes seems quite problematic) * The API (latching vs locking) seems to be a bit too X11 specif

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/ --- (Updated Oct. 16, 2013, 7:45 a.m.) Review request for KDE Frameworks. Ch