Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/#review41670 --- Why do it just for result and not finished, suspended, resumed?

Re: build.kde.org: Failing ktoolbar_unittest

2013-10-13 Thread Kevin Ottens
Hello, On Friday 11 October 2013 20:10:23 Aleix Pol wrote: > On Fri, Oct 11, 2013 at 6:31 PM, Kevin Ottens wrote: > > ktoolbar_unittest segfaults in the CI. I tried to reproduce the error here > > with no luck so far. If someone who manages to reproduce it or who has > > access to build.kde.org s

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review41661 --- kded/kbuildsycoca.cpp

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #1423

2013-10-13 Thread David Faure
On Sunday 13 October 2013 01:10:34 Nicolás Alvarez wrote: > 2013/10/13 KDE CI System : > > See > > This is a failure in a KArchive test, regarding the assertion > dt.secsTo(creationTime) <= 1. The change that triggered this build > onl

Re: Review Request 112874: Allow disabling of QCA plugins during build.

2013-10-13 Thread Ivan Romanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/#review41650 --- Two issues. 1. all means all possible not all of them. If I ha

CMake, KF5_INCLUDE_DIRS empty?

2013-10-13 Thread Mark
Hi, I used to rely on KF5_INCLUDE_DIRS but since a few days that variable seems to be empty. Did i do something wrong? My CMake file for the relevant parts: find_package(ECM REQUIRED NO_MODULE) set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH}) find_package(KF5 MODULE REQUIRED COMPONENTS CMake Compiler I

Re: Review Request 112874: Allow disabling of QCA plugins during build.

2013-10-13 Thread Uwe L. Korn
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Oct. 13, 2013, 2:06 p.m.) Review request for KDE Frameworks and I

Re: Review Request 112874: Allow disabling of QCA plugins during build.

2013-10-13 Thread Ivan Romanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/#review41645 --- Fail. BUILD_PLUGIN(S). You missed 'S'. BUILD_PLUGINS is a list

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/ --- (Updated Oct. 13, 2013, 1:09 p.m.) Status -- This change has been dis

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-13 Thread Sebastian Kügler
> On Oct. 13, 2013, 8:36 a.m., David Faure wrote: > > tier3/kpty/KPtyConfig.cmake.in, line 12 > > > > > > and remove this line, see 1628dccc5ebc665bcee518131d427c4e22c89512 IOW: Ditch this patch, it's obsolete. :)

Re: Review Request 112874: Allow disabling of QCA plugins during build.

2013-10-13 Thread Uwe L. Korn
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Oct. 13, 2013, 11:32 a.m.) Review request for KDE Frameworks and

Re: plasma-framework build broken

2013-10-13 Thread Stephen Kelly
Sebastian Kügler wrote: > On Saturday, October 12, 2013 21:48:28 Sebastian Kügler wrote: >> It seems that one of your recent commits to plasma-frameworks broke its >> build: >> >> /home/sebas/kf5/src/plasma- >> framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltes >> t.cpp

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1424

2013-10-13 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/#review41626 --- tier3/kpty/KPtyConfig.cmake.in

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/#review41625 --- Ship it! Ship It! - David Faure On Oct. 12, 2013, 6:55 p.m.