Re: update your cmake!

2013-10-10 Thread Aleix Pol
On Fri, Oct 11, 2013 at 2:43 AM, Stephen Kelly wrote: > Aurélien Gâteau wrote: > > > On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: > >> Hi, > >> > >> In order to build KF5 and Plasma2 code, you have to update your cmake to > >> 2.8.12. Otherwise, you'll get build errors. > > > > Oh

Re: update your cmake!

2013-10-10 Thread Stephen Kelly
Aurélien Gâteau wrote: > On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: >> Hi, >> >> In order to build KF5 and Plasma2 code, you have to update your cmake to >> 2.8.12. Otherwise, you'll get build errors. > > Oh... this means we can now make use of ALIAS targets and build truly > s

Re: kio-related build error in plasma-framework

2013-10-10 Thread Sebastian Kügler
On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote: > I'm getting a build error in a few places in plasma-framework, kio isn't > found. I can't seem to figure out why, maybe someone who has a better > overview of what in KIO is where, and what I need to tell cmake to figure > this out? >

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/#review41535 --- kfile/tests/CMakeLists.txt

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41533 --- This review has been submitted with commit a3c7a9690f432170015

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- (Updated Oct. 10, 2013, 6:29 p.m.) Status -- This change has been mar

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 10, 2013, 6:08 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113173: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113173/#review41529 --- This review has been submitted with commit 27dab0e58d5c93a911d

Re: Review Request 113173: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113173/ --- (Updated Oct. 10, 2013, 5:54 p.m.) Status -- This change has been mar

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/#review41528 --- This review has been submitted with commit 0816b86275eb78a8dd0

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/ --- (Updated Oct. 10, 2013, 4:26 p.m.) Status -- This change has been mar

Re: update your cmake!

2013-10-10 Thread Stephen Kelly
Alexander Neundorf wrote: > On Thursday 10 October 2013, Sebastian Kügler wrote: >> Hi, >> >> In order to build KF5 and Plasma2 code, you have to update your cmake to >> 2.8.12. Otherwise, you'll get build errors. > > Doesn't it error out in cmake_minimum_required() ? > If not, I'd suggest that

Re: libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-10 Thread Stephen Kelly
Sebastian Kügler wrote: > Could anyone give me a hint how to fix this? > You are apparently using empty variables like ${QT_QTCORE_LIBRARY}. Those are not defined in Qt 5. -target_link_libraries(NetworkManagerQt ${MODEMMANAGERQT_LIBRARY} ${QT_QTCORE_LIBRARY} ${QT_QTDBUS_LIBRARY} ${QT_QTNETWOR

Re: update your cmake!

2013-10-10 Thread Alexander Neundorf
On Thursday 10 October 2013, Sebastian Kügler wrote: > Hi, > > In order to build KF5 and Plasma2 code, you have to update your cmake to > 2.8.12. Otherwise, you'll get build errors. Doesn't it error out in cmake_minimum_required() ? If not, I'd suggest that somebody takes care of handling this pr

Re: libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-10 Thread Alexander Neundorf
On Wednesday 09 October 2013, Sebastian Kügler wrote: > Hi, > > While porting libnm-qt to Qt5, I'm running into the following problem when > building the tests. I've not seen this error before, and I'd like advice > how to fix it. > > [ 59%] Building CXX object > tests/CMakeFiles/test_8021xsettin

Re: update your cmake!

2013-10-10 Thread Aurélien Gâteau
On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: > Hi, > > In order to build KF5 and Plasma2 code, you have to update your cmake to > 2.8.12. Otherwise, you'll get build errors. Oh... this means we can now make use of ALIAS targets and build truly standalone frameworks \o/ Aurélien

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-10 Thread Aleix Pol Gonzalez
> On Oct. 9, 2013, 5:22 p.m., Kevin Ottens wrote: > > kjsembed/examples/kjsconsole/console.cpp, line 35 > > > > > > Hm actually surprising, where does this include come from? KJS, JSVariableObject.h is where Globa

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-10 Thread Aleix Pol Gonzalez
> On Oct. 9, 2013, 4:19 p.m., David Edmundson wrote: > > kjsembed/kjscmd/kjscmd.cpp, line 78 > > > > > > this seems to break whitespace for no reason? - Aleix ---

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- (Updated Oct. 10, 2013, 1:30 p.m.) Review request for KDE Frameworks. Ch

update your cmake!

2013-10-10 Thread Sebastian Kügler
Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frame

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/#review41508 --- Ship it! These classes have been deprecated for longtime by ne

Re: Review Request 113050: Use enum for KMessageBox return types

2013-10-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/ --- (Updated Oct. 10, 2013, 1:13 p.m.) Status -- This change has been mar

Re: Review Request 113050: Use enum for KMessageBox return types

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/#review41507 --- This review has been submitted with commit 1f1cdd6966df8a0f1f5

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/ --- (Updated Oct. 10, 2013, 12:56 p.m.) Review request for KDE Frameworks. C

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41496 --- Ship it! With the two issues I've pointed out, this patch can

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-10 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/ --- (Updated Oct. 10, 2013, 10:04 a.m.) Review request for KDE Frameworks. C