Re: Jenkins build is back to stable : kdelibs_frameworks_qt5 #1386

2013-10-08 Thread Kevin Ottens
On Wednesday 09 October 2013 06:22:55 KDE CI System wrote: > See \o/ Let's keep kdelibs-frameworks and plasma-framework green now, shall we? Note however that I still have a pesky issue with kded5 getting stuck, but build.kde.org se

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1386

2013-10-08 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112950: Insert the set shortcuts into the internal hash of actions and shortcuts in KGlobalAccel

2013-10-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112950/#review41418 --- This review has been submitted with commit 63866d5cebef2ccceaa

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Sebastian Kügler
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: > > There's also runner-related code in > > src/declarativeimports/{core,runnermodel}, these should be reenabled as > > well. Possibly, they also need changes to make built. I had disabled this > > after a discussion with Aaron (who has ref

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Aleix Pol Gonzalez
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: > > There's also runner-related code in > > src/declarativeimports/{core,runnermodel}, these should be reenabled as > > well. Possibly, they also need changes to make built. I had disabled this > > after a discussion with Aaron (who has ref

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41412 --- src/plasma/CMakeLists.txt

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Sebastian Kügler
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Denis Kuplyakov
> On Sept. 29, 2013, 4:24 p.m., David Faure wrote: > > The name "token" surprises me a bit. Is this a usual naming scheme for > > accessing C++ classes from QML? > > Otherwise I would think the QML code would want to just write KColorScheme. > > > > Maybe the registration could be done in a sta

Review Request 113179: Make the runners compile again

2013-10-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework

KF5 Update Meeting Minutes 2013-w41

2013-10-08 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 41 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, jpwhiting, mck182, sebas, shadeslayer, teo, vHanda, wojtask9 and myself. Announcement: * If you didn't read my email on stop the li

Re: kf5_add_kdeinit_executable broken?

2013-10-08 Thread Aleix Pol
On Tue, Oct 8, 2013 at 2:28 PM, Sebastian Kügler wrote: > Hi, > > in Kwin (kde-workspace) we're running into the following error: > > CMake Error: File /home/sebas/kf5/src/kde- > workspace/kwin/kcmkwin/kwinrules/_KDE5INIT_DUMMY_FILEPATH-NOTFOUND does not > exist. > CMake Error at > /home/sebas/kf

Review Request 113174: Cleanup KJsEmbed

2013-10-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41393 --- Ship it! Ship It! - Aurélien Gâteau On Oct. 8, 2013, 12:08

Re: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-08 Thread Aleix Pol
On Tue, Oct 8, 2013 at 3:50 PM, Stephen Kelly wrote: > Stephen Kelly wrote: > > >> These are defined with "1" if acceptable and undefined if the feature is > >> not present. > > > > This is the problem that should be fixed. > > > > It should be 0 if the feature is not present. Please fix that ins

Re: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-08 Thread Stephen Kelly
Stephen Kelly wrote: >> These are defined with "1" if acceptable and undefined if the feature is >> not present. > > This is the problem that should be fixed. > > It should be 0 if the feature is not present. Please fix that instead. Hmm, or maybe your fix is ok. I don't know where the values

Re: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-08 Thread Stephen Kelly
Aleix Pol Gonzalez wrote: > This patch adds a defined() first, before checking the value, so the > pre-processor doesn't need to consider the variable value, if it's not > present. This seems like a bad idea. > These are defined with "1" if acceptable and undefined if the feature is > not prese

[IMPORTANT] Stop the line events

2013-10-08 Thread Kevin Ottens
Hello people, I said it previously but I'll repeat it again: --- If build.kde.org is not green for kdelibs-frameworks or plasma-framework build, no changes should get in apart from attempts at fixing the problem. --- So far, it has been completely ignored and that's really a bad situation. We m

Review Request 113173: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113173/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113170: Document KInit dependencies

2013-10-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113170/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

kf5_add_kdeinit_executable broken?

2013-10-08 Thread Sebastian Kügler
Hi, in Kwin (kde-workspace) we're running into the following error: CMake Error: File /home/sebas/kf5/src/kde- workspace/kwin/kcmkwin/kwinrules/_KDE5INIT_DUMMY_FILEPATH-NOTFOUND does not exist. CMake Error at /home/sebas/kf5/install/lib64/cmake/KInit/KInitMacros.cmake:17 (configure_file): con

problem linking against kfile, knewstuff3 and kio

2013-10-08 Thread Sebastian Kügler
Hi, I still can't get kde-workspace to build after last week's changes in kdelibs and e-c-m. The problem is not unknown, yet I'm puzzled as to the reasons. Here's the build error: Linking CXX shared library ../../../../lib/libplasma_wallpaper_imageplugin.so /usr/lib64/gcc/x86_64-suse-linux/4.7/

Jenkins build is back to normal : plasma-framework_master_qt5 #790

2013-10-08 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113076/#review41389 --- This review has been submitted with commit 8dda23a557ead9013e1

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113076/ --- (Updated Oct. 8, 2013, 10:16 a.m.) Status -- This change has been mar

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Kevin Ottens
> On Oct. 7, 2013, 2:38 p.m., Martin Gräßlin wrote: > > You broke the build (and forgot to include the REVIEW tag ;-): > > [ 41%] Building CXX object > > kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o > > In file included from > > /home/martin/kf5/src/kdelibs-frameworks/kross/src/cor

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113077/ --- (Updated Oct. 8, 2013, 7:47 a.m.) Status -- This change has been mark

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Vishesh Handa
> On Oct. 7, 2013, 2:38 p.m., Martin Gräßlin wrote: > > You broke the build (and forgot to include the REVIEW tag ;-): > > [ 41%] Building CXX object > > kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o > > In file included from > > /home/martin/kf5/src/kdelibs-frameworks/kross/src/cor

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-08 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113076/#review41381 --- Ship it! Ship It! - Kevin Ottens On Oct. 7, 2013, 12:47 p.m

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-08 Thread Kevin Ottens
> On Oct. 5, 2013, 8:53 a.m., David Faure wrote: > > Good catch about the format string syntax changes between kde and qt. > > > > But why not just add "t" to the format string to include the timezone, as > > it used to do with %Z, instead of the removeTimeZone() function? > > > > Aurélien Gât