Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 7, 2013, 10:08 p.m.) Review request for KDE Frameworks. Ch

Re: more build problems around KIO

On Monday, October 07, 2013 19:13:02 Alexander Neundorf wrote: > As the error message says, KDeclarative links against the imported target > KF5::KIOCore, but that target has not been imported, so cmake errors out. How exactly do I import it? Putting a find_package(KIOCore ${KF5_VERSION} REQUIRE

Re: Review Request 113087: Start preparing KHTML for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113087/ --- (Updated Oct. 7, 2013, 7:42 p.m.) Status -- This change has been mark

Re: Review Request 113087: Start preparing KHTML for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113087/#review41364 --- This review has been submitted with commit e0208120a1ef7ad7026

Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113160: Move KDeclarative to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113160/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113157: Remove Nepomuk dependency from kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113157/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: kio-related build error in plasma-framework

On Saturday 05 October 2013, David Faure wrote: > On Friday 04 October 2013 19:55:52 Sebastian Kügler wrote: > > On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote: > > > Hi, > > > > > > I'm getting a build error in a few places in plasma-framework, kio > > > isn't found. I can't seem to

Re: Review Request 113112: Notify about palette changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/ --- (Updated Oct. 7, 2013, 5:12 p.m.) Status -- This change has been mark

Re: Review Request 113112: Notify about palette changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41361 --- This review has been submitted with commit 240b44cf8a47469bff5

Re: more build problems around KIO

On Monday 07 October 2013, Sebastian Kügler wrote: > Hi, > > I'm still struggling to get kde-workspace (and kde-runtime) to build after > Friday's changes. Following Kevin's change in plasma-framework, I've > removed KIO from the KF5 imports. The problem is now: > > > CMake Warning at > /home/se

Review Request 113155: Port all kde4_add_unit_test uses

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/ --- Review request for KDE Frameworks and kdelibs. Repository: kdelibs Descr

Review Request 113154: Remove KFileMetaDataWidget and friends

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113148: Move and clean KBuildsycoca to KService

> On Oct. 7, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote: > > kded/kbuildsycoca.cpp, line 48 > > > > > > What happens with this? > > Àlex Fiestas wrote: > I vote for removing it, any objections ? Plus I forgot

more build problems around KIO

Hi, I'm still struggling to get kde-workspace (and kde-runtime) to build after Friday's changes. Following Kevin's change in plasma-framework, I've removed KIO from the KF5 imports. The problem is now: CMake Warning at /home/sebas/kf5/install/lib64/cmake/Kross/KrossConfig.cmake:31 (find_pack

Failing Tests in Kross

Hey Sebastian I had taken up the task of moving Kross to tier3, and I noticed that most tests (11/12) are failing. The following tests FAILED: 1 - kross-guiform-py (Failed) 2 - kross-guiform-rb (Failed) 3 - kross-guiqt-py (Failed) 4 - kross-guiqt-rb (Faile

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/#review41356 --- This review has been submitted with commit 222fa49d91bb24a6304

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/ --- (Updated Oct. 7, 2013, 3:41 p.m.) Status -- This change has been mark

Re: Review Request 113077: Get Kross ready for tier3

> On Oct. 7, 2013, 4:38 p.m., Martin Gräßlin wrote: > > You broke the build (and forgot to include the REVIEW tag ;-): > > [ 41%] Building CXX object > > kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o > > In file included from > > /home/martin/kf5/src/kdelibs-frameworks/kross/src/cor

Re: EcmQt4To5Porting

On Friday 04 October 2013 10:51:07 Martin Klapetek wrote: > On Fri, Oct 4, 2013 at 9:22 AM, David Faure wrote: > > On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: > > > There were 2 files recently removed from ECM which broke attica's build, > > > this puts the removed files as local

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/#review41354 --- Ship it! Ship It! - Sebastian Kügler On Oct. 7, 2013, 3:29

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/ --- (Updated Oct. 7, 2013, 3:29 p.m.) Review request for Build System, KDE Fra

Re: Review Request 113149: Make it easier to use frameworks linked by cmake macros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/ --- (Updated Oct. 7, 2013, 3:24 p.m.) Review request for Build System, KDE Fra

Re: Review Request 113148: Move and clean KBuildsycoca to KService

> On Oct. 7, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote: > > kded/kbuildsycoca.cpp, line 48 > > > > > > What happens with this? I vote for removing it, any objections ? - Àlex --

Re: Review Request 113148: Move and clean KBuildsycoca to KService

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/ --- (Updated Oct. 7, 2013, 3:21 p.m.) Review request for KDE Frameworks. Rep

Review Request 113149: Make it easier to use frameworks linked by cmake macros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113149/ --- Review request for Build System, KDE Frameworks and Sebastian Kügler. Repo

KF5 Update Meeting Minutes 2013-w40

These are the minutes of the Week 40 KF5 meeting. As usual it has been held on #kde-devel at 4pm Barcelona (CEST / UTC+2) time. Present on the meeting: vhanda, teo-, agateau, apol, steveire, d_ed, dfaure, mck1982, Sho, shadeslayer, sebas, mgrasslin and afiestas. Topics discussed: *vHanda: Moved

Build failed in Jenkins: plasma-framework_master_qt5 #789

See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace Running

Re: Review Request 113148: Move and clean KBuildsycoca to KService

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review41352 --- staging/kservice/kbuildsycoca/CMakeLists.txt

Re: Review Request 113148: Move and clean KBuildsycoca to KService

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review41351 --- kded/kbuildsycoca.cpp

Build failed in Jenkins: kdelibs_frameworks_qt5 #1366

See Changes: [mklapetek] Build KDESu only on UNIX together with KPty -- [...truncated 4556 lines...]

Review Request 113148: Move and clean KBuildsycoca to KService

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113077: Get Kross ready for tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113077/#review41350 --- You broke the build (and forgot to include the REVIEW tag ;-):

Re: Review Request 113112: Notify about palette changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41346 --- Ship it! Awesome, good to go. - Àlex Fiestas On Oct. 7, 201

Build failed in Jenkins: kdelibs_frameworks_qt5 #1365

See Changes: [me] KRoss: Camel case the library names [me] Kross: Follow frameworks directory scheme [me] Kross: Add CMake stuff along with KrossConfig.cmake [me] Kross: Install the plugins in the QT_PLULGIN_INSTALL_DIR [me] Kross

Re: Review Request 113142: Move KPty to tier 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113142/#review41342 --- This review has been submitted with commit 7d0570f639cadcbea79

Re: Review Request 113142: Move KPty to tier 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113142/ --- (Updated Oct. 7, 2013, 12:57 p.m.) Status -- This change has been mar

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113076/ --- (Updated Oct. 7, 2013, 2:47 p.m.) Review request for KDE Frameworks and Jo

Re: Review Request 113112: Notify about palette changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/ --- (Updated Oct. 7, 2013, 12:20 p.m.) Review request for KDE Frameworks, Àlex

Re: Review Request 113142: Move KPty to tier 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113142/#review41337 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 7, 2013, 11:

Re: Review Request 113097: KInit splitting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113097/#review41335 --- This review has been submitted with commit f9ded0fbc44c851c9a4

Re: Review Request 113097: KInit splitting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113097/ --- (Updated Oct. 7, 2013, 11:37 a.m.) Status -- This change has been mar

Re: Review Request 113142: Move KPty to tier 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113142/#review41334 --- tier3/CMakeLists.txt

Review Request 113142: Move KPty to tier 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113142/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: QTimeZone merged for 5.2

Hello, On Thursday 03 October 2013 18:15:22 John Layt wrote: > On 24 September 2013 19:24, Kevin Ottens wrote: > > On Tuesday 24 September 2013 19:03:21 John Layt wrote: > >> I'll do some analysis on the use of all the widgets and what ones are > >> worth keeping, and look at the Qt widgets to se

Re: Review Request 113105: Move KWallet to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/#review41332 --- This review has been submitted with commit 10307fec2e4a34c00f6

Re: Review Request 113105: Move KWallet to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/ --- (Updated Oct. 7, 2013, 10:46 a.m.) Status -- This change has been mar

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41326 --- Looks good to me. One last thing: you need to document the save

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

> On Oct. 5, 2013, 10:53 a.m., David Faure wrote: > > Good catch about the format string syntax changes between kde and qt. > > > > But why not just add "t" to the format string to include the timezone, as > > it used to do with %Z, instead of the removeTimeZone() function? > > As far as I can