Re: Review Request 113088: Prepare kpty for moving

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41193 --- kpty/CMakeLists.txt

Review Request 113088: Prepare kpty for moving

2013-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113087: Start preparing KHTML for moving

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113087/#review41192 --- khtml/KHTMLConfig.cmake.in

Review Request 113087: Start preparing KHTML for moving

2013-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113087/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41190 --- People porting code won't find the new header name. This needs

Re: Review Request 113077: Get Kross ready for tier3

2013-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113077/#review41189 --- Ship it! Looks sensible kross/core/CMakeLists.txt

Review Request 113086: KDeclarative cleanup

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/ --- Review request for KDE Frameworks and Plasma. Repository: kdelibs Descri

Re: Review Request 112828: Add a new functions to add unit tests

2013-10-03 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/ --- (Updated Oct. 3, 2013, 6:04 p.m.) Status -- This change has been mark

Re: Review Request 112828: Add a new functions to add unit tests

2013-10-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review41187 --- This review has been submitted with commit 32310315ad2826e3037

Re: Review Request 112942: Move KDNSSD to tier2

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Oct. 3, 2013, 4:25 p.m.) Status -- This change has been mark

Review Request 113077: Get Kross ready for tier3

2013-10-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113077/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 112942: Move KDNSSD to tier2

2013-10-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41186 --- This review has been submitted with commit f719fe660d9be12a201

Re: QTimeZone merged for 5.2

2013-10-03 Thread John Layt
On 24 September 2013 19:24, Kevin Ottens wrote: > On Tuesday 24 September 2013 19:03:21 John Layt wrote: >> I'll do some analysis on the use of all the widgets and what ones are >> worth keeping, and look at the Qt widgets to see if they're worth >> switching to, if not before then at Qt Dev Days

Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113076/ --- Review request for KDE Frameworks and John Layt. Repository: kdelibs Des

Re: Review Request 112928: Template files for frameworks

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Oct. 3, 2013, 2:31 p.m.) Status -- This change has been mark

Re: Review Request 112928: Template files for frameworks

2013-10-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review41182 --- This review has been submitted with commit 938df2a97fe65f7f116

Re: Review Request 112928: Template files for frameworks

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review41181 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 27, 2013, 3

Re: Review Request 112942: Move KDNSSD to tier2

2013-10-03 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41180 --- Ship it! Looks good. - Àlex Fiestas On Oct. 2, 2013, 4:05 p

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/ --- (Updated Oct. 3, 2013, 1:53 p.m.) Status -- This change has been disc

Re: Review Request 112828: Add a new functions to add unit tests

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review41179 --- Ship it! Looks good to me - Aleix Pol Gonzalez On Oct. 2, 2

Re: Review Request 113043: Codestyle changes for kdesu

2013-10-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113043/ --- (Updated Oct. 3, 2013, 12:05 p.m.) Status -- This change has been mar

Re: Review Request 113043: Codestyle changes for kdesu

2013-10-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113043/#review41173 --- This review has been submitted with commit 9c89befc359467a480e

Re: Review Request 113043: Codestyle changes for kdesu

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113043/#review41171 --- Ship it! Ship It! - Aurélien Gâteau On Oct. 3, 2013, 1:21 p

Re: Review Request 113073: Make KColorSpaces really private

2013-10-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113073/#review41169 --- This review has been submitted with commit 12fff0dce46ba1a7b80

Re: Review Request 113073: Make KColorSpaces really private

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113073/ --- (Updated Oct. 3, 2013, 11:44 a.m.) Status -- This change has been mar

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41164 --- staging/kemoticons/src/core/kemoticonsprovider.h

Re: Review Request 113043: Codestyle changes for kdesu

2013-10-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113043/ --- (Updated Oct. 3, 2013, 11:21 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113073: Make KColorSpaces really private

2013-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113073/#review41165 --- Ship it! - David Edmundson On Oct. 3, 2013, 9:32 a.m., Aurél

Re: Review Request 113043: Codestyle changes for kdesu

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113043/#review41162 --- staging/kdesu/src/client.h

Review Request 113073: Make KColorSpaces really private

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113073/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113043: Codestyle changes for kdesu

2013-10-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113043/ --- (Updated Oct. 3, 2013, 9:20 a.m.) Review request for KDE Frameworks. Cha

Build failed in Jenkins: kdelibs_frameworks_qt5 #1327

2013-10-03 Thread KDE CI System
See Changes: [mklapetek] Move Qt includes before Q_OS_UNIX macro -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Re: Switch build.kde.org to Qt stable branch

2013-10-03 Thread Ben Cooksley
Hi all, I have now made the change - until a new Qt 5 build completes, all projects which depend on Qt 5 will fail to build from source however. Regards, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Switch build.kde.org to Qt stable branch

2013-10-03 Thread David Faure
On Wednesday 02 October 2013 14:53:36 Nicolás Alvarez wrote: > As you may know, Qt is working to release 5.2. The dev branch has been > merged to the stable branch, which means the stable branch is now 5.2, > and dev is now 5.3. > > build.kde.org is compiling Qt from source, but it's using the dev

Build failed in Jenkins: kdelibs_frameworks_qt5 #1326

2013-10-03 Thread KDE CI System
See Changes: [mklapetek] Clean up KDESu #includes -- [...truncated 16990 lines...] [ 62%] [ 62%] Building CXX object staging/kservice/autotests/CMakeFiles/ksycocathreadtest.dir/kwaitforsignal.

Re: Review Request 113039: Remove unused includes from KDESu

2013-10-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/#review41154 --- This review has been submitted with commit 96619ef20d8cb0a796d

Re: Review Request 113039: Remove unused includes from KDESu

2013-10-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/ --- (Updated Oct. 3, 2013, 8:27 a.m.) Status -- This change has been mark