Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112923/ --- Review request for KDE Frameworks. Description --- Make leftMargin ri

Re: Making KDocTools independent of KArchive

El Dimarts, 24 de setembre de 2013, a les 14:09:57, Kevin Ottens va escriure: > On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: > > El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va > > escriure: > > > On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: > >

Re: Review Request 112921: Adjust CMakeLists.txt files in KEmoticons (prior to splitting)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112921/#review40728 --- Ship it! staging/kemoticons/src/providers/xmpp/CMakeLists.txt

Review Request 112921: Adjust CMakeLists.txt files in KEmoticons (prior to splitting)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112921/ --- Review request for KDE Frameworks. Description --- Adjust CMakeLists.

Re: Review Request 112907: Move KEmoticons framework to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- (Updated Sept. 24, 2013, 8:44 p.m.) Status -- This change has been di

Re: Frameworks Overview

On Tuesday 24 September 2013, Ben Cooksley wrote: > On Sep 24, 2013 7:33 AM, "Alexander Neundorf" wrote: > > On Monday 23 September 2013, Sebastian Kügler wrote: > > > Hey, > > > > > > On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote: > > > > On Thursday 19 September 2013 Sebasti

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 24, 2013, 6:08 p.m.) Review request for KDE Frameworks, Fra

Re: Templates for frameworks CMake files

On Tuesday 24 September 2013, Stephen Kelly wrote: > Aurélien Gâteau wrote: > > Hi, > > > > I have been playing around with itemviews CMake files and put together > > some templates for the top level CMakeLists.txt and *Config.cmake.in. You > > can find them attached there. Any one against me addi

Re: QTimeZone merged for 5.2

On Tuesday 24 September 2013 19:03:21 John Layt wrote: > I'll do some analysis on the use of all the widgets and what ones are > worth keeping, and look at the Qt widgets to see if they're worth > switching to, if not before then at Qt Dev Days / Qt Contributors Day. OK, I'll ignore this part of K

Review Request 112919: Prepare KParts for the move

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112919/ --- Review request for KDE Frameworks. Description --- Moved all sources

Re: QTimeZone merged for 5.2

On 24 September 2013 12:11, Kevin Ottens wrote: >> OK, let's attempt to move KLocale, KDateTime and friends to kde4support now. >> With some luck we'll be able to completely get rid of KDE4Attic before >> release. > > Hmm, looking at that closer... indeed it looks like we can get rid of > K*TimeZo

Re: Review Request 112880: Added KColorSchemeToken class.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 24, 2013, 4:08 p.m.) Review request for KDE Frameworks and

Re: [kde-promo] Terminology for Frameworks

On Tuesday, September 24, 2013 10:09 (UTC) Jos Poortvliet wrote: > Going through the article explaining Frameworks to the world* > yesterday, I bumped into quite some inconsistent use of terms. > > Right now, we mix up: > modules > components > frameworks > addons > libraries This article was dev

Terminology for Frameworks

Going through the article explaining Frameworks to the world* yesterday, I bumped into quite some inconsistent use of terms. Right now, we mix up: modules components frameworks addons libraries For example in the article, we mostly talked 'modules' intermingled with 'libraries', then suddenly sta

Re: Making KDocTools independent of KArchive

> Maybe we can bundle the generated documentation? Distributions in general don't want pregenerated . /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

> On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename i

Re: Making KDocTools independent of KArchive

On Tuesday 24 September 2013 15:05:56 Aleix Pol wrote: > On Tue, Sep 24, 2013 at 2:09 PM, Kevin Ottens wrote: > > On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: > > > Are you sure that's an improvement? > > > > Well, as highlighted we have a dependency issue there, so it's either:

KF5 Update Meeting Minutes 2013-w39

Hello everyone, This is the minutes of the Week 39 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, d_ed, dfaure, mck182, mgraesslin, sebas, shadeslayer, teo, vHanda, wojtask9 and myself. Announcement: * I will be away next week, a

Re: Frameworks Overview

On Monday, September 23, 2013 15:08:57 Jos Poortvliet wrote: > On Mon, Sep 23, 2013 at 11:43 AM, Sebastian Kügler wrote: > > Technically, this is the current focus. We're splitting kdelibs. > > > > As to communication, it probably needs a bit of boilerplate. (Which the > > bits I wrote don't cont

Re: Templates for frameworks CMake files

Aurélien Gâteau wrote: > Hi, > > I have been playing around with itemviews CMake files and put together > some templates for the top level CMakeLists.txt and *Config.cmake.in. You > can find them attached there. Any one against me adding those to the > repository? > > Aurélien > CMakeLists.txt >

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

> On Sept. 24, 2013, 2:23 p.m., Sune Vuorela wrote: > > tier1/kguiaddons/src/lib/colors/kcolorutils.cpp, line 42 > > > > > > My initial reaction is that it could return a bool wether or not things > > went okay, g

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/ --- (Updated Sept. 24, 2013, 2:33 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

> On Sept. 24, 2013, 4:23 p.m., Sune Vuorela wrote: > > tier1/kguiaddons/src/lib/colors/kcolorutils.cpp, line 42 > > > > > > My initial reaction is that it could return a bool wether or not things > > went okay, g

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40694 --- Probably we'll need an extra patch on top of this one so that K

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/ --- (Updated Sept. 24, 2013, 2:25 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40692 --- tier1/kguiaddons/src/lib/colors/kcolorutils.cpp

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/ --- (Updated Sept. 24, 2013, 2:19 p.m.) Review request for KDE Frameworks and

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/ --- (Updated Sept. 24, 2013, 2:03 p.m.) Status -- This change has been ma

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/#review40691 --- This review has been submitted with commit ae788001f3f1ed03c9d

Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/ --- Review request for KDE Frameworks. Description --- Add index argument

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

> On Sept. 24, 2013, 1:27 p.m., John Layt wrote: > > Agree to merge this as is, it removes the stuff that would be duplicated in > > the Qt dialog. As for longer-term, I don't see any of those features being > > much used or of much use at all. If I'm wrong and people start complaining > > a

Jenkins build became unstable: kdelibs_frameworks_qt5 #1257

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112915: Fix kcrash standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112915/ --- (Updated Sept. 24, 2013, 3:39 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112915: Fix kcrash standalone build

> On Sept. 24, 2013, 3:32 p.m., David Edmundson wrote: > > superbuild/CMakeLists.txt, line 46 > > > > > > why have you removed kconfigwidgets? Because it does not build with superbuild right now. The original inte

Re: Review Request 112829: Move XMLGUI to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/#review40684 --- There's a KDE5 TODO in kmainwindow.h to remove the window flags

Re: Review Request 112901: Remove weird cmake indirections

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112901/ --- (Updated Sept. 24, 2013, 1:32 p.m.) Review request for Build System and KD

Re: Review Request 112915: Fix kcrash standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112915/#review40683 --- superbuild/CMakeLists.txt

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/#review40681 --- Ship it! Agree to merge this as is, it removes the stuff that

Re: Review Request 112830: Start splitting KParts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/#review40680 --- This review has been submitted with commit 270a19b6bf9157361ca

Re: Review Request 112830: Start splitting KParts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/ --- (Updated Sept. 24, 2013, 1:23 p.m.) Status -- This change has been ma

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/ --- (Updated Sept. 24, 2013, 1:10 p.m.) Status -- This change has been ma

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/#review40679 --- This review has been submitted with commit 2e43321d82a578176da

Re: Making KDocTools independent of KArchive

On Tue, Sep 24, 2013 at 2:09 PM, Kevin Ottens wrote: > On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: > > El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va > escriure: > > > On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: > > > > Maybe we can use a th

Re: Re: kde-workspace master becomes Qt5-based

On Tuesday 24 September 2013 13:51:57 Albert Astals Cid wrote: > El Dimarts, 24 de setembre de 2013, a les 11:34:45, Martin Gräßlin va > > escriure: > > On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: > > > Hi all, > > > > > > We're planning to merge the frameworks-scratch branch o

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112882/ --- (Updated Sept. 24, 2013, 12:22 p.m.) Status -- This change has been m

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

> On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote: > > staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3 > > > > > > I surely has other dependencies. > > Aleix Pol Gonzalez wrote: > Most things in stagin

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112882/#review40671 --- This review has been submitted with commit c90e676fe270bb63d6d

Review Request 112915: Fix kcrash standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112915/ --- Review request for KDE Frameworks. Description --- - find kcrash deps

Re: Making KDocTools independent of KArchive

On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: > El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va escriure: > > On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: > > > Maybe we can use a third-party docbook-to-manpage conversion tool. On > > > Linux > >

Re: kde-workspace master becomes Qt5-based

El Dimarts, 24 de setembre de 2013, a les 11:34:45, Martin Gräßlin va escriure: > On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: > > Hi all, > > > > We're planning to merge the frameworks-scratch branch of kde-workspace > > into > > master next Monday. That means if you're buildin

Re: Making KDocTools independent of KArchive

El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va escriure: > On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: > > Maybe we can use a third-party docbook-to-manpage conversion tool. On > > Linux > > it would be easy to install, and on Windows it wouldn't be needed ("wha

Re: Review Request 112901: Remove weird cmake indirections

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112901/ --- (Updated Sept. 24, 2013, 11:36 a.m.) Review request for Build System and K

Re: Review Request 112902: Start cleanup for kdewebkit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/ --- (Updated Sept. 24, 2013, 11:19 a.m.) Review request for KDE Frameworks.

Re: Review Request 112902: Start cleanup for kdewebkit

> On Sept. 24, 2013, 6:58 a.m., Kevin Ottens wrote: > > staging/kio/src/widgets/renamedialog.h, line 25 > > > > > > How is it related to the rest of the patch? KSqueezedTextLabel is in KWidgetsAddons which is not

Re: Review Request 112900: Prepare KDNSSD for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/ --- (Updated Sept. 24, 2013, 11:14 a.m.) Review request for KDE Frameworks.

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1250

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: QTimeZone merged for 5.2

On Monday 23 September 2013 09:33:54 Kevin Ottens wrote: > On Monday 23 September 2013 09:06:33 John Layt wrote: > > Hi, > > > > I am extremely relived to announce that QTimeZone finally got merged > > late late last night, thanks to the efforts of Thiago in fighting the > > CI system :-) Combine

Jenkins build became unstable: kdelibs_frameworks_qt5 #1249

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1248

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/#review40662 --- Ship it! Ship It! - Kevin Ottens On Sept. 23, 2013, 6:47 p.

Re: kde-workspace master becomes Qt5-based

On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: > Hi all, > > We're planning to merge the frameworks-scratch branch of kde-workspace into > master next Monday. That means if you're building your Plasma yourself from > Git (and you're not yet ready for Plasma2 ;)), you should switch

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

> On Sept. 24, 2013, 7:10 a.m., Kevin Ottens wrote: > > I'm torn on that one... If we're sure the remaining features aren't useful, > > I would propose to just move all the printing stuff from KDE4Attic to > > KDE4Support. If we're not sure, then we should move the printing stuff from > > KDE4

Review Request 112913: Move KModifierKeyInfo from GuiAddons to KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112913/ --- Review request for KDE Frameworks. Description --- As discussed in ht

Build failed in Jenkins: kdelibs_frameworks_qt5 #1246

See Changes: [mklapetek] Use QStringLiteral rather than QLatin1String [steveire] Define isnan() for MSVC [steveire] Don't use QStringLiteral as a default value initializer. [steveire] Use the correct moc include on Windows. [steve

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

> On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 112907: Move KEmoticons framework to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40650 --- staging/kemoticons/src/providers/adium/CMakeLists.txt

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

> On Sept. 23, 2013, 10:49 a.m., Kevin Ottens wrote: > > modules/ECMAddUnitTest.cmake, line 23 > > > > > > I agree, it's about "automated" (vs "manual") tests here. We've no way > > when writing this macro to know

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/#review40648 --- I'm torn on that one... If we're sure the remaining features ar

Re: Review Request 112907: Move KEmoticons framework to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40646 --- Please split this into multiple patches. The move should be the

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

> On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. > > Jeremy Whiting wrote: > well, qt5_wrap_ui wasn't around when this was created (as > kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 112900: Prepare KDNSSD for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/#review40644 --- Yes, looks like a tier 2 in that case. I wonder if that KConfig