Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40642 --- staging/kde4support/CMakeLists.txt

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40635 --- I'm not sure we can let that in for kdelibs 4.x / kdeui... Davi

Re: Making KDocTools independent of KArchive

2013-09-23 Thread Kevin Ottens
On Monday 23 September 2013 13:09:05 Nicolás Alvarez wrote: > Maybe we can use a third-party docbook-to-manpage conversion tool. On Linux > it would be easy to install, and on Windows it wouldn't be needed ("what's > a manpage?"). And still leave it optional everywhere... Thats a very good questio

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40632 --- Probably needs some porting notes in KDE5PORTING to point to QC

Re: Review Request 112830: Start splitting KParts

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/#review40629 --- Ship it! Ship It! - Kevin Ottens On Sept. 23, 2013, noon, A

Re: Making KDocTools independent of KArchive

2013-09-23 Thread Nicolás Alvarez
On Monday, September 23, 2013, Kevin Ottens wrote: > On Saturday 21 September 2013 15:25:27 Albert Astals Cid wrote: > > El Dissabte, 21 de setembre de 2013, a les 11:15:52, Stephen Kelly va > > > > escriure: > > > Albert Astals Cid wrote: > > > >> > Anyway as I was chatting with Aleix yesterda

Re: Making KDocTools independent of KArchive

2013-09-23 Thread Nicolás Alvarez
On Monday, September 23, 2013, Nicolás Alvarez wrote: > On Monday, September 23, 2013, Kevin Ottens wrote: > >> On Saturday 21 September 2013 15:25:27 Albert Astals Cid wrote: >> > El Dissabte, 21 de setembre de 2013, a les 11:15:52, Stephen Kelly va >> > >> > escriure: >> > > Albert Astals Cid wr

Re: Frameworks Overview

2013-09-23 Thread Jos Poortvliet
On Mon, Sep 23, 2013 at 11:43 AM, Sebastian Kügler wrote: > > Technically, this is the current focus. We're splitting kdelibs. > > As to communication, it probably needs a bit of boilerplate. (Which the bits I > wrote don't contain purposefully.) Otherwise, you're right, we need to work on > the p

Re: Frameworks Overview

2013-09-23 Thread Cornelius Schumacher
On Monday 23 September 2013 11:43:58 Sebastian Kügler wrote: > On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote: > > On Thursday 19 September 2013 Sebastian Kügler wrote: > > > http://community.kde.org/Frameworks/Overview > > > > I have put the data on Inqlude (see http://inqlude.

Re: Frameworks Overview

2013-09-23 Thread Ben Cooksley
On Sep 24, 2013 7:33 AM, "Alexander Neundorf" wrote: > > On Monday 23 September 2013, Sebastian Kügler wrote: > > Hey, > > > > On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote: > > > On Thursday 19 September 2013 Sebastian Kügler wrote: > > > > http://community.kde.org/Frameworks/

Re: potential duplicate repositories for kwallet

2013-09-23 Thread Valentin Rusu
On 09/22/2013 09:43 AM, Treeve Jelbert wrote: > There is a kwallet repo as a result of splitting kdeutils. > > On my system,this installs: > > /opt/qt4/bin/kwalletmanager > /opt/qt4/lib/kde4/kcm_kwallet.so These are from utils/kwallet, which is the "KDE Wallet Manager" tool. This is not the KWal

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-23 Thread Jeremy Whiting
> On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote: > > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least > > partly. well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files iirc). All I did was copy it and rename it. didn't look into making it use

Re: Review Request 112900: Prepare KDNSSD for moving

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/ --- (Updated Sept. 23, 2013, 5:29 p.m.) Review request for KDE Frameworks. C

Review Request 112902: Start cleanup for kdewebkit

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/ --- Review request for KDE Frameworks. Description --- Start to figure ou

Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- Review request for KDE Frameworks. Description --- Move KEmoticons fr

Re: Frameworks Overview

2013-09-23 Thread Alexander Neundorf
On Monday 23 September 2013, Sebastian Kügler wrote: > Hey, > > On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote: > > On Thursday 19 September 2013 Sebastian Kügler wrote: > > > http://community.kde.org/Frameworks/Overview > > > > I have put the data on Inqlude (see http://inqlud

Re: Review Request 112901: Remove weird cmake indirections

2013-09-23 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112901/#review40612 --- This flag can be removed completely (instead of being replaced

Re: Review Request 112730: Make knewstuff build standalone

2013-09-23 Thread Jeremy Whiting
> On Sept. 17, 2013, 1:30 a.m., David Faure wrote: > > knewstuff/CMakeLists.txt, line 9 > > > > > > Does this really build when building all of kdelibs in one go? I > > thought we determined that find_package of kf

Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- Review request for KDE Frameworks. Changes --- Use --find-copies-hard

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

2013-09-23 Thread Alexander Neundorf
> On Sept. 23, 2013, 10:49 a.m., Kevin Ottens wrote: > > modules/ECMAddUnitTest.cmake, line 23 > > > > > > I agree, it's about "automated" (vs "manual") tests here. We've no way > > when writing this macro to know

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread David Gil Oliva
> On Sept. 23, 2013, 6:22 p.m., Aleix Pol Gonzalez wrote: > > Can you provide a patch with --find-copies-harder? > > > > It makes it much easier to read such patches where there are moves and > > changes. > > > > Also, why did you change from Qt5::Xml to Qt5Xml? > Also, why did you change fro

Review Request 112909: Remove KDE print stuff that has been ported to Qt5

2013-09-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/ --- Review request for KDE Frameworks and John Layt. Description --- Most

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aurélien Gâteau
> On Sept. 23, 2013, 5:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Making KDocTools independent of KArchive

2013-09-23 Thread Albert Astals Cid
El Dilluns, 23 de setembre de 2013, a les 08:45:29, Kevin Ottens va escriure: > On Saturday 21 September 2013 15:25:27 Albert Astals Cid wrote: > > El Dissabte, 21 de setembre de 2013, a les 11:15:52, Stephen Kelly va > > > > escriure: > > > Albert Astals Cid wrote: > > > >> No. I'm saying it can

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40599 --- Can you provide a patch with --find-copies-harder? It makes it

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40598 --- Can you provide a patch with --find-copies-harder? It makes it

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aleix Pol Gonzalez
> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112598/ --- (Updated Sept. 23, 2013, 3:51 p.m.) Status -- This change has been ma

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- (Updated Sept. 23, 2013, 5:41 p.m.) Review request for KDE Frameworks. D

Review Request 112901: Remove weird cmake indirections

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112901/ --- Review request for Build System and KDE Frameworks. Description --- T

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aleix Pol Gonzalez
> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Review Request 112900: Prepare KDNSSD for moving

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/ --- Review request for KDE Frameworks. Description --- Prepares the modul

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aleix Pol Gonzalez
> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Qt Dev Days Stuff

2013-09-23 Thread John Layt
On 19 September 2013 15:34, John Layt wrote: > Qt Dev Days is short on Lightning Talks, so if you have a Qt-related > topic you want to present or demo for up to 10 minutes, please submit > it at http://www.qtdeveloperdays.com/lightning-talks by tomorrow. I've submitted a talk called "KDE and Qt

Re: Review Request 112897: Move itemviews to tier1

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112897/#review40587 --- This review has been submitted with commit b44217f33203c6632ed

Re: Review Request 112897: Move itemviews to tier1

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112897/ --- (Updated Sept. 23, 2013, 4:17 p.m.) Status -- This change has been ma

Re: Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112598/#review40582 --- This review has been submitted with commit 3690c92db64315b3e01

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aurélien Gâteau
> On Sept. 23, 2013, 5:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Review Request 112897: Move itemviews to tier1

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112897/#review40576 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 23, 2013, 2

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-23 Thread Kevin Ottens
> On Sept. 23, 2013, 10:27 a.m., Kevin Ottens wrote: > > Not that I'm really qualified with xcb code, but it looks ok to me. > > Martin Gräßlin wrote: > no, no. The issues mentioned by Fredrik should be fixed. > > Fredrik Höglund wrote: > Kevin, please don't take this the wrong way, but

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/#review40574 --- It does not build standalone for me, linking fails: http://pas

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 2:43 p.m.) Review request for KDE Frameworks and

Review Request 112897: Move itemviews to tier1

2013-09-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112897/ --- Review request for KDE Frameworks. Description --- Move itemviews to

Re: Review Request 112792: Move itemviews to tier2

2013-09-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112792/ --- (Updated Sept. 23, 2013, 4:09 p.m.) Status -- This change has been di

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 23, 2013, 1:45 p.m.) Review request for KDE Frameworks, Fra

Re: Review Request 112757: kwindowsystem - remove unused dependencies

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112757/ --- (Updated Sept. 23, 2013, 1:39 p.m.) Status -- This change has been ma

Re: Review Request 112757: kwindowsystem - remove unused dependencies

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112757/#review40566 --- This review has been submitted with commit 18d78a720672cc67a50

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-23 Thread Fredrik Höglund
> On Sept. 23, 2013, 10:27 a.m., Kevin Ottens wrote: > > Not that I'm really qualified with xcb code, but it looks ok to me. > > Martin Gräßlin wrote: > no, no. The issues mentioned by Fredrik should be fixed. Kevin, please don't take this the wrong way, but it would be enormously helpful

Re: Review Request 112814: kjs - remove unused dependencies

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112814/#review40564 --- This review has been submitted with commit 4f074a30444dab33921

Re: Review Request 112814: kjs - remove unused dependencies

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112814/ --- (Updated Sept. 23, 2013, 1:28 p.m.) Status -- This change has been ma

Review Request 112896: Rework NETWM classes

2013-09-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- Review request for KDE Frameworks. Description --- This is a patch se

Re: Review Request 112811: Make kguiaddons build standalone

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112811/#review40563 --- This review has been submitted with commit 427e3d31863dcca9af5

Re: Review Request 112811: Make kguiaddons build standalone

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112811/ --- (Updated Sept. 23, 2013, 1:11 p.m.) Status -- This change has been ma

Re: Review Request 112830: Start splitting KParts

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/ --- (Updated Sept. 23, 2013, noon) Review request for KDE Frameworks. Change

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

2013-09-23 Thread Kevin Ottens
> On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote: > > staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3 > > > > > > I surely has other dependencies. > > Aleix Pol Gonzalez wrote: > Most things in stagin

Build failed in Jenkins: kdelibs_frameworks_qt5 #1239

2013-09-23 Thread KDE CI System
See Changes: [aleixpol] DNSSD: Adopt modules directory structure -- [...truncated 21142 lines...] -- Installing:

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

2013-09-23 Thread Aleix Pol Gonzalez
> On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote: > > staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3 > > > > > > I surely has other dependencies. Most things in staging have faulty *Config.cmake.in files

KF5 Update Meeting 2013-w39 Reminder

2013-09-23 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc

Re: Review Request 112825: DNSSD: Adopt modules directory structure

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112825/ --- (Updated Sept. 23, 2013, 11:22 a.m.) Status -- This change has been m

Re: Review Request 112825: DNSSD: Adopt modules directory structure

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112825/#review40536 --- This review has been submitted with commit 36ac309db4459f5bde7

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-23 Thread Kevin Ottens
> On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: > > Tested the patch in my tree, works for caps lock too. > > > > Now it highlights a dependency problem... We don't want a dependency on > > QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to > > your proposed KX11Extra

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112882/#review40532 --- staging/kcmutils/CMakeLists.txt

Re: Review Request 112825: DNSSD: Adopt modules directory structure

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112825/#review40531 --- dnssd/src/CMakeLists.txt

Re: Review Request 112838: KIconThemes move to tier3

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112838/#review40530 --- Ship it! Ship It! - Kevin Ottens On Sept. 20, 2013, 1:27 p.

Re: Review Request 112830: Start splitting KParts

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/#review40526 --- khtml/java/CMakeLists.txt

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-23 Thread Martin Gräßlin
> On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: > > Tested the patch in my tree, works for caps lock too. > > > > Now it highlights a dependency problem... We don't want a dependency on > > QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to > > your proposed KX11Extra

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review40523 --- modules/ECMAddUnitTest.cmake

Re: Review Request 112829: Move XMLGUI to Tier3

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/#review40522 --- Ship it! Looks good. - Kevin Ottens On Sept. 19, 2013, 4:44

Re: Review Request 112814: kjs - remove unused dependencies

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112814/#review40521 --- Ship it! Ship It! - Kevin Ottens On Sept. 19, 2013, 12:35 p

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40520 --- Hmmm, why not bring it back in kde4support? We're talking about

Re: Review Request 112811: Make kguiaddons build standalone

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112811/#review40519 --- Ship it! Ship It! - Kevin Ottens On Sept. 19, 2013, 11:28 a

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/#review40518 --- I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-23 Thread Martin Gräßlin
> On Sept. 23, 2013, 12:27 p.m., Kevin Ottens wrote: > > Not that I'm really qualified with xcb code, but it looks ok to me. no, no. The issues mentioned by Fredrik should be fixed. - Martin --- This is an automatically generated e-mail

Re: Review Request 112792: Move itemviews to tier2

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112792/#review40516 --- Please update aiming at tier 1 since it's apparently possible n

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review40515 --- Ship it! Not that I'm really qualified with xcb code, but it l

Re: Review Request 112757: kwindowsystem - remove unused dependencies

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112757/#review40513 --- Ship it! Ship It! - Kevin Ottens On Sept. 16, 2013, 2:15 p.

Re: Review Request 111938: Allow installing both qca2 and qca3

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/ --- (Updated Sept. 23, 2013, 10:24 a.m.) Status -- This change has been m

Re: Review Request 112598: Fix regression in KSharedConfig::openConfig for empty file name and SimpleConfig

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112598/#review40512 --- Ship it! Ship It! - Kevin Ottens On Sept. 9, 2013, 6:51 a.m

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/#review40511 --- Ship it! Looks good. Any reason why it's not pushed yet? (got

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- Tested the patch in my tree, works for caps lock too. Now it h

Jenkins build is back to normal : plasma-framework_master_qt5 #764

2013-09-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112840: Port from kde4_add_plugin to add_library

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112840/ --- (Updated Sept. 23, 2013, 9:56 a.m.) Status -- This change has been ma

Re: Review Request 112840: Port from kde4_add_plugin to add_library

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112840/#review40509 --- This review has been submitted with commit 90d8df909ab42b6caeb

Re: Frameworks Overview

2013-09-23 Thread Sebastian Kügler
Hey, On Monday, September 23, 2013 00:27:21 Cornelius Schumacher wrote: > On Thursday 19 September 2013 Sebastian Kügler wrote: > > > > > > http://community.kde.org/Frameworks/Overview > > I have put the data on Inqlude (see http://inqlude.org/edge.html). Thanks. One issue though, we're duplica

Re: Review Request 112367: Include the icon's theme in the cache key

2013-09-23 Thread Kevin Ottens
> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/#review40505 --- Any reason why this patch isn't committed yet? Please do so ASA

Re: Review Request 105863: Don't lose the original CMAKE_MODULE_PATH

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105863/ --- (Updated Sept. 23, 2013, 9:12 a.m.) Status -- This change has been di

Re: Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112032/#review40503 --- Any news about that patch? Hasn't seen activity in a while, it

Re: Review Request 107696: kcalendarsystem: Simplify weekday naming a lot.

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107696/ --- (Updated Sept. 23, 2013, 8:31 a.m.) Status -- This change has been di

Re: Review Request 109551: port KPtyProcess to QProcess

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- (Updated Sept. 23, 2013, 8:31 a.m.) Status -- This change has been di

Re: Frameworks Overview

2013-09-23 Thread Cornelius Schumacher
On Thursday 19 September 2013 Sebastian Kügler wrote: > > http://community.kde.org/Frameworks/Overview I have put the data on Inqlude (see http://inqlude.org/edge.html). It would be nice, if we could improve the presentation of the different libraries along with the code. The goal of Inqlude is

Re: QTimeZone merged for 5.2

2013-09-23 Thread Kevin Ottens
On Monday 23 September 2013 09:06:33 John Layt wrote: > Hi, > > I am extremely relived to announce that QTimeZone finally got merged > late late last night, thanks to the efforts of Thiago in fighting the > CI system :-) Combined with other changes in QDateTime, this should > mean we're free of K

QTimeZone merged for 5.2

2013-09-23 Thread John Layt
Hi, I am extremely relived to announce that QTimeZone finally got merged late late last night, thanks to the efforts of Thiago in fighting the CI system :-) Combined with other changes in QDateTime, this should mean we're free of KDateTime and KTimeZone, albeit with a few caveats. I'll be doing