Re: kde4_add_plugin on KF5

On Thu, Sep 19, 2013 at 7:39 PM, Alexander Neundorf wrote: > On Thursday 19 September 2013, Alex Merry wrote: > > On 19/09/13 17:00, Aleix Pol wrote: > > > Hi, > > > We should decide what we do with the add_plugin macro. Should I install > > > it as kf5_add_plugin from KCoreAddons? Do we want some

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/ --- (Updated Sept. 19, 2013, 8:37 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review40365 --- If it is good enough to be used in all frameworks in tier1/, an

Build failed in Jenkins: plasma-framework_master_qt5 #759

See Changes: [notmart] manage args also for pasted text without urls -- [...truncated 26 lines...] attica - Branch master libstreamanalyzer - Branch master kdelibs - Branch f

Review Request 112830: Start splitting KParts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112830/ --- Review request for KDE Frameworks. Description --- Started reorganizi

Re: kde4_add_plugin on KF5

On Thursday 19 September 2013, Alex Merry wrote: > On 19/09/13 17:00, Aleix Pol wrote: > > Hi, > > We should decide what we do with the add_plugin macro. Should I install > > it as kf5_add_plugin from KCoreAddons? Do we want something different or > > better? > > Would e-c-m be the right place for

kde-workspace master becomes Qt5-based

Hi all, We're planning to merge the frameworks-scratch branch of kde-workspace into master next Monday. That means if you're building your Plasma yourself from Git (and you're not yet ready for Plasma2 ;)), you should switch to the KDE/4.11 branch. The build will fail otherwise, so you will not

Build failed in Jenkins: plasma-framework_master_qt5 #758

See Changes: [notmart] new install targe [notmart] argsrc for config that can be passed as parameter -- [...truncated 27 lines...] strigidaemon - Branch master libstreamanalyzer

Re: kde4_add_plugin on KF5

On Thursday, September 19, 2013 18:26:54 Aleix Pol wrote: > Well, I thought of something like that, but I checked and there are projects > using the different arguments that kde4_add_plugin has. I don't see the > point of oversimplifying there. I didn't mean oversimplifying, but: - to provide ins

Re: kde4_add_plugin on KF5

On Thursday, September 19, 2013 18:00:41 Aleix Pol wrote: > Hi, > We should decide what we do with the add_plugin macro. Should I install it > as kf5_add_plugin from KCoreAddons? Do we want something different or > better? This is what we're using in Plasma (PlasmaMacros.cmake): # plasma_add_plug

Review Request 112829: Move XMLGUI to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/ --- Review request for KDE Frameworks. Description --- Move xmlgui to tie

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40361 --- Ship it! Patch does not apply there (complains about kpixmap-a

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review40360 --- It should be called autotests instead of unittests. It's the no

kde4_add_plugin on KF5

Hi, We should decide what we do with the add_plugin macro. Should I install it as kf5_add_plugin from KCoreAddons? Do we want something different or better? Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mai

Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/ --- Review request for Extra Cmake Modules and KDE Frameworks. Description ---

Frameworks Overview

Hi, I've created a list of the individual frameworks in KF5, including description. Now I'm not an expert in all of them, they might be incomplete, or contain errors. It would be nice if a few people could have a look, and expand, fix where necessary. http://community.kde.org/Frameworks/Overv

Re: kde4_add_plugin on KF5

On 19/09/13 17:00, Aleix Pol wrote: > Hi, > We should decide what we do with the add_plugin macro. Should I install > it as kf5_add_plugin from KCoreAddons? Do we want something different or > better? Would e-c-m be the right place for it? Alex ___ Kde

Re: kde4_add_plugin on KF5

On Thu, Sep 19, 2013 at 6:15 PM, Sebastian Kügler wrote: > On Thursday, September 19, 2013 18:00:41 Aleix Pol wrote: > > Hi, > > We should decide what we do with the add_plugin macro. Should I install > it > > as kf5_add_plugin from KCoreAddons? Do we want something different or > > better? > > T

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 3:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

> On Sept. 19, 2013, 2:27 p.m., Aurélien Gâteau wrote: > > tier1/kwidgetsaddons/tests/CMakeLists.txt, line 6 > > > > > > In KDE4 days programs marked as test had a KDESRCDIR define set which > > pointed to CMAKE_C

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

> On Sept. 19, 2013, 2:27 p.m., Aurélien Gâteau wrote: > > tier1/kwidgetsaddons/tests/CMakeLists.txt, line 6 > > > > > > In KDE4 days programs marked as test had a KDESRCDIR define set which > > pointed to CMAKE_C

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 3:25 p.m.) Review request for KDE Frameworks and

Review Request 112825: Adopt modules directory structure

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112825/ --- Review request for KDE Frameworks. Description --- Moves all code to

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40350 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol G

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40351 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol G

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40352 --- Looks good overall, but I found a few minor issues. staging/k

Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- Review request for KDE Frameworks and Aurélien Gâteau. Description ---

Qt Dev Days Stuff

Hi, Qt Dev Days is short on Lightning Talks, so if you have a Qt-related topic you want to present or demo for up to 10 minutes, please submit it at http://www.qtdeveloperdays.com/lightning-talks by tomorrow. I'd especially like to see a KF5 lightning talk focussed on the libraries we will be rel

Re: Review Request 112803: Start cleaning up KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/#review40347 --- This review has been submitted with commit 1bf4d77ccd727a04a88

Re: Review Request 112803: Start cleaning up KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/ --- (Updated Sept. 19, 2013, 1:33 p.m.) Status -- This change has been ma

Review Request 112814: kjs - remove unused dependencies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112814/ --- Review request for KDE Frameworks. Description --- QtWidgets is not r

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40341 --- Ship it! Now that i think of it again, why shouldn't i give a

Re: Review Request 112803: Start cleaning up KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/#review40340 --- Ship it! Looks good to me. dnssd/CMakeLists.txt

Review Request 112811: Make kguiaddons build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112811/ --- Review request for KDE Frameworks and Martin Klapetek. Description ---

Re: Review Request 112803: Start cleaning up KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/ --- (Updated Sept. 19, 2013, 11:24 a.m.) Review request for KDE Frameworks.

Re: Review Request 112758: Move KCompletion to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112758/ --- (Updated Sept. 19, 2013, 11:13 a.m.) Status -- This change has been m

Re: Review Request 112758: Move KCompletion to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112758/#review40338 --- This review has been submitted with commit a8e0e51de8c5dd3bead

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

> On Sept. 17, 2013, 6:26 p.m., Alexander Neundorf wrote: > > The macro does more than the name implies, additionally to marking it as > > test it also actually adds the test. > > So I'd prefer a different name. > > > > Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE

Build failed in Jenkins: kdelibs_frameworks_qt5 #1225

See Changes: [aleixpol] Move KDocTools to tier2 -- [...truncated 4275 lines...] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/hal/halfstabhandling.cpp.o Buildi

Re: Review Request 112795: Move KDocTools to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112795/#review40336 --- This review has been submitted with commit 6ce4ed498e70c91ca68

Re: Review Request 112795: Move KDocTools to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112795/ --- (Updated Sept. 19, 2013, 10:48 a.m.) Status -- This change has been m

Re: Review Request 112795: Move KDocTools to tier2

> On Sept. 19, 2013, 7:40 a.m., David Faure wrote: > > tier2/kdoctools/CMakeLists.txt, line 44 > > > > > > I'm curious, what does that do? It's where the *Config.cmake file will go. Each module define its own CMA

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

> On Sept. 19, 2013, 7:48 a.m., David Faure wrote: > > staging/kemoticons/src/core/kemoticons.cpp, line 110 > > > > > > This test is already done internally in QFSW, remove it from here. But then, it keeps output

Re: Review Request 112681: Tests for KPluginTrader and friends

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review40331 --- This review has been submitted with commit afcaf264cb5417fea36

Re: Review Request 112681: Tests for KPluginTrader and friends

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- (Updated Sept. 19, 2013, 10:19 a.m.) Status -- This change has been m

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112796/ --- (Updated Sept. 19, 2013, 11:30 a.m.) Status -- This change has been d

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

> On Sept. 19, 2013, 9:43 a.m., David Faure wrote: > > tier1/kguiaddons/tests/CMakeLists.txt, line 28 > > > > > > But now it's kguiaddons (a tier1) that doesn't build standalone (with > > tests enabled), because i

Re: Review Request 112681: Tests for KPluginTrader and friends

> On Sept. 18, 2013, 10 p.m., David Faure wrote: > > staging/kservice/tests/pluginlocator/plugintest.cpp, line 170 > > > > > > hehe I'll leave this in for now. It's the call which parses the stuff created by cre

Re: Fwd: Print Dialog - next steps

On 18 September 2013 08:18, David Faure wrote: > On Monday 09 September 2013 14:07:31 Martin Klapetek wrote: >> 5) In KF5 the KdePrintDialog stuff can either be removed entirely, or more >> conservatively modified to no longer insert the extra KDE Cups widgets and >> modifications so they don't ap

Re: Build failed in Jenkins: kdelibs_frameworks_qt5 #1219

On Wed, Sep 18, 2013 at 5:03 PM, KDE CI System wrote: > See > > Changes: > > [aleixpol] Reorganize KDocTools cmake code > > [aleixpol] Start adopting QCollator > > -- > [...truncated 3600 lines.

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/#review40325 --- staging/kemoticons/src/core/kemoticons.cpp

Re: Review Request 112803: Start cleaning up KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/#review40324 --- dnssd/CMakeLists.txt

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112796/#review40323 --- tier1/kguiaddons/tests/CMakeLists.txt

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/#review40322 --- https://git.reviewboard.kde.org/r/112795/diff/ might provide in

Re: Review Request 112795: Move KDocTools to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112795/#review40321 --- Ship it! Did you check that it passes the "definition of done"

Re: Review Request 112758: Move KCompletion to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112758/#review40320 --- Ship it! Did you check that it passes the "definition of done"

Re: Splitting out a KX11Extras frameworks from KWindowSystems

On Monday 16 September 2013 15:07:37 Martin Graesslin wrote: > Hi, > > KWindowSystems is a framework which looks to me like a KX11Extras framework. > Most of the things inside this framework are X11 specific. Some API even > has XLib/XCB specific data types as arguments or return values (e.g. > ne