Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/#review40316 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept. 18

Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/ --- Review request for KDE Frameworks. Description --- Port away from KDi

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review40314 --- Ship it! staging/kservice/autotests/pluginlocatortest.cpp

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-18 Thread Alexander Neundorf
> On Sept. 17, 2013, 6:26 p.m., Alexander Neundorf wrote: > > The macro does more than the name implies, additionally to marking it as > > test it also actually adds the test. > > So I'd prefer a different name. > > > > Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE

Build failed in Jenkins: kdelibs_frameworks_qt5 #1222

2013-09-18 Thread KDE CI System
See -- [...truncated 3593 lines...] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/camera.cpp.o [ 25%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opti

Review Request 112803: Start cleaning up KDNSSD

2013-09-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803/ --- Review request for KDE Frameworks. Description --- Renames target to

Build failed in Jenkins: kdelibs_frameworks_qt5 #1221

2013-09-18 Thread KDE CI System
See Changes: [ivan.cukic] Using cbegin and cend when assigning to const iterators -- [...truncated 3588 lines...] [ 24%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/b

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-18 Thread Mark Gaiser
> On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote: > > Posting the same here as i just said in your other review request. (I > > didn't see this one) > > Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" > > that is taking the QCollator route. That way it's easily testab

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-18 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40289 --- Posting the same here as i just said in your other review reque

Re: Review Request 112717: Start adopting QCollator

2013-09-18 Thread Mark Gaiser
> On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote: > > How RUDE to just commit this without a addressing the concerns Frank and i > > have. That is not appreciated! > > Aleix Pol Gonzalez wrote: > Alright, maybe I didn't think this through. I'll un-deprecate and bring > back the KStringHan

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-18 Thread Aleix Pol Gonzalez
> On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote: > > Posting the same here as i just said in your other review request. (I > > didn't see this one) > > Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" > > that is taking the QCollator route. That way it's easily testab

Re: Review Request 112717: Start adopting QCollator

2013-09-18 Thread Aleix Pol Gonzalez
> On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote: > > How RUDE to just commit this without a addressing the concerns Frank and i > > have. That is not appreciated! > > Aleix Pol Gonzalez wrote: > Alright, maybe I didn't think this through. I'll un-deprecate and bring > back the KStringHan

Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. Desc

Build failed in Jenkins: plasma-framework_master_qt5 #754

2013-09-18 Thread KDE CI System
See Changes: [notmart] catch file types by extension too -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 112717: Start adopting QCollator

2013-09-18 Thread Aleix Pol Gonzalez
> On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote: > > How RUDE to just commit this without a addressing the concerns Frank and i > > have. That is not appreciated! Alright, maybe I didn't think this through. I'll un-deprecate and bring back the KStringHandler::naturalCompare code as you want.

Build failed in Jenkins: plasma-framework_master_qt5 #755

2013-09-18 Thread KDE CI System
See Changes: [notmart] platform specific resolution of imports -- [...truncated 841 lines...] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include

Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

2013-09-18 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112796/ --- Review request for KDE Frameworks. Description --- This is required f

Jenkins build is back to normal : plasma-framework_master_qt5 #756

2013-09-18 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112795: Move KDocTools to tier2

2013-09-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112795/ --- Review request for KDE Frameworks. Description --- Does the move, cha

Build failed in Jenkins: kdelibs_frameworks_qt5 #1220

2013-09-18 Thread KDE CI System
See Changes: [wojtask9.kde] KStyle trim down -- [...truncated 3595 lines...] [ 29%] [ 29%] [ 29%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakevide

Re: Review Request 112519: trim KStyle

2013-09-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review40278 --- This review has been submitted with commit 807b861a434aef32aeb

Re: Review Request 112519: trim KStyle

2013-09-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/ --- (Updated Sept. 18, 2013, 3:29 p.m.) Status -- This change has been ma

Re: Review Request 112717: Start adopting QCollator

2013-09-18 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review40277 --- How RUDE to just commit this without a addressing the concerns

Build failed in Jenkins: kdelibs_frameworks_qt5 #1219

2013-09-18 Thread KDE CI System
See Changes: [aleixpol] Reorganize KDocTools cmake code [aleixpol] Start adopting QCollator -- [...truncated 3600 lines...] [ 24%] [ 24%] Building CXX object tier1/solid/src/solid/CMakeFiles/

Re: Review Request 112792: Move itemviews to tier2

2013-09-18 Thread Aleix Pol Gonzalez
> On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote: > > I was waiting for alex to send the meeting minutes telling people to > > upgrade their Qt repo. > > > > Pushing it now. It's pushed, sorry for the wait >.< - Aleix --- This

Re: Review Request 112717: Start adopting QCollator

2013-09-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/ --- (Updated Sept. 18, 2013, 2:58 p.m.) Status -- This change has been ma

Re: Review Request 112717: Start adopting QCollator

2013-09-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review40273 --- This review has been submitted with commit e7c9d9720635131bef2

Re: Review Request 112792: Move itemviews to tier2

2013-09-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112792/#review40272 --- I was waiting for alex to send the meeting minutes telling peop

KF5 Update Meeting Minutes 2013-w38

2013-09-18 Thread Àlex Fiestas
Hi there These are the minutes of the Week 38 KF5 meeting. As usual it has been held on #kde-devel at 4pm Barcelona (CEST / UTC+2) time. Present on the meeting: agateau, apol, dfaure, jpwhiting, mck182, mgraesslin, sebas, steveire, svuorela, teo-, vHanda, afiestas, d_ed Announcements: *This fr

Review Request 112792: Move itemviews to tier2

2013-09-18 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112792/ --- Review request for KDE Frameworks. Description --- Move itemviews to

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/ --- (Updated Sept. 18, 2013, 2:41 p.m.) Status -- This change has been ma

Re: Review Request 112699: Reorganize KDocTools cmake code

2013-09-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/#review40270 --- This review has been submitted with commit 66b627f9a4f62d4c8e9

Re: ki18n

2013-09-18 Thread Aleix Pol
On Tue, Sep 17, 2013 at 10:55 PM, Treeve Jelbert wrote: > 1. ki18n exists in both tier2 and staging > > 2. kunitconversion (tier2) depends on ki18n(tier2) > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/ma

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- (Updated Sept. 18, 2013, 12:12 p.m.) Review request for KDE Frameworks and

Re: Review Request 112519: trim KStyle

2013-09-18 Thread Wojciech Kapuscinski
> On Sept. 17, 2013, 11:32 p.m., Christoph Feck wrote: > > What exactly is the plan for "KStyle 3/3"? I see many more cruft that could > > be removed for the KF5 version, in particular, all the enums. If that's the > > idea, please ship this in the meantime. >From KF5 wiki "3/3 From what remai