Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-09-11 Thread Martin Gräßlin
> On Aug. 9, 2013, 9:27 p.m., David Faure wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 99 > > > > > > I wonder if this should really derive from KConfigSkeleton, rather than > > encapsulate it. > >

Review Request 112681: Tests for KPluginTrader and friends

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- Review request for KDE Frameworks and David Faure. Description --- Te

Review Request 112680: KPluginTrader: QPluginLoader/metadata-based querying of Plugins

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112680/ --- Review request for KDE Frameworks and David Faure. Description --- A

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review39859 --- 2 issues I'd like to get advise for inline. staging/kservice/

Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- Review request for KDE Frameworks and David Faure. Description --- Th

Re: Dependency specifications

2013-09-11 Thread Aleix Pol
On Tue, Sep 10, 2013 at 7:42 PM, Michael Palimaka wrote: > Hi, > > Currently, the specification for Qt dependencies is not always consistent > between tier1 frameworks. > > In particular, I notice dependencies being specified twice (eg. QtTest in > both project root and in autotests), and test dep

Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager

2013-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/ --- Review request for KDE Frameworks. Description --- Expose setStandard

Jenkins build became unstable: plasma-framework_master_qt5 #726

2013-09-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
> On Sept. 11, 2013, 4:13 p.m., Aurélien Gâteau wrote: > > tier1/kwidgetsaddons/src/kselectaction.cpp, line 240 > > > > > > To avoid duplication you could reimplement > > KSelectAction::addAction(act) as insertAc

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- (Updated Sept. 11, 2013, 5:06 p.m.) Review request for KDE Frameworks. D

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review39840 --- A few nitpicks, but I like this version better. tier1/kwidget

Jenkins build is back to stable : plasma-framework_master_qt5 #727

2013-09-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- (Updated Sept. 11, 2013, 2:55 p.m.) Review request for KDE Frameworks. D

Re: Moving itemviews to tier2

2013-09-11 Thread Aurélien Gâteau
On Wednesday 11 September 2013 15:23:15 Aurélien Gâteau wrote: > Second, the top-level CMakeLists.txt now looks like this: > > cmake_minimum_required(VERSION 2.8.11) > > project(ItemViews) > > find_package(ECM 0.0.8 REQUIRED NO_MODULE) > set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH}) > > s

Moving itemviews to tier2

2013-09-11 Thread Aurélien Gâteau
Hi, I am moving itemviews to tier2 [1], but I have a few questions: First, I noticed ItemViewConfig.cmake.in was lacking some calls other frameworks have, for example: find_dependency(Qt5Widgets @REQUIRED_QT_VERSION@) find_dependency(KCoreAddons ${PACKAGE_VERSION}) I just modified it (and

Re: Review Request 112556: Move itemviews to tier2

2013-09-11 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/ --- (Updated Sept. 11, 2013, 3:22 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread Sebastian Kügler
> On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: > > staging/kservice/src/services/kplugininfo.cpp, line 61 > > > > > > I think that two variables (hidden and _hidden) so similar are > > confusing. > > Seba

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread David Gil Oliva
> On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: > > staging/kservice/src/services/kplugininfo.cpp, line 61 > > > > > > I think that two variables (hidden and _hidden) so similar are > > confusing. > > Seba

Re: Review Request 112665: Drop Obsolete modules from ECM

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/ --- (Updated Sept. 11, 2013, 10:52 a.m.) Status -- This change has been m

Re: Review Request 112665: Drop Obsolete modules from ECM

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/#review39816 --- This review has been submitted with commit 75887108189813f3c05

Re: Review Request 112665: Drop Obsolete modules from ECM

2013-09-11 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/#review39814 --- Ship it! Ship It! - Stephen Kelly On Sept. 11, 2013, 9:44 a

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-11 Thread Sebastian Kügler
> On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: > > staging/kservice/src/services/kplugininfo.cpp, line 61 > > > > > > I think that two variables (hidden and _hidden) so similar are > > confusing. Hm, I th

Review Request 112665: Drop Obsolete modules from ECM

2013-09-11 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/ --- Review request for KDE Frameworks. Description --- ECMVersion.cmake a

Jenkins build is back to normal : plasma-framework_master_qt5 #716

2013-09-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #715

2013-09-11 Thread KDE CI System
See Changes: [notmart] just use c++0x for now -- [...truncated 861 lines...] Building CXX object src/declarativeimports/core/tests/CMakeFiles/runnermodeltest.dir/main.cpp.o [ 54%] Built ta

Build failed in Jenkins: plasma-framework_master_qt5 #714

2013-09-11 Thread KDE CI System
See Changes: [notmart] libplasmaview -> libplsmaquick -- [...truncated 547 lines...]

Jenkins build became unstable: kdelibs_frameworks_qt5 #1177

2013-09-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #713

2013-09-11 Thread KDE CI System
See Changes: [notmart] shell/containmentconfigview.cpp -> plasmaview/containmentconfigview.cpp [notmart] make use of the plasmaview [notmart] add the plasmaview subdir [notmart] add plasmaview/CMakeLists.txt [notmart] add pla

Dependency specifications

2013-09-11 Thread Michael Palimaka
Hi, Currently, the specification for Qt dependencies is not always consistent between tier1 frameworks. In particular, I notice dependencies being specified twice (eg. QtTest in both project root and in autotests), and test dependencies split (eg. QtTest in project root only, and QtXml in au

Build failed in Jenkins: plasma-framework_master_qt5 #712

2013-09-11 Thread KDE CI System
See Changes: [notmart] specify thumbnails in the name -- [...truncated 442 lines...] Scanning dependencies of target plasma_dataengine_example_customDataContainers_automoc [ 11%] Automoc f

Build failed in Jenkins: plasma-framework_master_qt5 #711

2013-09-11 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) [mgraesslin] QQuick item for live updating window thumbnails -- [...truncated 444 lines...] Generating moc_qmenuitem.cpp Gen

Re: Review Request 112633: Modify KTextWidgets CMakeLists.txt for splitting

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112633/ --- (Updated Sept. 11, 2013, 7:27 a.m.) Status -- This change has been ma

Re: Review Request 112633: Modify KTextWidgets CMakeLists.txt for splitting

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112633/#review39797 --- This review has been submitted with commit a26460734f838d498b6