Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-10 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39793 --- staging/kservice/src/services/kplugininfo.cpp

Build failed in Jenkins: plasma-framework_master_qt5 #710

2013-09-10 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace Running

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-10 Thread David Edmundson
> On Sept. 9, 2013, 2:39 p.m., Aurélien Gâteau wrote: > > Instead of adding methods to get buttons and combo boxes from > > KSelectAction, which is an implementation detail to me, what about this: > > > > - Add KSelectAction::insertAction(QAction* before, QAction*) (because what > > KRecentFil

Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- Review request for KDE Frameworks and David Faure. Description --- Th

Re: Review Request 112556: Move itemviews to tier2

2013-09-10 Thread Christoph Feck
> On Sept. 10, 2013, 9:06 p.m., David Faure wrote: > > Ship It! So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is it too late for that? Do we plan to have a proper/final "let's look at what we did" API review after everything has settled? - Christoph

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1174

2013-09-10 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #709

2013-09-10 Thread KDE CI System
See -- [...truncated 537 lines...] Generating applet.moc :0: Note: No relevant classes found. No output gener

Re: Review Request 112643: Adapt KCompletion so that it can be moved to tier2

2013-09-10 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112643/#review39778 --- Ship it! Though I would put the remove_definitions changes in

Re: Review Request 112556: Move itemviews to tier2

2013-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/#review39773 --- Ship it! Ship It! - David Faure On Sept. 10, 2013, 10:45 a.

Re: Review Request 112560: Remove KNotification dependency in KCompletion

2013-09-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112560/#review39748 --- This review has been submitted with commit 61f7afdc7ab7d14f135

Re: Review Request 112560: Remove KNotification dependency in KCompletion

2013-09-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112560/ --- (Updated Sept. 10, 2013, 5:50 p.m.) Status -- This change has been ma

Review Request 112643: Adapt KCompletion so that it can be moved to tier2

2013-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112643/ --- Review request for KDE Frameworks and Stephen Kelly. Description ---

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/ --- (Updated Sept. 10, 2013, 5:39 p.m.) Review request for KDE Frameworks and

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/ --- (Updated Sept. 10, 2013, 4:52 p.m.) Review request for KDE Frameworks and

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread Aleix Pol Gonzalez
> On Sept. 10, 2013, 6:46 a.m., David Faure wrote: > > staging/kdoctools/src/meinproc.cpp, line 112 > > > > > > isn't it better to not define the option, so that the user gets > > "unknown option --cache"? > >

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39743 --- staging/kdoctools/src/meinproc.cpp

Build failed in Jenkins: plasma-framework_master_qt5 #708

2013-09-10 Thread KDE CI System
See Changes: [notmart] support for setting a wallpaper trough drag and drop -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-10 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112570/#review39734 --- Ship it! Ship It! - Stephen Kelly On Sept. 10, 2013, 3:49 p

KF5 Update Meeting Minutes 2013-w37

2013-09-10 Thread Àlex Fiestas
Hi there These are the minutes of the Week 37 KF5 meeting. As usual it has been held on #kde-devel at 4pm Barcelona (CEST / UTC+2) time. Present on the meeting: agateau, apol_, dfaure, jpwhiting, markg85, mck182, mgraesslin, scarpino, sebas, Sho_, steveire, svuorela, teo-, vHanda, afiestas Top

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-10 Thread Àlex Fiestas
> On Sept. 10, 2013, 2:34 p.m., David Faure wrote: > > khtml/khtml_part.cpp, line 1060 > > > > > > I just realized that KIO::storedGet + job->exec() would remove the need > > for a temporary file altogether :-)

Build failed in Jenkins: plasma-framework_master_qt5 #707

2013-09-10 Thread KDE CI System
See Changes: [notmart] use a dynamic property -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559/#review39721 --- Ship it! khtml/html/html_formimpl.cpp

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-10 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559/ --- (Updated Sept. 10, 2013, 1:56 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: plasma-framework_master_qt5 #706

2013-09-10 Thread KDE CI System
See Changes: [notmart] support for wallpaper actions -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review39719 --- Ship it! Looks good to me. Thanks for taking care of adding th

Build failed in Jenkins: plasma-framework_master_qt5 #705

2013-09-10 Thread KDE CI System
See Changes: [notmart] Revert "add kdeqt5staging dependency" -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 112556: Move itemviews to tier2

2013-09-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/ --- (Updated Sept. 10, 2013, 12:45 p.m.) Review request for KDE Frameworks.

Build failed in Jenkins: plasma-framework_master_qt5 #704

2013-09-10 Thread KDE CI System
See Changes: [notmart] propagate drawWallpaperChanged [notmart] propagate containmentTypeChanged -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remo

Build failed in Jenkins: plasma-framework_master_qt5 #703

2013-09-10 Thread KDE CI System
See Changes: [notmart] documentation in ContainmentInterface -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #702

2013-09-10 Thread KDE CI System
See Changes: [notmart] add kdeqt5staging dependency -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #701

2013-09-10 Thread KDE CI System
See Changes: [notmart] remove unused method [notmart] more documentation -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 i

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-10 Thread David Faure
> On Sept. 8, 2013, 9:24 a.m., David Faure wrote: > > kinit/CMakeLists.txt, line 44 > > > > > > This could also be moved out of the if, by using the proper arguments > > for ecm_mark_nongui_executable, so that it

Re: Review Request 112633: Modify KTextWidgets CMakeLists.txt for splitting

2013-09-10 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112633/#review39708 --- Ship it! Ship It! - Stephen Kelly On Sept. 10, 2013, 9:35 a

Build failed in Jenkins: plasma-framework_master_qt5 #700

2013-09-10 Thread KDE CI System
See Changes: [notmart] documentation++ -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Review Request 112633: Modify KTextWidgets CMakeLists.txt for splitting

2013-09-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112633/ --- Review request for KDE Frameworks. Description --- Adds dependencies

Re: Plugin locator performance ballpark

2013-09-10 Thread David Faure
On Monday 09 September 2013 17:10:25 Martin Graesslin wrote: > On Monday 09 September 2013 16:48:05 David Faure wrote: > > On Monday 09 September 2013 14:23:10 Sebastian Kügler wrote: > > > Martin Grässlin asked if we could offer an async API for this. Opinions? > > > > This task is mostly I/O, an

Build failed in Jenkins: plasma-framework_master_qt5 #699

2013-09-10 Thread KDE CI System
See Changes: [wojtask9.kde] remove all links to kdeqt5staging -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 112557: Remove all links to libkdeqt5staging

2013-09-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112557/#review39693 --- This review has been submitted with commit a5bd21c7a7416508af9

Re: Review Request 112571: enable clearButton in kpassworddialog

2013-09-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112571/ --- (Updated Sept. 10, 2013, 8:02 a.m.) Status -- This change has been ma

Re: Review Request 112557: Remove all links to libkdeqt5staging

2013-09-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112557/ --- (Updated Sept. 10, 2013, 8:02 a.m.) Status -- This change has been ma

Re: Review Request 112571: enable clearButton in kpassworddialog

2013-09-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112571/#review39694 --- This review has been submitted with commit 3c1014192bfc7d327a6

Re: installed header includes

2013-09-10 Thread David Faure
On Monday 09 September 2013 16:03:38 Jeremy Whiting wrote: > Hello, > > Apparently my commit to knewstuff broke the build. The problem is that > knewstuff/src/knewstuffbutton.h includes which > hasn't been installed yet when building kdelibs. I looked around and > saw some other frameworks insta