Build failed in Jenkins: plasma-framework_master_qt5 #692

2013-09-05 Thread KDE CI System
See Changes: [kde] Add KBookmarks to list of needed modules to fix build -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in

Review Request 112547: avoid creating jobs on urls with double slashes

2013-09-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112547/ --- Review request for KDE Frameworks. Description --- It happens that so

Re: docbook requirements

2013-09-05 Thread Aleix Pol
On Thu, Sep 5, 2013 at 11:32 PM, David Gil Oliva wrote: > I answer myself (thanks to the info given by sebas through irc): > > If it happens to you, please delete the build dir (at least the e-c-m one) > update e-c-m and rebuild. > > Cheers! > > David Gil > > > > 2013/9/5 David Gil Oliva > >> Hi!

Re: Review Request 111938: Allow installing both qca2 and qca3

2013-09-05 Thread Ivan Romanov
> On Sept. 1, 2013, 5:16 p.m., David Faure wrote: > > Looks fine to me. I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me. - Ivan

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-05 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112527/ --- (Updated Sept. 5, 2013, 9:02 p.m.) Review request for KDE Frameworks. Ch

Re: docbook requirements

2013-09-05 Thread David Gil Oliva
I answer myself (thanks to the info given by sebas through irc): If it happens to you, please delete the build dir (at least the e-c-m one) update e-c-m and rebuild. Cheers! David Gil 2013/9/5 David Gil Oliva > Hi! > > Today I couldn't compile KF5 with the following message from cmake: > >

docbook requirements

2013-09-05 Thread David Gil Oliva
Hi! Today I couldn't compile KF5 with the following message from cmake: -- CMake Warning at staging/kdoctools/src/CMakeLists.txt:27 (find_package): By not providing "FindDocBookXML.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a p

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/ --- (Updated Sept. 5, 2013, 5:58 p.m.) Status -- This change has been mar

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39426 --- This review has been submitted with commit 1add3fa248d92294130

Re: [kdelibs/frameworks] staging/kdoctools: meinproc5.shell doesn't exist anymore since now it doesn't use kde4_add_executable

2013-09-05 Thread Aleix Pol
On Thu, Sep 5, 2013 at 6:09 PM, David Faure wrote: > On Thursday 05 September 2013 16:40:48 Stephen Kelly wrote: > > Aleix Pol wrote: > > > Git commit 25c6f2501ba077ef6f566dac3f12fc766ff5b4ab by Aleix Pol. > > > Committed on 05/09/2013 at 14:36. > > > Pushed by apol into branch 'frameworks'. > >

KCompletion and KNotification

2013-09-05 Thread Aleix Pol
Hi, KCompletion now depends on KNotification, I'd suggest to remove that dependency (I can do it myself). At the moment it's generating quite a bit of DBus noise even though it's not being consumed anywhere I could find. It's used both in KHistoryBox and KCompletion. If you want to test it, you ca

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39419 --- staging/kdoctools/KDocToolsMacros.cmake

Review Request 112545: Unify both meinproc5 binaries

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/ --- Review request for KDE Frameworks and Albert Astals Cid. Description -

Re: [kdelibs/frameworks] staging/kdoctools: meinproc5.shell doesn't exist anymore since now it doesn't use kde4_add_executable

2013-09-05 Thread David Faure
On Thursday 05 September 2013 16:40:48 Stephen Kelly wrote: > Aleix Pol wrote: > > Git commit 25c6f2501ba077ef6f566dac3f12fc766ff5b4ab by Aleix Pol. > > Committed on 05/09/2013 at 14:36. > > Pushed by apol into branch 'frameworks'. > > > > meinproc5.shell doesn't exist anymore since now it doesn't

Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112525/ --- (Updated Sept. 5, 2013, 3:02 p.m.) Status -- This change has been dis

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/ --- (Updated Sept. 5, 2013, 3:05 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39421 --- Ship it! This is fine, thanks. Please add the cmake related ch

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1157

2013-09-05 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/ --- (Updated Sept. 5, 2013, 3:17 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39417 --- Before you move kunitconversion, please add the necessary find_

Review Request 112537: Improve signal emitting in KSelectionOwner

2013-09-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112537/ --- Review request for KDE Frameworks and David Faure. Description --- I

Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/ --- Review request for KDE Frameworks. Description --- I had to tell it t

Build failed in Jenkins: kdelibs_frameworks_qt5 #1156

2013-09-05 Thread KDE CI System
See Changes: [agateau] Port KJob to QEventLoopLocker -- [...truncated 14317 lines...] from

Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-09-05 Thread Aurélien Gâteau
> On Sept. 1, 2013, 10:11 a.m., David Faure wrote: > > Testing that it compiles isn't enough, please test that the unittests still > > pass. :) > > > > Too bad I can't find a test for this precise feature, but at least it would > > be good to check that nothing regresses. Just checked tests d

Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/ --- (Updated Sept. 5, 2013, 9:30 a.m.) Status -- This change has been mar

Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/#review39400 --- This review has been submitted with commit 72b83f857a6a0ec0477

Re: QUrl behavior and KIO

2013-09-05 Thread Marco Martin
On Thursday 05 September 2013, David Faure wrote: > > See, you even knew that ;) > > > what should be done? modify kio to make qurls without scheme work (and > > assume they are file://) or modify all the users to make sure a scheme is > > always passed? > > Correct porting to QUrl is the only t

Build failed in Jenkins: kdelibs_frameworks_qt5 #1155

2013-09-05 Thread KDE CI System
See Changes: [faure] Document another KUrl->QUrl porting trap. -- [...truncated 14319 lines...] from

Re: QUrl behavior and KIO

2013-09-05 Thread David Faure
On Wednesday 04 September 2013 18:39:57 Marco Martin wrote: > Hi all, > porting a couple of kio slaves (trying to make sense of the trash kio partly > ported to kf5 in a gsoc) i noticed what appears to be a slight behavior > change compared to when it used KUrl > > something like this in kde4 was

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112527/#review39394 --- staging/kemoticons/src/providers/adium/adium_emoticons.cpp