Review Request 112532: Extend KShortcutsEditor by an actionTypes property

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112532/ --- Review request for KDE Frameworks. Description --- This change allows

Build failed in Jenkins: plasma-framework_master_qt5 #691

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspac

Build failed in Jenkins: kdelibs_frameworks_qt5 #1154

See Changes: [kde] KIO_EXPORT -> KBOOKMARKS_EXPORT in kbookmarks [kde] Install KBookarksConfig.cmake.in file and update kfile to link properly -- [...truncated 13953 lines...]

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

> On Sept. 4, 2013, 6:08 p.m., Alexander Neundorf wrote: > > Did you verify that these files work as expected ? > > > > AFAIK, find_package_handle_standard_args() sets by default the > > UPPERCASE_FOUND variable, not the CamelCase_FOUND variable. > > To have it set CamelCase_FOUND, i.e. DocBook

Plugin locator performance ballpark

Hi, I've had a look at the performance of loading plugins. First, some background: We've taken the first steps towards moving away from KSyCoCa for plugins. By including metadata in the plugin, we don't need to keep the metadata installed (via .desktop files) and indexed separately, but can g

Build failed in Jenkins: plasma-framework_master_qt5 #690

See Changes: [bhush94] Port DataEngineTracker example, -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Review Request 112527: Clean up KEmoticons framework (prior to splitting)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112527/ --- Review request for KDE Frameworks. Description --- Clean up KEmoticon

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/#review39385 --- kio/bookmarks/kbookmark.h

Build failed in Jenkins: plasma-framework_master_qt5 #689

See Changes: [bhush94] Update examples/TODO -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39357 --- Ship it! Ship It! - Luigi Toscano On Sept. 4, 2013, 1:55 p.

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

> On Sept. 3, 2013, 12:34 p.m., David Faure wrote: > > staging/kbookmarks/tests/CMakeLists.txt, line 9 > > > > > > Isn't that only for unittests? If this is wrong kconfigwidgets and ktextwidgets and kcompletion are

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39360 --- This review has been submitted with commit d42d5889d25ac4c900a

Build failed in Jenkins: kdelibs_frameworks_qt5 #1153

See Changes: [aleixpol] Remove unneeded include -- [...truncated 493 lines...] -- Looking for include files sys/types.h, libutil.h -- Looking for include files sys/types.h, libutil.h - not foun

Jenkins build became unstable: kdelibs_frameworks_qt5 #1148

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

QUrl behavior and KIO

Hi all, porting a couple of kio slaves (trying to make sense of the trash kio partly ported to kf5 in a gsoc) i noticed what appears to be a slight behavior change compared to when it used KUrl something like this in kde4 was working: KUrl u; u.setPath( "/some/valid/path" ); KIO::Job* job = KIO:

Re: Review Request 112519: trim KStyle

> On Sept. 4, 2013, 10:20 p.m., Christoph Feck wrote: > > staging/frameworkintegration/src/kstyle/kstyle.h, line 98 > > > > > > The "runtime element extension" should probably stay. They are useful, > > and Qt/QSt

Re: Review Request 112485: Cleaning up KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112485/ --- (Updated Sept. 4, 2013, 6:18 p.m.) Status -- This change has been mar

Review Request 112525: Properly check for QtNetwork/QSslSocket

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112525/ --- Review request for KDE Frameworks. Description --- Don't use QT_INCLU

Review Request 112519: trim KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/ --- Review request for KDE Frameworks. Description --- KStyle 2/3: Remove

Re: Review Request 112519: trim KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review39383 --- staging/frameworkintegration/src/kstyle/kstyle.h

Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112525/ --- (Updated Sept. 4, 2013, 10:05 p.m.) Review request for Build System and KD

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39359 --- Ship it! Ship It! - Stephen Kelly On Sept. 4, 2013, 2:46 p.

Re: Review Request 112485: Cleaning up KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112485/#review39374 --- This review has been submitted with commit 7a17aabbdd5e7d609fb

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:46 p.m.) Review request for Build System, KDE Fr

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/ --- (Updated Sept. 4, 2013, 4:59 p.m.) Status -- This change has been mar

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:50 p.m.) Status -- This change has been mar

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39371 --- Did you verify that these files work as expected ? AFAIK, find

Build failed in Jenkins: kdelibs_frameworks_qt5 #1151

See Changes: [aleixpol] Cleaning up KCompletion -- [...truncated 495 lines...] -- Looking for include files sys/types.h, libutil.h -- Looking for include files sys/types.h, libutil.h - not foun

Build failed in Jenkins: kdelibs_frameworks_qt5 #1152

See Changes: [mklapetek] Split required Qt version into variable for KCrash CMakeLists.txt -- [...truncated 493 lines...] -- Looking for include files sys/types.h, libutil.h -- Looking for incl

Re: Qt Dev Days 2013

On Thursday 22 Aug 2013 22:32:19 John Layt wrote: > KDE e.V. has a limited number of sponsored tickets to Qt Contributors > Day and Qt Dev Days itself (excluding the Training Day) in return for > assistance running the conference. For more details on > this offer see my blog [2] or the Dot articl

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/#review39366 --- This review has been submitted with commit 454c537a44cd06cd739

Re: Review Request 112457: Start cleanup of KDocTools

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112457/ --- (Updated Sept. 4, 2013, 4:15 p.m.) Status -- This change has been mar

Re: Review Request 112485: Cleaning up KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112485/#review39362 --- Ship it! staging/kcompletion/src/klineedit.cpp

Build failed in Jenkins: kdelibs_frameworks_qt5 #1149

See Changes: [aleixpol] Start cleanup of KDocTools -- [...truncated 494 lines...] -- Looking for include files sys/types.h, libutil.h -- Looking for include files sys/types.h, libutil.h - not f

Re: Review Request 112457: Start cleanup of KDocTools

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112457/#review39363 --- This review has been submitted with commit 68700795415a04715ca

Build failed in Jenkins: kdelibs_frameworks_qt5 #1150

See Changes: [kde] Move kio/kbookmarks into it's own folder in staging [kde] Remove deprecated methods in kbookmark [kde] Fix linking on kbookmarks [kde] Move kbookmark tests to kbookmarks folder [kde] Tidy comments in CMakeLists.

Build failed in Jenkins: plasma-framework_master_qt5 #688

See Changes: [bhush94] Port sourceOnRequest DataEngine from examples [bhush94] Port customDataContainersEngine example -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered b

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 1:55 p.m.) Review request for Build System, KDE Fr

Build failed in Jenkins: plasma-framework_master_qt5 #687

See Changes: [bhush94] Port simple DataEngine example -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #686

See Changes: [notmart] add missing file -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 12:16 p.m.) Review request for Build System, KDE F

Re: Review Request 112495: Move kcrash to tier2

Martin Klapetek wrote: > I'm not implying it's a bad thing, merely that I don't think merging > couple related one-liners into one bigger patch is that big problem. Ok, whatever. Some day you might know better :). Thanks, Steve. ___ Kde-frameworks-d

Re: Review Request 112495: Move kcrash to tier2

On Wed, Sep 4, 2013 at 1:08 PM, Stephen Kelly wrote: > Martin Klapetek wrote: > >> 1) It would be much better if you made several patches for things like > >> this. > >> One patch to remove the remove_definitions() calls, one patch to add > >> Qt5::Gui to the link interface, one patch to add the

Re: Review Request 112495: Move kcrash to tier2

Martin Klapetek wrote: >> 1) It would be much better if you made several patches for things like >> this. >> One patch to remove the remove_definitions() calls, one patch to add >> Qt5::Gui to the link interface, one patch to add the needed >> find_dependency() calls, and then finally the patch mov

Re: Review Request 112495: Move kcrash to tier2

Martin Klapetek wrote: > > >> On Sept. 4, 2013, 10:47 a.m., Stephen Kelly wrote: >> > staging/kcrash/CMakeLists.txt, line 12 >> > >> > >> > Why was this needed? Widgets already finds Qt5Gui. > > Isn't it the oth

Re: Review Request 112495: Move kcrash to tier2

> On Sept. 4, 2013, 10:47 a.m., Stephen Kelly wrote: > > staging/kcrash/CMakeLists.txt, line 12 > > > > > > Why was this needed? Widgets already finds Qt5Gui. Isn't it the other way around (Gui finds Widgets)? It

Re: Review Request 112495: Move kcrash to tier2

On Wed, Sep 4, 2013 at 12:43 PM, Stephen Kelly wrote: > David Faure wrote: > > > On Sept. 3, 2013, 8:35 p.m., Martin Klapetek wrote: > >> > >> --- > >> This is an automatically generated e-mail. To reply, visit: > >> http://git.reviewboard.k

Build failed in Jenkins: plasma-framework_master_qt5 #685

See Changes: [notmart] windowlist -> windowthumbnails -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #684

See Changes: [notmart] readd testcontainment, as an example -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace <

Re: Review Request 112495: Move kcrash to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112495/#review39330 --- staging/kcrash/CMakeLists.txt

Re: Review Request 112495: Move kcrash to tier2

David Faure wrote: > On Sept. 3, 2013, 8:35 p.m., Martin Klapetek wrote: >> >> --- >> This is an automatically generated e-mail. To reply, visit: >> http://git.reviewboard.kde.org/r/112495/ >> -

Build failed in Jenkins: plasma-framework_master_qt5 #683

See Changes: [notmart] remove color wallpaper from this repo -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 112495: Move kcrash to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112495/ --- (Updated Sept. 4, 2013, 10:01 a.m.) Status -- This change has been ma

Re: Review Request 112495: Move kcrash to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112495/#review39326 --- This review has been submitted with commit 16964ce920f96cee53f

Build failed in Jenkins: plasma-framework_master_qt5 #682

See Changes: [notmart] Revert "remove test applets" [notmart] old test applets live now in examples [notmart] add a bunch of test applets that already work [notmart] add 3 example plasmoids to be ported [notmart] dataengines a

Build failed in Jenkins: plasma-framework_master_qt5 #681

See Changes: [hein] Move the screen prop up into AppletInterface. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in worksp

Re: Review Request 112495: Move kcrash to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112495/#review39318 --- Ship it! KCrash is tested by kde-runtime/drkonqi/tests/crashte

Re: Review Request 112151: Use components in FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39317 --- Ship it! Ship It! - Stephen Kelly On Sept. 4, 2013, 7:45 a.

Re: Review Request 112151: Use components in FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Sept. 4, 2013, 9:45 a.m.) Review request for KDE Frameworks, Alex

Re: Review Request 112151: Use components in FindXCB

On Sept. 4, 2013, 9:26 a.m., Martin Gräßlin wrote: > > Here's a diff fixing the issues: > > > > diff --git a/find-modules/FindXCB.cmake b/find-modules/FindXCB.cmake > > index 2684ed0..823d167 100644 > > --- a/find-modules/FindXCB.cmake > > +++ b/find-modules/FindXCB.cmake > > @@ -60,9 +60,15 @@

Re: Review Request 112151: Use components in FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39310 --- find-modules/FindXCB.cmake

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1142

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel