Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 8:37 a.m.) Review request for KDE Frameworks. Ch

Review Request 112500: Adjust finding of XCB to new component based FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112500/ --- Review request for KDE Frameworks. Description --- Requires https://g

Review Request 112499: Rework finding of XCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112499/ --- Review request for KDE Frameworks and Plasma. Description --- Rework

Re: Review Request 112151: Use components in FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Sept. 4, 2013, 6:57 a.m.) Review request for KDE Frameworks, Alex

Build failed in Jenkins: plasma-framework_master_qt5 #680

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspac

Jenkins build is back to stable : kdelibs_stable #796

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112495: Move kcrash to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112495/ --- (Updated Sept. 3, 2013, 8:35 p.m.) Review request for KDE Frameworks. De

Review Request 112495: Move kcrash to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112495/ --- Review request for KDE Frameworks. Description --- Removes the remove

Re: Review Request 112451: Actually install the modules in the ecm attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39293 --- You may consider renaming the variables from ALLUPPERCASE_SOMET

Build failed in Jenkins: kdelibs_frameworks_qt5 #1141

See Changes: [caslav.ilic] KLocalizedString::availableApplicationTranslations method. -- [...truncated 29319 lines...] -- Installing:

Re: Review Request 112401: Let ki18n report the list of available translations of the application

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112401/ --- (Updated Sept. 3, 2013, 8:22 p.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #1140

See Changes: [afiestas] Move KScanDialog (kscan.[cpp,h,desktop]) to kde4support/kio -- [...truncated 29320 lines...] -- Installing:

Re: Review Request 112450: Move KScanDialog to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112450/ --- (Updated Sept. 3, 2013, 5:09 p.m.) Status -- This change has been mar

Re: Review Request 112488: Fix isReadable() not handling edge case

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112488/ --- (Updated Sept. 3, 2013, 4:58 p.m.) Status -- This change has been mar

Re: Review Request 112488: Fix isReadable() not handling edge case

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112488/#review39284 --- Ship it! Wow, it even comes with a unit test :-) Great. - Dav

Re: Review Request 112488: Fix isReadable() not handling edge case

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112488/#review39285 --- This review has been submitted with commit a69d5e52c8b57fb3174

Review Request 112488: Fix isReadable() not handling edge case

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112488/ --- Review request for KDE Frameworks and David Faure. Description --- Th

Re: Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112455/ --- (Updated Sept. 3, 2013, 4:54 p.m.) Status -- This change has been mar

Jenkins build became unstable: kdelibs_stable #795

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112449: Move KUnitConverter files to src/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112449/ --- Status -- This change has been marked as submitted. Review request fo

Re: Review Request 112449: Move KUnitConverter files to src/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112449/#review39282 --- This review has been submitted with commit 31ab845315fe0544010

KF5 Update Meeting Minutes 2013-w36

This is the minutes of the Week 36 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, dgilo, markg85, mck182, mgraesslin, PovAddict, sebas, shadeslayer, svuorela, teo-, vHanda and myself This might actually be an attendance record ;) An

Review Request 112485: Cleaning up KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112485/ --- Review request for KDE Frameworks. Description --- Document dependenc

Re: Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112455/#review39275 --- Ship it! Once this is in, I think you can move netaccess to kd

Re: Review Request 112481: Revert port to QFile::Permissions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112481/ --- (Updated Sept. 3, 2013, 3:31 p.m.) Status -- This change has been mar

Re: Review Request 112481: Revert port to QFile::Permissions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112481/#review39276 --- This review has been submitted with commit 5581f3424563c53ac02

Build failed in Jenkins: plasma-framework_master_qt5 #679

See Changes: [notmart] convert location to Plasma::Types::Location [notmart] unbreak mouse release event [notmart] hardcoded enum values-- -- Started by remote host 2a01:4f8:160:9363::9 w

Re: Review Request 112461: Move KGuiAddons to tier1/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112461/ --- (Updated Sept. 3, 2013, 3:42 p.m.) Status -- This change has been mar

Re: Review Request 112450: Move KScanDialog to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112450/#review39279 --- kio/kio/kscan.h

Re: Review Request 112461: Move KGuiAddons to tier1/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112461/#review39278 --- This review has been submitted with commit e8c494e10b303034591

Re: Review Request 112481: Revert port to QFile::Permissions

> On Sept. 3, 2013, 2:35 p.m., David Faure wrote: > > It's now kioslave/file/file.cpp, please adjust indeed. > > > > Don't simplify isReadable: there's 000 (the first if), 444 (the second if), > > and other combinations (004, 040, 400) (the case where neither of these > > simple tests pass so

Re: Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

> On Sept. 3, 2013, 2 p.m., David Faure wrote: > > kfile/kdirselectdialog.cpp, line 559 > > > > > > return path.isEmpty() ? url : QUrl::fromLocalFile(path); > > > > would save 6 lines and increase readabi

Re: Review Request 112481: Revert port to QFile::Permissions

> On Sept. 3, 2013, 4:35 p.m., David Faure wrote: > > It's now kioslave/file/file.cpp, please adjust indeed. > > > > Don't simplify isReadable: there's 000 (the first if), 444 (the second if), > > and other combinations (004, 040, 400) (the case where neither of these > > simple tests pass so

Re: Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112455/ --- (Updated Sept. 3, 2013, 3 p.m.) Review request for KDE Frameworks and Davi

Re: Review Request 112481: Revert port to QFile::Permissions

> On Sept. 3, 2013, 4:35 p.m., David Faure wrote: > > It's now kioslave/file/file.cpp, please adjust indeed. > > > > Don't simplify isReadable: there's 000 (the first if), 444 (the second if), > > and other combinations (004, 040, 400) (the case where neither of these > > simple tests pass so

Re: Review Request 112449: Move KUnitConverter files to src/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112449/#review39268 --- Ship it! staging/kunitconversion/src/CMakeLists.txt

Re: Review Request 112151: Use components in FindXCB

> On Sept. 3, 2013, 9:40 a.m., Stephen Kelly wrote: > > find-modules/FindXCB.cmake, line 187 > > > > > > Is it even possible to hit these fatal errors? I thought find_path and > > find_library would always set th

Re: Review Request 112481: Revert port to QFile::Permissions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112481/#review39266 --- Ship it! It's now kioslave/file/file.cpp, please adjust indeed

Re: Review Request 112481: Revert port to QFile::Permissions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112481/ --- (Updated Sept. 3, 2013, 4:04 p.m.) Review request for KDE Frameworks and D

Re: Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112455/#review39264 --- Much better. One bug though. kfile/kdirselectdialog.cpp

Re: Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112455/ --- (Updated Sept. 3, 2013, 1:46 p.m.) Review request for KDE Frameworks and D

Build failed in Jenkins: plasma-framework_master_qt5 #678

See Changes: [notmart] remove test applets -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Review Request 112481: Revert port to QFile::Permissions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112481/ --- Review request for KDE Frameworks and David Faure. Description --- Pa

Re: Review Request 112151: Use components in FindXCB

> On Sept. 3, 2013, 11:40 a.m., Stephen Kelly wrote: > > find-modules/FindXCB.cmake, line 187 > > > > > > Is it even possible to hit these fatal errors? I thought find_path and > > find_library would always set t

Re: Review Request 112457: Start cleanup of KDocTools

> On Sept. 3, 2013, 9:30 a.m., David Faure wrote: > > staging/kdoctools/src/meinproc.cpp, line 146 > > > > > > I'd write exe = QStringLiteral(XMLLINT) > > instead of putting the QStringLiteral in the config-fo

Re: Review Request 112451: Actually install the modules in the ecm attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 3, 2013, 12:45 p.m.) Review request for Build System, KDE F

Re: Review Request 111938: Allow installing both qca2 and qca3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/#review39256 --- This review has been submitted with commit bfeabc149ed64abc1a6

Re: Review Request 111938: Allow installing both qca2 and qca3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/ --- (Updated Sept. 3, 2013, 12:42 p.m.) Status -- This change has been ma

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/#review39255 --- Ship it! Cool. I don't think we want core/gui separation. Boo

Re: Re: XCB vs. KModifierKeyInfoProvider

On Tuesday 03 September 2013 13:05:05 David Faure wrote: > On Monday 02 September 2013 15:01:13 Martin Graesslin wrote: > > P.S.: looking at lxr it seems that there used to be a unit test. What > > happened to it? Was it just forgotten to be moved? > > What do you mean? > > I can only find kdeui/

Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/ --- Review request for KDE Frameworks. Description --- Split Bookmarks ou

Build failed in Jenkins: plasma-framework_master_qt5 #677

See Changes: [notmart] config file is plasma-org.kde.desktop-appletsrc -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in w

Build failed in Jenkins: plasma-framework_master_qt5 #676

See Changes: [notmart] experiment with ConditionalLoader -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Re: XCB vs. KModifierKeyInfoProvider

On Monday 02 September 2013 15:01:13 Martin Graesslin wrote: > P.S.: looking at lxr it seems that there used to be a unit test. What > happened to it? Was it just forgotten to be moved? What do you mean? I can only find kdeui/tests/kmodifierkeyinfotest.cpp in KDE4 which became staging/kguiaddons

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 9, 2013, 7:27 p.m., David Faure wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 99 > > > > > > I wonder if this should really derive from KConfigSkeleton, rather than > > encapsulate it. > >

Re: K_PLUGIN_FACTORY changes explained

On Friday, August 30, 2013 14:11:59 you wrote: > On Friday 23 August 2013 14:21:02 Sebastian Kügler wrote: > > Hey, > > > > I've written a somewhat lengthy and detailed article about the changes to > > our plugin system: > > > > http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-gut

Re: Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112229/ --- (Updated Sept. 3, 2013, 9:44 a.m.) Status -- This change has been mar

Re: Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112229/#review39245 --- This review has been submitted with commit 588d427520db48457a5

Re: Review Request 112151: Use components in FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39244 --- find-modules/FindXCB.cmake

Re: Review Request 112457: Start cleanup of KDocTools

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112457/#review39242 --- Ship it! just one thing staging/kdoctools/config-kdoctools.h

Re: Review Request 112151: Use components in FindXCB

> On Sept. 3, 2013, 8:07 a.m., Stephen Kelly wrote: > > Thanks. > > > > Copying what I wrote before: > > > > > You wrote that it allows having some components be optional, and others > > > be required. However, you don't seem to follow the advice here to do > > > that: > > > http://cmake.org

Re: Review Request 112151: Use components in FindXCB

> On Sept. 3, 2013, 10:07 a.m., Stephen Kelly wrote: > > Thanks. > > > > Copying what I wrote before: > > > > > You wrote that it allows having some components be optional, and others > > > be required. However, you don't seem to follow the advice here to do > > > that: > > > http://cmake.or

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

> On Sept. 3, 2013, 11:09 a.m., David Faure wrote: > > Just tested it, Caps Lock works fine. > > > > The only thing I couldn't figure out in the test app is the mouse button > > checkboxes at the bottom. mouse buttons work for me. Though I did not get First and Second X Button to work. - Ma

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review39239 --- Ship it! Just tested it, Caps Lock works fine. The only thing

Re: Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112229/#review39238 --- Ship it! Oh, OK, yes. BTW I fixed the other issue meanwhile,

Re: Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

> On Aug. 30, 2013, 8:54 a.m., David Faure wrote: > > tier1/kconfig/src/core/kconfigini.cpp, line 522 > > > > > > Are you sure about this? Does it work even if the file doesn't exist? > > > > The check yo

KF5 Update Meeting 2013-w36 Reminder

Hello all, I forgot to send it yesterday, so just a quick reminder: The next KF5 Update Meeting will happen *today* at *4pm* Paris time. See you there! Regards. (yes, I copy/pasted the last one) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Framewor

Re: Review Request 112151: Use components in FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/#review39235 --- Thanks. Copying what I wrote before: > You wrote that it allo

Re: Review Request 112151: Use components in FindXCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Sept. 3, 2013, 9:37 a.m.) Review request for KDE Frameworks, Alex

Re: Review Request 112461: Move KGuiAddons to tier1/

> On Sept. 3, 2013, 6:04 a.m., Martin Gräßlin wrote: > > This will conflict with http://git.reviewboard.kde.org/r/112443/ - what's > > the way how to handle this? Push it first and I rebase my patch. - Martin --- This is an automatical