Re: Review Request 112151: Use components in FindXCB

> On Aug. 27, 2013, 4:08 p.m., Stephen Kelly wrote: > > find-modules/FindXCB.cmake, line 184 > > > > > > I don't think 'NAMES lib' is correct. That will search for a lib named > > 'lib' with certain patterns, eg

Re: Review Request 112151: Use components in FindXCB

> On Aug. 27, 2013, 6:08 p.m., Stephen Kelly wrote: > > find-modules/FindXCB.cmake, line 184 > > > > > > I don't think 'NAMES lib' is correct. That will search for a lib named > > 'lib' with certain patterns, eg

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 3, 2013, 8:18 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112461: Move KGuiAddons to tier1/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112461/#review39227 --- This will conflict with http://git.reviewboard.kde.org/r/112443

Build failed in Jenkins: plasma-framework_master_qt5 #675

See Changes: [sebas] Show package path in warning [sebas] default to org.kde.desktoptoolbox [sebas] only reference existing packges [sebas] org.kde.desktop is not a containment -- Starte

Build failed in Jenkins: plasma-framework_master_qt5 #674

See Changes: [sebas] Fix include -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112455/#review39214 --- In all cases, why not just check the return value from exec(),

Re: Review Request 112451: Actually install the modules in the ecm attic

> On Sept. 2, 2013, 3:46 p.m., David Faure wrote: > > I'm pretty sure this is wrong. > > > > Attic == to be sorted out. > > > > If these two find modules are needed, extract them, clean them up (ensure > > they pass modern standards, whatever that is exactly for cmake modules, I > > assume th

Re: Review Request 112461: Move KGuiAddons to tier1/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112461/#review39210 --- Ship it! Looks good, assuming you went through the checklist a

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review39205 --- kioslave/CMakeLists.txt

Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- Review request for KDE Runtime and KDE Frameworks. Description --- Th

Build failed in Jenkins: plasma-framework_master_qt5 #673

See Changes: [notmart] remove redundancy [notmart] Corona::packageChanged() signal -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxS

Review Request 112461: Move KGuiAddons to tier1/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112461/ --- Review request for KDE Frameworks. Description --- Move KGuiAddons in

Build failed in Jenkins: plasma-framework_master_qt5 #672

See Changes: [notmart] use a QmlWallpaper package type for wallpapers -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in wo

Re: Review Request 112407: Port KJob to QEventLoopLocker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/#review39199 --- I have to pack for my holidays so can't do the change David sug

Re: Review Request 112401: Let ki18n report the list of available translations of the application

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112401/#review39196 --- Ship it! Looks good :-) - Albert Astals Cid On Sept. 1, 201

Re: Review Request 112401: Let ki18n report the list of available translations of the application

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112401/#review39197 --- Ship it! Looks good to me, it would be good if someone else ap

Re: Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112453/#review39195 --- This review has been submitted with commit e4bed2b333b26497c27

Re: Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112453/ --- (Updated Sept. 2, 2013, 5:55 p.m.) Status -- This change has been mar

Build failed in Jenkins: plasma-framework_master_qt5 #671

See Changes: [notmart] remove done todos -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #670

See Changes: [notmart] don't depend from shellpluginloader -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #669

See Changes: [notmart] move ShellPackage in libplasma -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Review Request 112457: Start cleanup of KDocTools

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112457/ --- Review request for KDE Frameworks. Description --- Start using DocBoo

Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112455/ --- Review request for KDE Frameworks and David Faure. Description --- Po

Re: Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112453/#review39181 --- Ship it! I suppose QStringLiteral would be better in the place

Build failed in Jenkins: plasma-framework_master_qt5 #668

See Changes: [notmart] Corona::setPackage(QString) uses a Package -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in worksp

Re: Review Request 112367: Include the icon's theme in the cache key

> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112353: An attempt to fix sometimes failing KArchive test

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112353/ --- (Updated Sept. 2, 2013, 4:15 p.m.) Status -- This change has been mar

Re: Review Request 112353: An attempt to fix sometimes failing KArchive test

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112353/#review39180 --- This review has been submitted with commit 2e29caa231f6cef625e

Review Request 112453: Remove remove_definitions(..) from KGuiAddons CMakeLists

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112453/ --- Review request for KDE Frameworks. Description --- This is a preparat

Re: Review Request 112451: Actually install the modules in the ecm attic

> On Sept. 2, 2013, 3:46 p.m., David Faure wrote: > > I'm pretty sure this is wrong. > > > > Attic == to be sorted out. > > > > If these two find modules are needed, extract them, clean them up (ensure > > they pass modern standards, whatever that is exactly for cmake modules, I > > assume th

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1129

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112449: Move KUnitConverter files to src/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112449/#review39178 --- staging/kunitconversion/src/converter.h

Re: Review Request 112451: Actually install the modules in the ecm attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39177 --- I'm pretty sure this is wrong. Attic == to be sorted out. If

Re: Review Request 112007: Use KDE configured shortcuts for Qt default key bindings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112007/ --- (Updated Sept. 2, 2013, 3:45 p.m.) Status -- This change has been mar

Re: Review Request 112007: Use KDE configured shortcuts for Qt default key bindings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112007/#review39176 --- This review has been submitted with commit 9732e18e80a199a7043

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/ --- (Updated Sept. 2, 2013, 3:14 p.m.) Status -- This change has been dis

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/ --- (Updated Sept. 2, 2013, 3:13 p.m.) Review request for KDE Frameworks. De

Review Request 112451: Actually install the modules in the ecm attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- Review request for Build System and KDE Frameworks. Description --- W

Re: Review Request 112367: Include the icon's theme in the cache key

> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112367: Include the icon's theme in the cache key

> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 112450: Move KScanDialog to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112450/#review39171 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept. 2,

Re: Review Request 112450: Move KScanDialog to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112450/ --- (Updated Sept. 2, 2013, 2:58 p.m.) Review request for KDE Frameworks. Ch

Review Request 112450: Move KScanDialog to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112450/ --- Review request for KDE Frameworks. Description --- Move KScanDialog a

Review Request 112449: Move KUnitConverter files to src/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112449/ --- Review request for KDE Frameworks. Description --- Move all the files

Build failed in Jenkins: plasma-framework_master_qt5 #667

See Changes: [notmart] add acceptedButtons prop as MouseArea -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace

Re: What to do with KScanDialog

On Sunday 01 September 2013 21:58:25 Kåre Särs wrote: > On Sunday 01 September 2013 13:34:50 Martin Koller wrote: > > On Saturday 31 August 2013 23:11:57 Kåre Särs wrote: > > > I would vote to move it to kde4support and deprecate it. I can volunteer > > > to > > > port kolourpaint to libksane if ne

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 9, 2013, 9:27 p.m., David Faure wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 99 > > > > > > I wonder if this should really derive from KConfigSkeleton, rather than > > encapsulate it. > >

Re: XCB vs. KModifierKeyInfoProvider

On Monday 02 September 2013 10:39:53 you wrote: > On Monday 02 September 2013 09:05:27 Martin Gräßlin wrote: > > 3) I just don't like it and would feel very uncomfortable given that we > > don't have unit tests and that this could break in future if xkb.h > > becomes > > available. > > Why not de

Build failed in Jenkins: plasma-framework_master_qt5 #666

See Changes: [ivan.cukic] Missing files -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Jenkins build became unstable: kdelibs_frameworks_qt5 #1128

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112331: Splitting KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review39138 --- This review has been submitted with commit 86a8bf726924692c46a

Re: Review Request 112331: Splitting KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/ --- (Updated Sept. 2, 2013, 10:46 a.m.) Status -- This change has been ma

Build failed in Jenkins: plasma-framework_master_qt5 #665

See Changes: [ivan.cukic] Ported the broken branch to a new one [ivan.cukic] Added documentation for the Application class [ivan.cukic] Removed DesktopCorona -- Started by remote host 2a0

Re: Review Request 112401: Let ki18n report the list of available translations of the application

> On Sept. 1, 2013, 10:25 p.m., Albert Astals Cid wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 1293 > > > > > > Should this insert be outside the if block? > > Chusslove Illich wrote: > I chose on

Re: Review Request 112401: Let ki18n report the list of available translations of the application

> On Sept. 1, 2013, 10:25 p.m., Albert Astals Cid wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 1293 > > > > > > Should this insert be outside the if block? > > Chusslove Illich wrote: > I chose on

Re: XCB vs. KModifierKeyInfoProvider

On Monday 02 September 2013 09:05:27 Martin Gräßlin wrote: > 3) I just don't like it and would feel very uncomfortable given that we > don't have unit tests and that this could break in future if xkb.h becomes > available. Why not declare the struct but with a different name? Then it can't clash

Re: Review Request 112401: Let ki18n report the list of available translations of the application

> On Sept. 1, 2013, 10:25 p.m., Albert Astals Cid wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 1293 > > > > > > Should this insert be outside the if block? > > Chusslove Illich wrote: > I chose on

Re: Review Request 112401: Let ki18n report the list of available translations of the application

> On Sept. 1, 2013, 10:25 p.m., Albert Astals Cid wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 1293 > > > > > > Should this insert be outside the if block? I chose on impulse to have it not ignore the

Review Request 112443: Draft of native event filter porting for KModifierKeyInfoProvider

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- Review request for KDE Frameworks. Description --- Not working due to

XCB vs. KModifierKeyInfoProvider

Hi all, I just started porting KModifierKeyInfoProvider to a QAbstractNativeEventFilter and hit a problem. The existing x11Event filter looks for X11 XkbEvent. Now in Qt 5 we would have to look for the matching event in XCB. But that doesn't exist. There seems to be an XKB extension for XCB wh