Re: Review Request 112331: Splitting KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review39040 --- staging/kunitconversion/src/kunitconversion/CMakeLists.txt

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

> On Aug. 27, 2013, 1:47 p.m., Albert Astals Cid wrote: > > Question is, why should it go into this function and not say into others > > that also accept a language string? Maybe this should go there somewhere as > > a static helper function? I mean yes, we are using this function from > > som

Review Request 112418: replace KSharedPtr with QExplicitlySharedDataPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112418/ --- Review request for KDE Frameworks. Description --- replace KSharedPtr

Re: What to do with KScanDialog

On Saturday 31 August 2013 19:42:02 Gilles Caulier wrote: > Hi, > > libksane in kdegraphics/libs is the right alternative, very well maintained > : > > https://projects.kde.org/projects/kde/kdegraphics/libs/libksane > > It work under Linux and OSX using libsane. Under Windows it use Twain > inte

What to do with KScanDialog

KScanDialog is currently being used by two apps: kolourpaint and kooka-git according to lxr. This makes me wonder if we should move it to a tier (forcing us to maintain it) or just move it to kde4support and deprecated it. In my opinion if none of the users of this class wants to maintain it we

Review Request 112407: Port KJob to QEventLoopLocker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/ --- Review request for KDE Frameworks. Description --- Port KJob to QEven

Re: Review Request 112407: Port KJob to QEventLoopLocker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/ --- (Updated Aug. 31, 2013, 4:29 p.m.) Review request for KDE Frameworks. De

Re: DBusMenuQt5 cmake foo

On Saturday 31 August 2013, David Faure wrote: > On Saturday 31 August 2013 02:51:09 Sebastian Kügler wrote: > > So I've tried both alternative, changing both calls to either DBusMenuQt > > or DBusMenuQt5, but neither of them works, both break over the package > > not being found, but required. > >

Re: Review Request 112331: Splitting KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/ --- (Updated Aug. 31, 2013, 4:12 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112331: Splitting KUnitConversion

> On Aug. 31, 2013, 7:01 a.m., David Faure wrote: > > Solid seems like a "big" dependency just to know if we're online. > > I would either > > 1) keep the ifdefs for solid, so that someone can easily compile it without > > solid for his own purposes, or > > 2) port it to QNetworkInterface (I did

Re: Review Request 112331: Splitting KUnitConversion

> On Aug. 31, 2013, 7:20 a.m., Chusslove Illich wrote: > > staging/kunitconversion/src/kunitconversion/CMakeLists.txt, line 10 > > > > > > Also the translation domain is configured in config-kunitconversion.h. > >

Re: Review Request 112363: Make it possible for QToolBar to use "Other toolbar" settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112363/#review39022 --- This review has been submitted with commit 33dc6599948e6a69a97

Re: Review Request 112363: Make it possible for QToolBar to use "Other toolbar" settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112363/ --- (Updated Aug. 31, 2013, 2:41 p.m.) Status -- This change has been mar

Is this task done?

Hi guys, been browsing http://community.kde.org/Frameworks/Epics/kdelibs_cleanups and seen Update QCommandLineParser from the version that landed in qtbase dev and fix compilation (including plasma-framework). At least one thing changed, positionalArguments() and addHelpOption(str) is now setA

Build failed in Jenkins: plasma-framework_master_qt5 #663

See Changes: [notmart] re-add the calendar qml component -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #662

See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace Running

Force push to plasma-framework

Hi everyone, Due to an unfortunate accident involving git merge, several branches of the plasma-framework repository were rendered unusable. To correct this, two branches have been forcibly rewound. They are: - master: now at ea1b637 - ivan/shell-switching: now at f8c2ff5. The following commits

Re: Review Request 112401: Let ki18n report the list of available translations of the application

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112401/#review39006 --- staging/ki18n/src/klocalizedstring.cpp

Re: Review Request 112177: Split URL drop functionality from KLineEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112177/ --- (Updated Aug. 31, 2013, 11:55 a.m.) Status -- This change has been ma

Re: Review Request 112177: Split URL drop functionality from KLineEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112177/#review39004 --- This review has been submitted with commit 4a3118b33f208990409

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

> On Aug. 27, 2013, 1:47 p.m., Albert Astals Cid wrote: > > Question is, why should it go into this function and not say into others > > that also accept a language string? Maybe this should go there somewhere as > > a static helper function? I mean yes, we are using this function from > > som

Review Request 112401: Let ki18n report the list of available translations of the application

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112401/ --- Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol Gonzalez.

Re: DBusMenuQt5 cmake foo

On Saturday, August 31, 2013 09:45:13 David Faure wrote: > > * The library naming is also messed up, not working here. What to do? > > What's messed up? The _LIBRARIES var is unset, that's what I meant with messed up -- not working. :) I'll talk to Aurelien to see how we can get the cmake file

Re: K_PLUGIN_FACTORY changes explained

On Saturday 31 August 2013 10:59:33 Boudewijn Rempt wrote: > > * QCoreApplication::libraryPaths() should be used, instead of going from > > bin/foo to ../lib/*/ - ouch ;) > > Well, that didn't work -- not without setting environment variables like > QT_PLUGIN_DIR. We did give it a try, but librar

Re: K_PLUGIN_FACTORY changes explained

On Sat, 31 Aug 2013, David Faure wrote: On Friday 30 August 2013 17:36:20 Boudewijn Rempt wrote: I'm also not sure whether this still works with current e-c-m, but first we set the plugin_install_dir: find_package(KF5 REQUIRED MODULE COMPONENTS CMake Compiler InstallDirs) set(kdelibs_SOURCE_DI

Re: K_PLUGIN_FACTORY changes explained

On Friday 30 August 2013 17:36:20 Boudewijn Rempt wrote: > I'm also not sure whether this still works with current e-c-m, but first we > set the plugin_install_dir: > > find_package(KF5 REQUIRED MODULE COMPONENTS CMake Compiler InstallDirs) > set(kdelibs_SOURCE_DIR TRUE) > # override the kf5 plugi

Re: kconfig build fails with recent qt5

On Friday 30 August 2013 10:02:06 Treeve Jelbert wrote: > -DQT_NO_CAST_FROM_ASCII That's the issue. It is unset by the toplevel CMakeLists.txt currently, which breaks when building things standalone. Thanks for testing that. I'll fix it for good everywhere. -- David Faure, fa...@kde.org, ht

Re: DBusMenuQt5 cmake foo

On Saturday 31 August 2013 02:51:09 Sebastian Kügler wrote: > So I've tried both alternative, changing both calls to either DBusMenuQt or > DBusMenuQt5, but neither of them works, both break over the package not > being found, but required. > I've looked for a *Config.cmake file (as suggested), non

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1114

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112331: Splitting KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review38987 --- staging/kunitconversion/src/kunitconversion/CMakeLists.txt

Jenkins build became unstable: kdelibs_frameworks_qt5 #1113

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112363: Make it possible for QToolBar to use "Other toolbar" settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112363/#review38984 --- Looks good, just minor things found KDE5PORTING.html

Re: Review Request 112331: Splitting KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review38983 --- Solid seems like a "big" dependency just to know if we're onlin

Build failed in Jenkins: plasma-framework_master_qt5 #661

See Changes: [heena393] revert back merge changes -- [...truncated 482 lines...] Generating moc_iconitem.cpp Generating moc_runnermodel.cpp Generating moc_serviceoperationstatus.cpp Generat