Build failed in Jenkins: plasma-framework_master_qt5 #654

2013-08-29 Thread KDE CI System
See Changes: [sebas] Improve porting scripts -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38906 --- The change seems reasonable (but keep in mind it makes one of t

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38905 --- Yes it makes sense, although probably we should just nuke the c

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38893 --- Looks good to me, but someone else should approve. - David Edm

Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/ --- Review request for KDE Frameworks, kdelibs and Michael Pyne. Description -

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-29 Thread Kevin Ottens
Hello, On Wednesday 28 August 2013 20:26:45 Albert Astals Cid wrote: > If you bundle lots of stuff in the tarball you may end up "wrongly" > increasing your dependencies and people won't use the framework because "it > depends on QtNetwork" or some other stuff that it's only used in > kwalletmanag

Review Request 112363: Make it possible for QToolBar to use "Other toolbar" settings

2013-08-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112363/ --- Review request for KDE Frameworks. Description --- Qt only knows abou

Re: KEmoticons splitting task

2013-08-29 Thread Kevin Ottens
Hello, On Wednesday 28 August 2013 22:32:50 David Gil Oliva wrote: > 2013/8/27 Kevin Ottens > > On Monday 26 August 2013 23:36:13 David Gil Oliva wrote: > > > I took the KEmoticons splitting task. I'm studying the code and I have > > > found many issues: > > > > > > --KEmoticonsProvider should b

Build failed in Jenkins: plasma-framework_master_qt5 #653

2013-08-29 Thread KDE CI System
See Changes: [notmart] enable panel shadows [notmart] add shadows to dialogs -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave -

Re: Review Request 112353: An attempt to fix sometimes failing KArchive test

2013-08-29 Thread Mario Bensi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112353/#review38834 --- Ship it! Ship It! - Mario Bensi On Aug. 29, 2013, 10:13 a.m

Review Request 112353: An attempt to fix sometimes failing KArchive test

2013-08-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112353/ --- Review request for KDE Frameworks. Description --- One of the KArchiv