Re: KEmoticons splitting task

2013-08-28 Thread David Gil Oliva
Hi, 2013/8/27 Kevin Ottens > Hello, > > On Monday 26 August 2013 23:36:13 David Gil Oliva wrote: > > I took the KEmoticons splitting task. I'm studying the code and I have > > found many issues: > > > > --KEmoticonsProvider should be abstract, since its virtual methods either > > don't do anyth

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-28 Thread Albert Astals Cid
El Diumenge, 25 d'agost de 2013, a les 12:05:11, Valentin Rusu va escriure: > On 08/24/2013 01:43 PM, Albert Astals Cid wrote: > > El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: > >> * Another piece of software related to kwallet is KWalletManager from > >> kdeutils. I

Review Request 112331: Splitting KUnitConversion

2013-08-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/ --- Review request for KDE Frameworks. Description --- Iterates over KUni

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-28 Thread Alexander Neundorf
On Tuesday 27 August 2013, Ben Cooksley wrote: > On Wed, Aug 28, 2013 at 2:54 AM, Alexander Neundorf wrote: > > On Friday 23 August 2013, Ben Cooksley wrote: > >> On Fri, Aug 23, 2013 at 7:14 PM, David Faure wrote: > >> > On Friday 23 August 2013 06:51:23 Martin Graesslin wrote: > >> >> Given th

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1102

2013-08-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1101

2013-08-28 Thread KDE CI System
See Changes: [faure] Move KFileItemActions to kiowidgets [faure] Martin didn't use update_qcommandline.sh :) -- [...truncated 29530 lines...] -- Installing:

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

2013-08-28 Thread Albert Astals Cid
> On Aug. 27, 2013, 1:47 p.m., Albert Astals Cid wrote: > > Question is, why should it go into this function and not say into others > > that also accept a language string? Maybe this should go there somewhere as > > a static helper function? I mean yes, we are using this function from > > som

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

2013-08-28 Thread Chusslove Illich
> On Aug. 27, 2013, 1:47 p.m., Albert Astals Cid wrote: > > Question is, why should it go into this function and not say into others > > that also accept a language string? Maybe this should go there somewhere as > > a static helper function? I mean yes, we are using this function from > > som

Build failed in Jenkins: kdelibs_frameworks_qt5 #1100

2013-08-28 Thread KDE CI System
See Changes: [mgraesslin] Adjust to QCommandLineParser as it ended in Qt -- [...truncated 2994 lines...] [ 19%] [ 19%] Scanning dependencies of target kdeclarative_automoc Automoc for target st

Re: Qt Dev Days 2013

2013-08-28 Thread John Layt
On Thursday 22 Aug 2013 22:32:19 John Layt wrote: > KDE e.V. has a limited number of sponsored tickets to Qt Contributors > Day and Qt Dev Days itself (excluding the Training Day) in return for > assistance running the conference. KDE e.V. is not able to offer > travel or accommodation assistance

Re: Review Request 112324: Adjust to QCommandLineParser as it ended in Qt

2013-08-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112324/ --- (Updated Aug. 28, 2013, 10:38 a.m.) Status -- This change has been ma

Re: Review Request 112324: Adjust to QCommandLineParser as it ended in Qt

2013-08-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112324/#review38787 --- This review has been submitted with commit 0b5cd00d6f3024ab4c3

Review Request 112325: Complete the migration to Q_GLOBAL_STATIC

2013-08-28 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112325/ --- Review request for KDE Frameworks. Description --- Complete the migra

Re: Review Request 112324: Adjust to QCommandLineParser as it ended in Qt

2013-08-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112324/#review38785 --- Ship it! Ship It! - David Faure On Aug. 28, 2013, 9:01 a.m.

Re: Review Request 112324: Adjust to QCommandLineParser as it ended in Qt

2013-08-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112324/ --- (Updated Aug. 28, 2013, 11:01 a.m.) Review request for KDE Frameworks and

Re: Review Request 112324: Adjust to QCommandLineParser as it ended in Qt

2013-08-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112324/#review38779 --- Ship it! Looks fine, thanks! Just one thing that could be don

Jenkins build became unstable: kdelibs_frameworks_qt5 #1099

2013-08-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112324: Adjust to QCommandLineParser as it ended in Qt

2013-08-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112324/ --- Review request for KDE Frameworks and David Faure. Description --- se