Re: What's up with KRun::runCommand?

On Monday 26 August 2013 14:52:48 Vishesh Handa wrote: > Hey David > > I was trying to port kmimetypechooser away from KRun, so I started to look > at the implementation of KRun. It seems to be somewhat strange - > > bool KRun::runCommand(const QString& cmd, const QString &execName, > const QStri

Re: Smart D-Ptr in KCoreAddons

On Friday 23 August 2013 16:37:56 Ivan Čukić wrote: > > The few cases where I have needed d-ptr hierachies, I didn't know about > > it in advance but was happy than I could extend my classes without having > > to use a different smartpointer (with possibly a different size). > > Exactly. The *few*

KF5 Update Meeting 2013-w35 Reminder

Hello all, I forgot to send it yesterday, so just a quick reminder: The next KF5 Update Meeting will happen *today* at *4pm* Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a d

Re: KEmoticons splitting task

Hello, On Monday 26 August 2013 23:36:13 David Gil Oliva wrote: > I took the KEmoticons splitting task. I'm studying the code and I have > found many issues: > > --KEmoticonsProvider should be abstract, since its virtual methods either > don't do anything or their code is not safe. Could you be

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

> On Aug. 26, 2013, 7:08 a.m., Kevin Ottens wrote: > > tier1/sonnet/src/ui/spellcheckdecorator.h, line 40 > > > > > > I would rather have a setter than an extra ctor parameter if possible. > > Since we already hav

What's up with KRun::runCommand?

Hey David I was trying to port kmimetypechooser away from KRun, so I started to look at the implementation of KRun. It seems to be somewhat strange - bool KRun::runCommand(const QString& cmd, const QString &execName, const QString & iconName, QWidget* window, const QByteAr

KEmoticons splitting task

Hello, I took the KEmoticons splitting task. I'm studying the code and I have found many issues: --KEmoticonsProvider should be abstract, since its virtual methods either don't do anything or their code is not safe. --Many KEmoticons tests don't pass (I haven't actually changed anything yet). An

Review Request 112303: KIO: Move krun tests to staging/kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112303/ --- Review request for KDE Frameworks. Description --- KIO: Move krun tes

Review Request 112302: Make export include in KIO consistent

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112302/ --- Review request for KDE Frameworks. Description --- Make export includ

Jenkins build is back to stable : plasma-framework_master_qt5 #631

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

> On Aug. 26, 2013, 6:25 p.m., Albert Astals Cid wrote: > > if you want to see the language codes we have, they are listed in > > http://websvn.kde.org/trunk/l10n-kde4/ > > > > To be honest i don't see why we need conversion between uiLanguages and > > here since uiLanguages returns what we i

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/#review38687 --- if you want to see the language codes we have, they are listed

Re: Smart D-Ptr in KCoreAddons

> That alone is - I think - a reason to not have it. A small update. It now supports inherited privates as well. Ch -- Science gathers knowledge faster than society gathers wisdom. -- Isaac Asimov ___ Kde-frameworks-devel mailing list Kde-fra

Jenkins build became unstable: kdelibs_frameworks_qt5 #1084

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: plasma-framework_master_qt5 #630

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112225: Port ::mmap to QT_MMAP

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112225/#review38664 --- This review has been submitted with commit 6713c121aedf1cfc705

Re: Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

> On Aug. 26, 2013, 6:47 a.m., Kevin Ottens wrote: > > Looks OK. Assuming you ran the whole kdelibs test suite and it all passed. Actually running the whole suite I have 6 tests failing with no patches and a clean build (running the tests as described in the wiki), some of them even segfaultin

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38663 --- This review has been submitted with commit 4433027b85e199f11a9

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- (Updated Aug. 26, 2013, 3:52 p.m.) Status -- This change has been mar

Re: Review Request 112225: Port ::mmap to QT_MMAP

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112225/ --- (Updated Aug. 26, 2013, 3:52 p.m.) Status -- This change has been mar

Jenkins build is back to stable : kdelibs_stable #779

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1082

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/ --- (Updated Aug. 26, 2013, 2:48 p.m.) Review request for KDE Frameworks, Albe

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/#review38652 --- Ship it! staging/xmlgui/src/kswitchlanguagedialog_p.cpp

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

> On Aug. 26, 2013, 1:35 p.m., Kevin Ottens wrote: > > staging/xmlgui/src/kswitchlanguagedialog_p.cpp, line 333 > > > > > > From QLocale documentation if the ctor didn't find the language in the > > database it t

Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/ --- Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol Gonzalez.

Re: Review Request 112282: Move platformHints into their own class

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112282/ --- (Updated Aug. 26, 2013, 2:34 p.m.) Status -- This change has been mar

Re: Review Request 112282: Move platformHints into their own class

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112282/#review38649 --- This review has been submitted with commit a1241501a4283152ab7

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/ --- (Updated Aug. 26, 2013, 2:34 p.m.) Review request for KDE Frameworks and A

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

> On Aug. 26, 2013, 1:35 p.m., Kevin Ottens wrote: > > staging/xmlgui/src/kswitchlanguagedialog_p.cpp, line 333 > > > > > > From QLocale documentation if the ctor didn't find the language in the > > database it t

Re: Review Request 112279: Call the correct static Q[Gui]Application::setFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/ --- (Updated Aug. 26, 2013, 2:27 p.m.) Status -- This change has been mar

Re: Review Request 112277: Fix deadlock by avoid calling Qfont::QFont() in KFontSettingsData

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112277/ --- (Updated Aug. 26, 2013, 2:27 p.m.) Status -- This change has been mar

Re: Review Request 112277: Fix deadlock by avoid calling Qfont::QFont() in KFontSettingsData

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112277/#review38646 --- This review has been submitted with commit 90d6bcbb0dfddb2eaa1

Re: Review Request 112279: Call the correct static Q[Gui]Application::setFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/#review38647 --- This review has been submitted with commit 77825a8f27b25a19e15

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

> On Aug. 26, 2013, 1:35 p.m., Kevin Ottens wrote: > > staging/xmlgui/src/kswitchlanguagedialog_p.cpp, line 333 > > > > > > From QLocale documentation if the ctor didn't find the language in the > > database it t

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/#review38639 --- staging/xmlgui/src/kswitchlanguagedialog_p.cpp

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38636 --- Ship it! Ship It! - Kevin Ottens On Aug. 26, 2013, 12:07 p.

Re: Review Request 112279: Call the correct static Q[Gui]Application::setFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/#review38635 --- Ship it! Ship It! - Kevin Ottens On Aug. 26, 2013, 12:05 p.

Review Request 112288: fillApplicationLanguages: Do not add the system locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Description

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/ --- (Updated Aug. 26, 2013, 1:06 p.m.) Review request for KDE Frameworks and A

kdelibs fails

Hi, I started to test KF5 builds, but it fails with this error. Interestingly, it builds on Jenkins. Any idea? In file included from /local/qt5/include/QtCore/qvariant.h:50:0, from /local/qt5/include/QtCore/qabstractitemmodel.h:45, from /local/qt5/include/QtCo

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- (Updated Aug. 26, 2013, 12:07 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112279: Call the correct static Q[Gui]Application::setFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/ --- (Updated Aug. 26, 2013, 12:05 p.m.) Review request for KDE Frameworks and

Jenkins build became unstable: kdelibs_frameworks_qt5 #1079

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112279: Call the correct static Q[Gui]Application::setFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/ --- (Updated Aug. 26, 2013, 12:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 112279: Call the correct static Q[Gui]Application::setFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/ --- (Updated Aug. 26, 2013, 12:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 112279: Call the correct static Q[Gui]Application::setFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/ --- (Updated Aug. 26, 2013, noon) Review request for KDE Frameworks and Kevin

Re: Review Request 112279: Call the correct static Q[Gui]Application::setFont

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/ --- (Updated Aug. 26, 2013, noon) Review request for KDE Frameworks and Kevin

Re: I'm out

Hello, On Friday 23 August 2013 00:38:49 Alexander Neundorf wrote: > On Thursday 22 August 2013, Kevin Ottens wrote: > > On Thursday 22 August 2013 09:14:16 Stephen Kelly wrote: > > > Mark wrote: > > > > On Wed, Aug 21, 2013 at 10:20 PM, Alexander Neundorf > > > > wrote: > > > >> until recently I

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1078

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Concerns about deprecating KFileDialog

Hello, On Saturday 24 August 2013 07:53:08 Martin Graesslin wrote: > On Saturday 24 August 2013 00:12:09 Andrius da Costa Ribas wrote: > > (crosspost between kde-frameworks-devel and kde-windows) > > > > I've posted a question in a recent review request that deprecates > > KFileDialog in favor of

Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/ --- (Updated Aug. 26, 2013, 10:33 a.m.) Status -- This change has been ma

Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/#review38605 --- This review has been submitted with commit 68871933beeec0a9a64

Re: Review Request 112079: Add utility function to paint icon overlays

> On Aug. 26, 2013, 6:37 a.m., Kevin Ottens wrote: > > staging/kguiaddons/src/util/kiconutils.h, line 31 > > > > > > Not sure about the use of "draw" here. Those methods don't draw, right? > > > > "Adds" s

Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/#review38582 --- Ship it! - David Faure On Aug. 23, 2013, 11:27 p.m., Aleix P

Re: Review Request 112282: Move platformHints into their own class

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112282/#review38581 --- staging/frameworkintegration/src/platformtheme/kdeplatformthem

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review38580 --- tier1/sonnet/src/ui/spellcheckdecorator.h

Re: Review Request 112277: Fix deadlock by avoid calling Qfont::QFont() in KFontSettingsData

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112277/#review38579 --- staging/frameworkintegration/src/platformtheme/kfontsettingsda

Re: Review Request 112277: Fix deadlock by avoid calling Qfont::QFont() in KFontSettingsData

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112277/#review38578 --- Ship it! Ship It! - Kevin Ottens On Aug. 25, 2013, 8:38 p.m

Re: Review Request 112279: Use qApp->setFont so we magically use QGuiApplication or QApplication

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/#review38577 --- staging/frameworkintegration/src/platformtheme/kfontsettingsda