Re: Requiring qtbase from a few days ago

2013-08-15 Thread Ben Cooksley
On Thu, Aug 15, 2013 at 11:21 AM, Kevin Ottens wrote: > On Wednesday 14 August 2013 22:51:18 Albert Astals Cid wrote: >> El Dimecres, 14 d'agost de 2013, a les 05:54:36, Àlex Fiestas va escriure: >> > Tomorrow (If nobody objects) I will push some changes that require this >> > commit in qtbase: >>

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Andrius da Costa Ribas
> On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: > > Small question: by replacing KFileDialog by QFileDialog do we still provide the settings to choose whether to use Native or KDE dialog on Windows? I use the KDE one here because of the places panel where I have lots of SFTP/FTP/SMB places

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Teo Mrnjavac
> On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: > > kfile/kdirselectdialog.cpp, line 408 > > > > > > Hmmm it makes me realize, couldn't KEncodingFileDialog be made to > > depend on the file module only? That w

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 15, 2013, 3:36 p.m.) Review request for KDE Frameworks. De

Re: Review Request 111675: Port away from kde_file in KRecentDocument (KIO)

2013-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/ --- (Updated Aug. 15, 2013, 2:38 p.m.) Status -- This change has been mar

Re: Review Request 111675: Port away from kde_file in KRecentDocument (KIO)

2013-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/#review37846 --- This review has been submitted with commit aac36d00532afac245d

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-15 Thread Martin Klapetek
> On Aug. 14, 2013, 3:40 p.m., Aurélien Gâteau wrote: > > Forgot one thing: file names should be renamed to not start with "q". Maybe > > kiconoverlay.*? Yeah I wasn't really sure about the name, but I didn't want to name it "kiconoverlay" as there is no kicon (and it puts overlay over qicon).

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-15 Thread Martin Klapetek
> On Aug. 14, 2013, 3 p.m., Aurélien Gâteau wrote: > > staging/kguiaddons/src/util/qiconoverlay.h, line 29 > > > > > > Since the methods are in a KIconUtils namespace, maybe their name can > > be simplified to "ad

Re: Review Request 111675: Port away from kde_file in KRecentDocument (KIO)

2013-08-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/#review37829 --- Ship it! Ship It! - David Faure On Aug. 14, 2013, 9:43 p.m.

Review Request 112096: Port KWindowEffects to XCB

2013-08-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112096/ --- Review request for KDE Frameworks and Marco Martin. Description --- B