Re: Review Request 109526: Implement SH_Widget_Animate in KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109526/#review37816 --- Ship it! Ship It! - Kevin Ottens On Aug. 13, 2013, 6:07 p.m

Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109527/#review37815 --- Shouldn't most if not all the files where you removed the KGlob

Re: Requiring qtbase from a few days ago

On Wednesday 14 August 2013 22:51:18 Albert Astals Cid wrote: > El Dimecres, 14 d'agost de 2013, a les 05:54:36, Àlex Fiestas va escriure: > > Tomorrow (If nobody objects) I will push some changes that require this > > commit in qtbase: > > 0ace3112137b78cf7d150e9974e69ccfe6838533 > > > > The chan

Re: Review Request 111675: Port away from kde_file in KRecentDocument (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/ --- (Updated Aug. 14, 2013, 9:43 p.m.) Review request for KDE Frameworks. Ch

Re: Requiring qtbase from a few days ago

El Dimecres, 14 d'agost de 2013, a les 05:54:36, Àlex Fiestas va escriure: > Hi there everybody! > > Tomorrow (If nobody objects) I will push some changes that require this > commit in qtbase: > 0ace3112137b78cf7d150e9974e69ccfe6838533 > > The changes I will push are: > https://git.reviewboard.kd

Re: Main Toolbar/Toolbar in QToolBar

On Wednesday 14 August 2013 18:27:30 David Faure wrote: > On Wednesday 14 August 2013 17:33:26 Kevin Ottens wrote: > > Is it me or we just need a method in KWidgetsAddons to declare which > > toolbar of a window is the main one? That choice is obviously in the > > hands > > of the application deve

Re: Main Toolbar/Toolbar in QToolBar

On Wednesday 14 August 2013 17:33:26 Kevin Ottens wrote: > Is it me or we just need a method in KWidgetsAddons to declare which > toolbar of a window is the main one? That choice is obviously in the hands > of the application developer, And that would be used only in new client > code. All other t

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review37774 --- Forgot one thing: file names should be renamed to not start wit

Re: Main Toolbar/Toolbar in QToolBar

So, after looking one last time into QWidget/QToolBar the only thing we can do is use dynamic properties so that's what I will do. Since using a dynamic Property is only a good enough solution, but not excellent I'm going to wait until tomorrow to implement this just in case somebody else comes

Re: Main Toolbar/Toolbar in QToolBar

On Wednesday 14 August 2013 17:25:15 Kevin Ottens wrote: > On Wednesday 14 August 2013 16:45:50 Aurélien Gâteau wrote: > > Le mercredi 14 août 2013 16:06:07 Àlex Fiestas a écrit : > > > On Wednesday 14 August 2013 13:58:44 you wrote: > > > > > , of course there are exceptions but we > > > > > can't

Re: Main Toolbar/Toolbar in QToolBar

On Wednesday 14 August 2013 16:45:50 Aurélien Gâteau wrote: > Le mercredi 14 août 2013 16:06:07 Àlex Fiestas a écrit : > > On Wednesday 14 August 2013 13:58:44 you wrote: > > > > , of course there are exceptions but we > > > > can't move all these logic to Qt. > > > > > > These aren't exceptions.

Re: Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review37765 --- staging/kguiaddons/src/util/qiconoverlay.h

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review37766 --- kio/kfile/kurlrequester.h

Re: Main Toolbar/Toolbar in QToolBar

Le mercredi 14 août 2013 16:06:07 Àlex Fiestas a écrit : > On Wednesday 14 August 2013 13:58:44 you wrote: > > > , of course there are exceptions but we > > > can't move all these logic to Qt. > > > > These aren't exceptions. > > > > The definition of "Main Toolbar" was that it's the first mainwi

Re: Main Toolbar/Toolbar in QToolBar

On Wednesday 14 August 2013 16:06:07 Àlex Fiestas wrote: > On Wednesday 14 August 2013 13:58:44 you wrote: > > > , of course there are exceptions but we > > > can't move all these logic to Qt. > > > > These aren't exceptions. > > > > The definition of "Main Toolbar" was that it's the first mainwi

Re: Main Toolbar/Toolbar in QToolBar

On Wednesday 14 August 2013 13:58:44 you wrote: > > , of course there are exceptions but we > > can't move all these logic to Qt. > > These aren't exceptions. > > The definition of "Main Toolbar" was that it's the first mainwindow toolbar. > > You can't call other-than-first exceptions, they are

Requiring qtbase from a few days ago

Hi there everybody! Tomorrow (If nobody objects) I will push some changes that require this commit in qtbase: 0ace3112137b78cf7d150e9974e69ccfe6838533 The changes I will push are: https://git.reviewboard.kde.org/r/109527/ https://git.reviewboard.kde.org/r/109526/ And then Aleix will move kgloba

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 14, 2013, 12:20 p.m.) Review request for KDE Frameworks. D

Re: Main Toolbar/Toolbar in QToolBar

On Tuesday 13 August 2013 15:33:59 Àlex Fiestas wrote: > On Tuesday 13 August 2013 15:05:46 Christoph Feck wrote: > > On Tuesday 13 August 2013 14:00:37 Àlex Fiestas wrote: > > > Effectively a Main Toolbar is usually a toolbar that is a child of > > > QMainWindow while a "ToolBar" is a toolbar who'

Review Request 112079: Add utility function to paint icon overlays

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- Review request for KDE Frameworks. Description --- As this was reject

Re: kde_file.h vs POSIX headers vs qplatformdefs.h

Le vendredi 9 août 2013 21:54:10 David Faure a écrit : > On Thursday 08 August 2013 16:56:23 Aurélien Gâteau wrote: > > Hi, > > > > I started working on a kdelibs cleanup task: > > > > "Make use of qplatformdefs.h definitions instead of using the POSIX > > versions directly. Partly revert that co