Re: Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax

> On Aug. 13, 2013, 9:41 a.m., Kevin Ottens wrote: > > tier1/kwidgetsaddons/src/kpassivepopup.cpp, line 132 > > > > > > I would stick to the old syntax for cases like this. Or rename the > > second signal with th

Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109527/ --- (Updated Aug. 13, 2013, 6:33 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 109526: Implement SH_Widget_Animate in KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109526/ --- (Updated Aug. 13, 2013, 6:07 p.m.) Review request for KDE Frameworks. Ch

finding DBusMenuQt5

FindDBusMenuQt5.cmake is staging/knotifications kf5libs finds DBusMenuQt5 -- DBusMenuQt5_INCLUDE_DIR=/opt/qt5/include/dbusmenu-qt5 DBusMenuQt5_LIBRARY=/opt/qt5/lib/libdbusmenu-qt5.so DBusMenuQt5_VERSION=0.9.2 but kwin5 does not CMake Warning at CMakeLists.txt:82 (find_package): By not provi

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

> On Aug. 13, 2013, 11:08 a.m., Albert Astals Cid wrote: > > Can it maybe even be a QCoreApplication? Probably yes :) Kevin? - Wojciech --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112

Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112060/ --- Review request for KDE Frameworks. Description --- Everything in stag

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112060/ --- (Updated Aug. 13, 2013, 5:18 p.m.) Review request for KDE Frameworks. De

Review Request 112064: Port S_IS*(x) macros to their qplatformdefs equivalents

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112064/ --- Review request for KDE Frameworks. Description --- Port S_IS*(x) macr

Jenkins build became unstable: kdelibs_frameworks_qt5 #1028

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112038: Look for LibAttica where needed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/ --- (Updated Aug. 13, 2013, 3:35 p.m.) Status -- This change has been mar

Re: Review Request 112038: Look for LibAttica where needed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/#review37702 --- This review has been submitted with commit 2dd9af275d81b35f303

Re: Notes from Frameworks5 Promo BoF at Akademy

So this open email has been lingering in my inbox for more than a week. Fail. During Akademy, we talked about quite some strategical stuff, as opposed to the below more applied items. Devajah, since you have all the notes and wrote up a good part of it already, would you send this material here

Re: Review Request 112038: Look for LibAttica where needed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/#review37699 --- Ship it! Ship It! - Stephen Kelly On Aug. 13, 2013, 2:28 p.

KF5 Update Meeting Minutes 2013-w33

Hello everyone, This is the minutes of the Week 33 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, d_ed, mck182, mgraesslin, sebas, shadeslayer, vHanda, wojtask9 and myself. Announcement: * Focus for the coming week is on closing

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1027

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112038: Look for LibAttica where needed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/ --- (Updated Aug. 13, 2013, 2:28 p.m.) Review request for KDE Frameworks and S

Re: Review Request 112038: Look for LibAttica where needed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/ --- (Updated Aug. 13, 2013, 2:12 p.m.) Review request for KDE Frameworks and S

Jenkins build became unstable: kdelibs_frameworks_qt5 #1026

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112054: Fix sonnet not rehighlighting when language changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112054/#review37695 --- This review has been submitted with commit b3bd1bc848102be7d8b

Re: Review Request 112054: Fix sonnet not rehighlighting when language changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112054/ --- (Updated Aug. 13, 2013, 1:57 p.m.) Status -- This change has been mar

Re: Review Request 112054: Fix sonnet not rehighlighting when language changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112054/#review37694 --- Ship it! Ship It! - Kevin Ottens On Aug. 13, 2013, 1:14 p.m

Re: Main Toolbar/Toolbar in QToolBar

On Tuesday 13 August 2013 15:05:46 Christoph Feck wrote: > On Tuesday 13 August 2013 14:00:37 Àlex Fiestas wrote: > > Effectively a Main Toolbar is usually a toolbar that is a child of > > QMainWindow while a "ToolBar" is a toolbar who's parent is another > > QWidget. > > A secondary toolbar is ev

Review Request 112054: Fix sonnet not rehighlighting when language changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112054/ --- Review request for KDE Frameworks. Description --- Request rehighligh

Re: Main Toolbar/Toolbar in QToolBar

On Tuesday 13 August 2013 14:00:37 Àlex Fiestas wrote: > Effectively a Main Toolbar is usually a toolbar that is a child of > QMainWindow while a "ToolBar" is a toolbar who's parent is another > QWidget. A secondary toolbar is every toolbar not called the "Main Toolbar". For example in Konqueror,

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

> On Aug. 13, 2013, 2:01 p.m., Mark Gaiser wrote: > > Interesting: "Copyright 2009 Marco Martin ". I think you > > need to adjust the license part in those new files. > > Martin Gräßlin wrote: > why? The copyright is still correct. Marco has been the one who wrote > that code back in 2009.

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1025

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111911/ --- (Updated Aug. 13, 2013, 12:18 p.m.) Status -- This change has been ma

Re: Main Toolbar/Toolbar in QToolBar

On Tuesday 13 August 2013 14:00:37 Àlex Fiestas wrote: > So, last thing to discuss about "Make QToolBar follow KDE settings" is the > differentiation we do between Main Toolbar and just Toolbar. > > Effectively a Main Toolbar is usually a toolbar that is a child of > QMainWindow while a "ToolBar"

Re: Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111911/#review37686 --- This review has been submitted with commit 4cf434b4e892bd5c36f

Re: Review Request 112038: Look for LibAttica where needed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/#review37683 --- Finding dependencies in config files is a generally/generically

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/ --- (Updated Aug. 13, 2013, 12:16 p.m.) Status -- This change has been ma

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/#review37685 --- This review has been submitted with commit 7f145933af2debffb44

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

> On Aug. 13, 2013, 12:01 p.m., Mark Gaiser wrote: > > Interesting: "Copyright 2009 Marco Martin ". I think you > > need to adjust the license part in those new files. > > Martin Gräßlin wrote: > why? The copyright is still correct. Marco has been the one who wrote > that code back in 2009

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

> On Aug. 13, 2013, 2:01 p.m., Mark Gaiser wrote: > > Interesting: "Copyright 2009 Marco Martin ". I think you > > need to adjust the license part in those new files. why? The copyright is still correct. Marco has been the one who wrote that code back in 2009. What I just changed is trivial an

Main Toolbar/Toolbar in QToolBar

So, last thing to discuss about "Make QToolBar follow KDE settings" is the differentiation we do between Main Toolbar and just Toolbar. Effectively a Main Toolbar is usually a toolbar that is a child of QMainWindow while a "ToolBar" is a toolbar who's parent is another QWidget. While Qt doesn't

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112052/#review37681 --- Interesting: "Copyright 2009 Marco Martin ". I think you need

Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112052/ --- Review request for KDE Frameworks. Description --- Proper implementat

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/#review37676 --- Can it maybe even be a QCoreApplication? - Albert Astals Cid

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/ --- (Updated Aug. 13, 2013, 11:06 a.m.) Review request for KDE Frameworks. D

Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/ --- Review request for KDE Frameworks. Description --- port kconfig_compi

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/#review37673 --- Ship it! Ship It! - Kevin Ottens On Aug. 13, 2013, 10:25 a.

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/ --- (Updated Aug. 13, 2013, 12:25 p.m.) Review request for KDE Frameworks. C

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

> On Aug. 9, 2013, 1:49 p.m., Kevin Ottens wrote: > > tier1/sonnet/src/ui/highlighter.cpp, line 237 > > > > > > I still don't see what the changes in this file have to do with the > > rest of the patch. Could you

Re: Review Request 111943: Port to qplatformdefs.h: stat() and fopen() calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111943/ --- (Updated Aug. 13, 2013, 9:44 a.m.) Status -- This change has been mar

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

> On Aug. 12, 2013, 9:24 a.m., Kevin Ottens wrote: > > tier1/kconfig/src/gui/CMakeLists.txt, line 15 > > > > > > You will have to rebase your patch because of a commit I've pushed just > > now. It should use Qt5::

Re: Review Request 112046: reduce itmeviews test dependency

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112046/ --- (Updated Aug. 13, 2013, 9:31 a.m.) Review request for KDE Frameworks. De

Re: Review Request 112046: reduce itmeviews test dependency

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112046/#review37661 --- Ship it! Ship It! - Kevin Ottens On Aug. 13, 2013, 9:31 a.m

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111985/#review37660 --- Ship it! Ship It! - Kevin Ottens On Aug. 13, 2013, 8:50 a.m

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1021

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112046: reduce itmeviews test dependency

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112046/ --- Review request for KDE Frameworks. Description --- ItemViews use KIco

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111985/ --- (Updated Aug. 13, 2013, 8:50 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112032/#review37644 --- tier1/kwidgetsaddons/src/kpassivepopup.cpp

Re: Review Request 111916: Port khtml_part away from kde_file.h

> On Aug. 12, 2013, 2:43 p.m., Kevin Ottens wrote: > > khtml/khtml_part.cpp, line 3590 > > > > > > For extra safety I'd keep the "ok &&" here. > > David Faure wrote: > No, you want to enter this branch for b

Re: Review Request 111916: Port khtml_part away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review37643 --- Ship it! Ship It! - Kevin Ottens On Aug. 12, 2013, 10:15 a.

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review37641 --- kfile/kdirselectdialog.cpp