Re: Review Request 111943: Port to qplatformdefs.h: stat() and fopen() calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111943/#review37640 --- Ship it! Ship It! - Kevin Ottens On Aug. 12, 2013, 5:02 p.m

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

> On Aug. 9, 2013, 11:49 a.m., Kevin Ottens wrote: > > tier1/sonnet/src/ui/highlighter.cpp, line 237 > > > > > > I still don't see what the changes in this file have to do with the > > rest of the patch. Could yo

Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

> On Aug. 9, 2013, 8:34 p.m., David Faure wrote: > > The Qt patch is in for some time now, so we can use the new styleHint. > > > > However this patch should be updated to pass a pointer to the widget in the > > styleHint call. > > > > Once that's done, we can finally move KGlobalSettings to k

Re: Changing default in QToolBar::buttonStyle

On Monday 12 August 2013 18:06:41 Àlex Fiestas wrote: > Hi there > > One of the tasks that I'm working on is "Make QToolBar use KDE settings", > which include the buttonStyle. > > For those that don't know, the buttonStyle is whether the QToolButton > created by QToolBar will have text along side

Jenkins build is back to stable : plasma-framework_master_qt5 #578

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111916: Port khtml_part away from kde_file.h

> On Aug. 12, 2013, 2:43 p.m., Kevin Ottens wrote: > > khtml/khtml_part.cpp, line 3590 > > > > > > For extra safety I'd keep the "ok &&" here. No, you want to enter this branch for broken symlinks too. - David

Re: Review Request 111916: Port khtml_part away from kde_file.h

> On Aug. 12, 2013, 9:40 a.m., David Faure wrote: > > khtml/khtml_part.cpp, line 3580 > > > > > > Is this variable still used? > > Vishesh Handa wrote: > Yes. A couple of lines below - > > int

Re: Review Request 112038: Look for LibAttica where needed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/ --- (Updated Aug. 12, 2013, 8:48 p.m.) Review request for KDE Frameworks and S

Re: Review Request 112038: Look for LibAttica where needed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/ --- (Updated Aug. 12, 2013, 7:48 p.m.) Review request for KDE Frameworks and S

Jenkins build became unstable: plasma-framework_master_qt5 #577

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112037: Replace most instances of KFileDialog with QFileDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- Review request for KDE Frameworks. Description --- KFileDialog is dep

Re: Review Request 111943: Port to qplatformdefs.h: stat() and fopen() calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111943/ --- (Updated Aug. 12, 2013, 7:02 p.m.) Review request for KDE Frameworks. Ch

Build failed in Jenkins: kdelibs_frameworks_qt5 #1019

See Changes: [ervin+bluesystems] Remove the use of kde_file.h -- [...truncated 3977 lines...] Building CXX object staging/kguiaddons/tests/CMakeFiles/kcolorcollectiontest.dir/kcolorcollectiont

Build failed in Jenkins: kdelibs_frameworks_qt5 #1018

See Changes: [cgiboudeaux] One less warning -- [...truncated 3973 lines...] [ 40%] [ 40%] Building CXX object staging/ki18n/autotests/CMakeFiles/klocalizedstringtest.dir/klocalizedstringtest.c

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

> On Aug. 9, 2013, 1:49 p.m., Kevin Ottens wrote: > > tier1/sonnet/src/ui/highlighter.cpp, line 237 > > > > > > I still don't see what the changes in this file have to do with the > > rest of the patch. Could you

Changing default in QToolBar::buttonStyle

Hi there One of the tasks that I'm working on is "Make QToolBar use KDE settings", which include the buttonStyle. For those that don't know, the buttonStyle is whether the QToolButton created by QToolBar will have text along side, bottom, only text or no text at all. While Qt is prepared to up

Re: Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112032/ --- (Updated Aug. 12, 2013, 6:07 p.m.) Review request for KDE Frameworks. Ch

Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112032/ --- Review request for KDE Frameworks. Description --- Convert tier1/kwid

Build failed in Jenkins: kdelibs_frameworks_qt5 #1017

See Changes: [afiestas] Update QToolbBar's when KIconLoader::iconChanged is emit [hrvoje.senjan] Mark strigi as optional dependancy, move it's check to kde4support -- [...truncated 3876 lines

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111981/ --- (Updated Aug. 12, 2013, 3:13 p.m.) Status -- This change has been mar

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111981/#review37589 --- This review has been submitted with commit 3c7b01dd3baafeb2844

Re: Review Request 111906: Update QToolbar's when icon changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111906/ --- (Updated Aug. 12, 2013, 3:11 p.m.) Status -- This change has been mar

Re: Review Request 111906: Update QToolbar's when icon changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111906/#review37588 --- This review has been submitted with commit b4eb950ac3ddf241810

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111981/#review37587 --- Ship it! Ship It! - Kevin Ottens On Aug. 9, 2013, 9:32 p.m.

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

> On Aug. 12, 2013, 9:38 a.m., Kevin Ottens wrote: > > Hm, doesn't just removing FindStrigi.cmake make strigi completely > > impossible to find now? I see that extra-cmake-module still has FindStrigi > > in attic too. I find the patch overall ok except for that part... maybe > > that's just me

Re: Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111911/#review37585 --- Ship it! Ship It! - Kevin Ottens On Aug. 12, 2013, 10:16 a.

Re: Review Request 111916: Port khtml_part away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review37584 --- khtml/khtml_part.cpp

Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

> On Aug. 9, 2013, 8:34 p.m., David Faure wrote: > > The Qt patch is in for some time now, so we can use the new styleHint. > > > > However this patch should be updated to pass a pointer to the widget in the > > styleHint call. > > > > Once that's done, we can finally move KGlobalSettings to k

Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

> On Aug. 9, 2013, 8:34 p.m., David Faure wrote: > > The Qt patch is in for some time now, so we can use the new styleHint. > > > > However this patch should be updated to pass a pointer to the widget in the > > styleHint call. > > > > Once that's done, we can finally move KGlobalSettings to k

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

> On Aug. 12, 2013, 9:38 a.m., Kevin Ottens wrote: > > Hm, doesn't just removing FindStrigi.cmake make strigi completely > > impossible to find now? I see that extra-cmake-module still has FindStrigi > > in attic too. I find the patch overall ok except for that part... maybe > > that's just me

Re: Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111911/ --- (Updated Aug. 12, 2013, 10:16 a.m.) Review request for KDE Frameworks. C

Re: Review Request 111916: Port khtml_part away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/ --- (Updated Aug. 12, 2013, 10:15 a.m.) Review request for KDE Frameworks. C

Re: Review Request 111916: Port khtml_part away from kde_file.h

> On Aug. 12, 2013, 9:40 a.m., David Faure wrote: > > khtml/khtml_part.cpp, line 3580 > > > > > > Is this variable still used? Yes. A couple of lines below - int n = readlink ( path.toLocal8Bit().data(),

Re: Review Request 112025: Fix build on i386

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112025/#review37574 --- This review has been submitted with commit 6b6fe1a912f05284e0e

Re: Review Request 112025: Fix build on i386

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112025/ --- (Updated Aug. 12, 2013, 10:05 a.m.) Status -- This change has been ma

KF5 Update Meeting 2013-w33 Reminder

Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally si

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1014

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111916: Port khtml_part away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review37565 --- khtml/khtml_part.cpp

Re: Review Request 112025: Fix build on i386

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112025/#review37569 --- Ship it! Ship It! - Kevin Ottens On Aug. 12, 2013, 6:36 a.m

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111981/#review37567 --- Hm, doesn't just removing FindStrigi.cmake make strigi complete

Re: Review Request 111916: Port khtml_part away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/ --- (Updated Aug. 12, 2013, 9:35 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112007: Use KDE configured shortcuts for Qt default key bindings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112007/#review37564 --- Ship it! Ship It! - Kevin Ottens On Aug. 10, 2013, 11:12 p.

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111985/#review37562 --- tier2/kauth/src/CMakeLists.txt

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/#review37557 --- Ship it! Just pay attention to the issue I raised, but you can