Re: Review Request 112025: Fix build on i386

2013-08-11 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112025/ --- (Updated Aug. 12, 2013, 12:06 p.m.) Review request for KDE Frameworks. C

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

2013-08-11 Thread Vishesh Handa
> On Aug. 11, 2013, 8:06 a.m., Vishesh Handa wrote: > > I'm kinda confused. > > > > Strigi is still very much required by > > kde4support/src/kio/kfilemetainfo.cpp. The only reason this compiles is > > because Strigi is optional, but without it KFileMetaInfo will completely > > break. Certain

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

2013-08-11 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111981/#review37497 --- I'm kinda confused. Strigi is still very much required by kde4