Jenkins build became unstable: kdelibs_frameworks_qt5 #1012

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111979: Small cleanup of strigi/soprano/nepomuk leftovers in kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111979/ --- (Updated Aug. 9, 2013, 10:43 p.m.) Status -- This change has been mar

Re: Review Request 111979: Small cleanup of strigi/soprano/nepomuk leftovers in kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111979/#review37453 --- This review has been submitted with commit d3a05f22eddd5a77d53

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111981/ --- (Updated Aug. 9, 2013, 9:32 p.m.) Review request for KDE Frameworks. Cha

Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111985/ --- Review request for KDE Frameworks. Description --- Task from kdelibs

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111985/ --- (Updated Aug. 9, 2013, 8:48 p.m.) Review request for KDE Frameworks. Des

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1011

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109527/#review37451 --- The Qt patch is in for some time now, so we can use the new sty

Jenkins build became unstable: kdelibs_frameworks_qt5 #1010

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111981: Mark strigi as optional dependancy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111981/#review37449 --- The right fix is to remove all this stuff from the toplevel CMa

Re: Review Request 111979: Small cleanup of strigi/soprano/nepomuk leftovers in kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111979/#review37448 --- Ship it! Looks ok, if you make sure that all of this has moved

Re: kde_file.h vs POSIX headers vs qplatformdefs.h

On Thursday 08 August 2013 16:56:23 Aurélien Gâteau wrote: > Hi, > > I started working on a kdelibs cleanup task: > > "Make use of qplatformdefs.h definitions instead of using the POSIX versions > directly. Partly revert that commit, that would port to QFile::Permissions: > b03e81a61311ae1b64b0d3

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37445 --- tier1/kconfig/src/gui/kconfigloader.h

Re: Review Request 111916: Port khtml_part away from kde_file.h

> On Aug. 7, 2013, 4:12 p.m., David Faure wrote: > > This code should be made portable (to Windows), please use QFileInfo. > > Kevin Ottens wrote: > As far as I know the QT_* macros would work on windows too. Using > QFileInfo would be way nicer though. Depends on the "*". win32-msvc2005/

Review Request 111979: Small cleanup of strigi/soprano/nepomuk leftovers in kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111979/ --- Review request for KDE Frameworks. Description --- Follow up to r1118

Review Request 111981: Mark strigi as optional dependancy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111981/ --- Review request for KDE Frameworks. Description --- Follow up to r1118

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1009

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 #570

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.cpp, line 65 > > > > > > This would be best with use of QLatin1String() thoughout this file. > > > > > > Kai Uwe B

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.cpp, line 65 > > > > > > This would be best with use of QLatin1String() thoughout this file. > > > > QStringLitera

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.cpp, line 65 > > > > > > This would be best with use of QLatin1String() thoughout this file. > > > > > > Kai Uwe B

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37413 --- tier1/kconfig/src/gui/kconfigloader.cpp

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

> On Aug. 9, 2013, 2:36 p.m., Stephen Kelly wrote: > > Looks good to me. I'll let Kevin decide though. > > > > If Alex insists, the redundancy can always be added later. If we will have dependency graph generated from cmake with option --graphviz (probably Ben is working on it) it is better s

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/#review37428 --- Looks good to me. I'll let Kevin decide though. If Alex insis

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/ --- (Updated Aug. 9, 2013, 2:33 p.m.) Review request for KDE Frameworks. Cha

Build failed in Jenkins: kdelibs_frameworks_qt5 #1008

See Changes: [sebas] Introduce kservice_desktop_to_json() macro -- [...truncated 4013 lines...] [ 41%] Built target KI18n [ 41%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/

Re: Review Request 111877: desktop_to_json cmake macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/#review37418 --- This review has been submitted with commit 7dd76b3aa7c5dc12d8f

Re: Review Request 111877: desktop_to_json cmake macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/ --- (Updated Aug. 9, 2013, 1:07 p.m.) Status -- This change has been mark

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/#review37416 --- tier1/kconfig/src/gui/CMakeLists.txt

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 9, 2013, 2:38 p.m.) Review request for KDE Frameworks, Plasm

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

> On Aug. 9, 2013, 11:27 a.m., Kevin Ottens wrote: > > tier1/kconfig/src/gui/CMakeLists.txt, line 15 > > > > > > The LINK_PUBLIC is ok here, but is the Qt5::Core necessary? Doesn't it > > get picked up by transiti

Re: Review Request 111906: Update QToolbar's when icon changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111906/ --- (Updated Aug. 9, 2013, 12:08 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37410 --- tier1/kconfig/src/gui/kconfigloader.h

Re: Review Request 111877: desktop_to_json cmake macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/#review37409 --- Ship it! Ship It! - Kevin Ottens On Aug. 8, 2013, 10:26 p.m

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/#review37408 --- tier1/sonnet/src/ui/highlighter.cpp

Re: Review Request 111943: Port to qplatformdefs.h: stat() and fopen() calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111943/#review37407 --- To avoid overlapping on the kde_file.h porting work, don't port

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/#review37406 --- tier1/kconfig/src/gui/CMakeLists.txt

Build failed in Jenkins: kdelibs_frameworks_qt5 #1007

See Changes: [faure] fix build -- [...truncated 3975 lines...] [ 38%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/internetgateway.cpp.o [ 38%] Built target des