Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 4, 2013, 3:58 a.m.) Review request for KDE Frameworks and Da

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-03 Thread Sebastian Kügler
> On Aug. 3, 2013, 10:20 p.m., Milian Wolff wrote: > > staging/kservice/src/desktoptojson/kconfigtojson.h, line 37 > > > > > > why members? that's imo a "verschlimmbesserung". If at all, mark them > > as static co

Review Request 111877: desktop_to_json cmake macro

2013-08-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/ --- Review request for KDE Frameworks. Description --- This patch adds a

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-03 Thread Milian Wolff
> On Aug. 2, 2013, 9:08 a.m., David Faure wrote: > > staging/kservice/tools/desktoptojson/kconfigtojson.h, line 31 > > > > > > I don't like file-static QStrings (global objects), and even less in > > headers (it c

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-03 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review37039 --- staging/kservice/src/desktoptojson/kconfigtojson.h

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 3, 2013, 10:07 p.m.) Review request for KDE Frameworks and D

Jenkins build is back to stable : kdelibs_stable #741

2013-08-03 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111844: Port last use of NetAccess in kio

2013-08-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111844/ --- (Updated Aug. 3, 2013, 5:11 p.m.) Review request for KDE Frameworks and Da

Re: Ki18n mostly ready

2013-08-03 Thread Albert Astals Cid
El Divendres, 2 d'agost de 2013, a les 20:49:02, Kevin Ottens va escriure: > On Friday 02 August 2013 19:15:50 Albert Astals Cid wrote: > > El Divendres, 2 d'agost de 2013, a les 07:55:52, Kevin Ottens va escriure: > > > Well, the default has to make sense to someone who just makes a Qt > > > appli

Review Request 111857: Remove from kded.cpp

2013-08-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111857/ --- Review request for KDE Frameworks. Description --- Port kded.cpp away