Re: Review Request 111744: Get rid of kde_file.h in file kioslave + remove unused includes

2013-07-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111744/ --- (Updated July 27, 2013, 4:48 p.m.) Status -- This change has been mar

Re: Review Request 111744: Get rid of kde_file.h in file kioslave + remove unused includes

2013-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111744/#review36609 --- Ship it! Ship It! - David Faure On July 27, 2013, 4:25 p.m.

Review Request 111744: Get rid of kde_file.h in file kioslave + remove unused includes

2013-07-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111744/ --- Review request for KDE Frameworks. Description --- Removes kde_file.h

Re: Review Request 111724: Port file kioslave rename() to QFile

2013-07-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111724/ --- (Updated July 27, 2013, 4:19 p.m.) Status -- This change has been dis

Re: Review Request 111723: Port KNewPasswordDialog to KWidgetAddons

2013-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111723/#review36605 --- Looks good, just one question. kdeui/dialogs/knewpassworddial

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/#review36604 --- If kdelibs and plasma-framework compile (preferrably after remo

Re: Review Request 111724: Port file kioslave rename() to QFile

2013-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111724/#review36603 --- ::rename also is only for files on the same partition, so that'

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-27 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/ --- (Updated July 27, 2013, 2:42 p.m.) Review request for KDE Frameworks. Ch

Jenkins build became unstable: kdelibs_frameworks_qt5 #931

2013-07-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-27 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/ --- (Updated July 27, 2013, 1:04 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-07-27 Thread Martin Gräßlin
> On July 27, 2013, 9:52 a.m., David Faure wrote: > > tier1/kwindowsystem/src/kkeyserver_x11.h, line 170 > > > > > > The double semicolon isn't really useful :) I need to fix my kdevelop - that's the second time

Re: Review Request 111701: Port away from kde_file in KDirOperator (KFile)

2013-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111701/#review36585 --- kfile/kdiroperator.cpp

Re: Review Request 111675: Port away from kde_file in KRecentDocument (KIO)

2013-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/#review36584 --- kio/kfile/krecentdocument.cpp

Re: symbol lookup error in each application linking KDE4Support

2013-07-27 Thread David Faure
On Wednesday 24 July 2013 12:01:07 Martin Graesslin wrote: > Hi, > > when I try to run binaries which links KDE4Support (e.g. kdeinit5) I get the > following symbol lookup error: > > [...]lib/x86_64-linux-gnu/libKDE4Support.so.5: undefined symbol: > kde_kiosk_admin > > kde_kiosk_admin is used in

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/#review36578 --- Ship it! Looks good, just two small comments. tier1/kwindows