Re: Review Request 111678: Fix not found sonnet(core|ui)_export.h

2013-07-25 Thread Martin Gräßlin
> On July 25, 2013, 6:18 p.m., Alexander Neundorf wrote: > > Out of interest: was it obvious for you that you have to add some parameter > > to the generate_export_header() call or was it kind of hard to figure out > > where that header file is coming from ? figuring out where the file is comi

Build failed in Jenkins: kdelibs_frameworks_qt5 #918

2013-07-25 Thread KDE CI System
See Changes: [arichardson.kde] don't use a CMake variable set to NOTFOUND -- [...truncated 4117 lines...]

Re: Review Request 111701: Port away from kde_file in KDirOperator (KFile)

2013-07-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111701/ --- (Updated July 25, 2013, 9:45 p.m.) Review request for KDE Frameworks. Ch

Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-25 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/ --- Review request for KDE Frameworks. Description --- Is this enough?

Review Request 111701: Port away from kde_file in KDirOperator (KFile)

2013-07-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111701/ --- Review request for KDE Frameworks. Description --- Port away from kde

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-25 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/#review36505 --- staging/kservice/src/services/kplugininfo.cpp

Build failed in Jenkins: kdelibs_frameworks_qt5 #917

2013-07-25 Thread KDE CI System
See -- [...truncated 4175 lines...] [ 34%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevaudiointerface.cpp.o [ 34%] [ 34%] Building CXX object staging/knotifications

Build failed in Jenkins: kdelibs_frameworks_qt5 #916

2013-07-25 Thread KDE CI System
See Changes: [faure+bluesystems] this can be removed now [faure+bluesystems] actually look for x11extras [faure+bluesystems] fix link (xtest missing...) -- [...truncated 4247 lines...] Buildin

Build failed in Jenkins: kdelibs_frameworks_qt5 #915

2013-07-25 Thread KDE CI System
See Changes: [faure+bluesystems] find_package first, then use vars... [faure+bluesystems] it uses QX11Info -- [...truncated 4320 lines...] [ 38%] Building CXX object tier1/solid/src/solid/CMak

Build failed in Jenkins: kdelibs_frameworks_qt5 #914

2013-07-25 Thread KDE CI System
See Changes: [faure+bluesystems] kde4support: don't use config-kdeui.h [faure+bluesystems] HAVE_XTEST wasn't defined here [faure+bluesystems] Clean up unused configure checks in kdeui, now that a lot moved out [faure+bluesystems] d

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-07-25 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36503 --- staging/kservice/tools/desktoptojson/kconfigtojson.h

Jenkins build is back to normal : kdelibs_frameworks_qt5 #913

2013-07-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-07-25 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36501 --- staging/kservice/tools/desktoptojson/kconfigtojson.h

Build failed in Jenkins: kdelibs_frameworks_qt5 #912

2013-07-25 Thread KDE CI System
See Changes: [arichardson.kde] Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file -- [...truncated 4116 lines...] [ 32%] Building CXX object tier1/solid/src/solid/CMakeFiles/Soli

Re: Review Request 111649: Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file

2013-07-25 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/ --- (Updated July 25, 2013, 6:48 p.m.) Status -- This change has been mar

Re: Review Request 111686: KPluginFactory macros port

2013-07-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/#review36497 --- staging/kservice/src/plugin/kpluginfactory.h

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/#review36498 --- staging/kservice/src/services/kplugininfo.h

Re: cmake problems in KDELibs4Config

2013-07-25 Thread Alexander Neundorf
On Thursday 25 July 2013, Sebastian Kügler wrote: > Hi Alex, > > On Wednesday, July 24, 2013 22:27:46 Alexander Neundorf wrote: > > On Wednesday 24 July 2013, Alexander Neundorf wrote: > > > What to do... > > > > > > So, kde4support depends on a lot of stuff in kdelibs. > > > Some libs in kdelibs

Re: Review Request 111678: Fix not found sonnet(core|ui)_export.h

2013-07-25 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111678/#review36496 --- Out of interest: was it obvious for you that you have to add so

Re: Review Request 111686: KPluginFactory macros port

2013-07-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/ --- (Updated July 25, 2013, 4:10 p.m.) Review request for KDE Frameworks and D

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-07-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated July 25, 2013, 4:10 p.m.) Review request for KDE Frameworks and D

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated July 25, 2013, 4:10 p.m.) Review request for KDE Frameworks and D

Re: Review Request 111649: Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file

2013-07-25 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36495 --- Ship it! Looks good as far as I see. - Alexander Neundorf

Build failed in Jenkins: plasma-framework_master_qt5 #524

2013-07-25 Thread KDE CI System
See -- [...truncated 590 lines...] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kpluginfactory.h:31:0, from /srv/jenkins/install/

kdelibs-frameworks and plasma-framework back to normal

2013-07-25 Thread Kevin Ottens
Hello all, As you probably noticed we had some build issues for a couple of days, in particular plasma-framework couldn't build anymore. I just made pushes to kdelibs-framework, extra-cmake-modules and plasma-framework which should fix all the problems. It might take time for the CI to catch up

Build failed in Jenkins: plasma-framework_master_qt5 #523

2013-07-25 Thread KDE CI System
See Changes: [ervin] Pull in the KDE4Attic dependency -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 111680: Port macro_ensure_version in KDELibs4Config.cmake.in

2013-07-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111680/#review36478 --- This review has been submitted with commit 393f9a3d046ae318bc2

Re: Review Request 111678: Fix not found sonnet(core|ui)_export.h

2013-07-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111678/#review36479 --- This review has been submitted with commit e84396d3ae07f421327

Re: Review Request 111680: Port macro_ensure_version in KDELibs4Config.cmake.in

2013-07-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111680/ --- (Updated July 25, 2013, 12:38 p.m.) Status -- This change has been ma

Re: Review Request 111678: Fix not found sonnet(core|ui)_export.h

2013-07-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111678/ --- (Updated July 25, 2013, 12:38 p.m.) Status -- This change has been ma

Re: Review Request 111080: Macro*.cmake changes

2013-07-25 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111080/#review36474 --- experimental/CMakeLists.txt

Review Request 111680: Port macro_ensure_version in KDELibs4Config.cmake.in

2013-07-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111680/ --- Review request for KDE Frameworks. Description --- Allows to find KDE

Review Request 111678: Fix not found sonnet(core|ui)_export.h

2013-07-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111678/ --- Review request for KDE Frameworks. Description --- 0d5e8a432b7b633576