Re: Review Request 111649: Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/ --- (Updated July 25, 2013, 8:40 a.m.) Review request for KDE Frameworks. Ch

Re: cmake problems in KDELibs4Config

On Wednesday 24 July 2013 22:27:46 Alexander Neundorf wrote: > On Wednesday 24 July 2013, Alexander Neundorf wrote: > > If you add KDE4Attic to the list of known frameworks in > > extra-cmake-modules, and add it to the find_package(KF5 ) call as a > > needed component, it should work. > > No,

Build failed in Jenkins: plasma-framework_master_qt5 #522

See Changes: [mgraesslin] Adjust RunnerManager to new ThreadWeaver API using JobPointer -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave -

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/ --- (Updated July 25, 2013, 4:57 a.m.) Status -- This change has been mar

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/#review36469 --- This review has been submitted with commit 20b9d17e4c594765c19

Re: cmake problems in KDELibs4Config

Hi Alex, On Wednesday, July 24, 2013 22:27:46 Alexander Neundorf wrote: > On Wednesday 24 July 2013, Alexander Neundorf wrote: > > What to do... > > > > So, kde4support depends on a lot of stuff in kdelibs. > > Some libs in kdelibs still depend on kde4support (at least last week this > > still was

Review Request 111675: Port away from kde_file in KRecentDocument (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/ --- Review request for KDE Frameworks. Description --- Port away from kde

Re: cmake problems in KDELibs4Config

On Wednesday 24 July 2013, Alexander Neundorf wrote: > On Wednesday 24 July 2013, Sebastian Kügler wrote: > > Hi, > > > > I'm getting the following two errors when trying to build > > plasma-framework: > > > > macro_ensure_version doesn't exist anymore, but is used in > > KDELibs4Config.cmake. Is

Re: cmake problems in KDELibs4Config

On Wednesday 24 July 2013, Sebastian Kügler wrote: > Hi, > > I'm getting the following two errors when trying to build plasma-framework: > > macro_ensure_version doesn't exist anymore, but is used in > KDELibs4Config.cmake. Is there a replacement for it? Hopefully all such changes are documented

Build failed in Jenkins: kdelibs_frameworks_qt5 #910

See Changes: [davidgiloliva] Remove #include in classes that actually don't use it -- [...truncated 3929 lines...] [ 26%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces

Re: Review Request 111649: Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36463 --- Nice. Now that we have an all new file, we can make it really p

Re: Review Request 111644: Delete included kde_file.h actually not used

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111644/ --- (Updated July 24, 2013, 7:38 p.m.) Status -- This change has been mar

Re: Review Request 111644: Delete included kde_file.h actually not used

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111644/#review36462 --- This review has been submitted with commit 1b07a3657a14bb60dd4

Re: Review Request 111649: Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/ --- (Updated July 24, 2013, 9:26 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

> On July 23, 2013, 6:47 p.m., Alexander Neundorf wrote: > > What's the current state of dbusmenuqt ? > > Can it be built against both Qt4 and Qt5 ? > > If so, do they have different version numbers then ? > > I don't like that an old version of FindDBusMenuQt.cmake will find the Qt4 > > version

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/#review36454 --- Ship it! Ship It! - Aaron J. Seigo On July 23, 2013, 11:23

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > > > > > > Should be "const QString &" > > David Gil Oliva wrote: > I think you didn't notice something import

Re: Review Request 111644: Delete included kde_file.h actually not used

> On July 22, 2013, 8:42 p.m., David Faure wrote: > > Trivial enough. If it builds, it's correct. > > Kevin Ottens wrote: > That said, it needs 111636 to be in first. > > David Gil Oliva wrote: > Kevin, I'm surprised, I don't see the connection with #111636. I have > written this patch

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > > > > > > Should be "const QString &" > > David Gil Oliva wrote: > I think you didn't notice something import

Re: Review Request 111644: Delete included kde_file.h actually not used

> On July 22, 2013, 8:42 p.m., David Faure wrote: > > Trivial enough. If it builds, it's correct. > > Kevin Ottens wrote: > That said, it needs 111636 to be in first. > > David Gil Oliva wrote: > Kevin, I'm surprised, I don't see the connection with #111636. I have > written this patch

Build failed in Jenkins: kdelibs_frameworks_qt5 #909

See Changes: [faure+bluesystems] Add missing file, sorry. -- [...truncated 3925 lines...] :39:5: w

Build failed in Jenkins: kdelibs_frameworks_qt5 #908

See Changes: [faure+bluesystems] Move thumb*creator to kio_widgets (used by kio_thumbnail plugins) [faure+bluesystems] More pixmap things in kio_widgets [faure+bluesystems] Move KFileItemListProperties to KIOCore. There's always one

Build failed in Jenkins: kdelibs_frameworks_qt5 #907

See Changes: [arichardson.kde] Use correct path for including export headers -- [...truncated 703 lines...] The keyword signature for target_link_libraries has already been used with the tar

Re: Review Request 111584: Use correct path for including export headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111584/#review36433 --- This review has been submitted with commit 0d5e8a432b7b6335769

Re: Review Request 111584: Use correct path for including export headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111584/ --- (Updated July 24, 2013, 9:07 a.m.) Status -- This change has been mar

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

> On July 24, 2013, 9:43 a.m., Kevin Ottens wrote: > > Ah, I wasn't sure what you meant. I can easily fix this, or should I add a FindDBusMenuQt5.cmake as Alex Neundorf suggested? - Alexander --- This is an automatically generated e-ma

Re: Review Request 110842: Add reviewboardrc file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110842/ --- (Updated July 24, 2013, 8:19 a.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #906

See Changes: [faure+bluesystems] Provide LINK_PUBLIC/LINK_PRIVATE for kiocore. Remove temporary export. [faure+bluesystems] Move the first set of classes to kiowidgets [faure+bluesystems] Move KIO::PasswordDialog (deprecated since 2

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36431 --- cmake/modules/FindDBusMenuQt.cmake

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/#review36430 --- Looks good overall, I still think a typedef for QSharedPointer

Re: Review Request 111584: Use correct path for including export headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111584/#review36429 --- Ship it! Ship It! - Kevin Ottens On July 23, 2013, 10:38 a.