Re: Using target names directly vs. variables

2013-07-14 Thread Alexander Neundorf
On Sunday 14 July 2013, David Faure wrote: > On Sunday 14 July 2013 11:42:26 Alexander Neundorf wrote: > > A good step forward to improve the experience for the user is to follow > > those naming conventions as good as possible, so that if you do > > > > find_package(WhatEverItIs) > > > > you kno

Build failed in Jenkins: plasma-framework_master_qt5 #506

2013-07-14 Thread KDE CI System
See -- [...truncated 266 lines...] :0: Note: No relevant classes found. No output generated. Gen

Re: Using target names directly vs. variables

2013-07-14 Thread David Faure
On Sunday 14 July 2013 11:42:26 Alexander Neundorf wrote: > A good step forward to improve the experience for the user is to follow > those naming conventions as good as possible, so that if you do > > find_package(WhatEverItIs) > > you know, that you can use ${WhateEverItIs_LIBRARIES} and > ${Wh

Build failed in Jenkins: plasma-framework_master_qt5 #505

2013-07-14 Thread KDE CI System
See Changes: [benjamin.port] Update CMakeLists in order to take in consideration KDE Frameworks target name change. -- [...truncated 591 lines...] from /srv/jenkins/insta

Jenkins build is back to normal : kdelibs_frameworks_qt5 #848

2013-07-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #846

2013-07-14 Thread KDE CI System
See Changes: [faure+bluesystems] Move kio jobs, scheduler, slave, etc. to kiocore. [faure+bluesystems] Call messageBox API through the JobUiDelegateExtension -- [...truncated 27938 lines...] --

Jenkins build is back to normal : kdelibs_frameworks_qt5 #842

2013-07-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #841

2013-07-14 Thread KDE CI System
See Changes: [faure+bluesystems] Move KMountPoint to KIO core (for now) -- [...truncated 500 lines...] -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x64_64/g++/qt5/kdesuppor

Re: Review Request 111491: Rename kde4support framework to KDE4Support

2013-07-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111491/ --- (Updated July 14, 2013, 11 a.m.) Status -- This change has been marke

Re: Review Request 111491: Rename kde4support framework to KDE4Support

2013-07-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111491/#review35931 --- This review has been submitted with commit fa8d82a86fb1fc7999d

Re: Review Request 111491: Rename kde4support framework to KDE4Support

2013-07-14 Thread Alexander Neundorf
On Saturday 13 July 2013, Kevin Ottens wrote: > > On July 12, 2013, 8:02 p.m., Alexander Neundorf wrote: > > > Thanks for working on this. > > > > > > One more thing: maybe, instead of using the new target name KDE4Support > > > everywhere directly, ${KDE4Support_LIBRARIES} could be used already >

Using target names directly vs. variables

2013-07-14 Thread Alexander Neundorf
Hi, in CMake, to link against a target, you use its target name: target_link_libraries(hello mylib) That's what we do in kdelibs, and this is fine. In CMake, to make use of an external package, you use find_package(), and then use the variables it provides, as documented in readme.txt and find

Re: Review Request 111456: Create KCrash framework

2013-07-14 Thread David Faure
On Saturday 13 July 2013 13:32:51 Stefanie Dargel wrote: > unfortunally KCrash causes kdelibs-frameworks to fail for me when build from > scratch with kdesrc-build due to a cmake error: > > CMake Error at > KDE/KF5/inst/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:10 > 8 (message):