Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

2013-07-10 Thread Thomas Lübking
> On June 3, 2013, 9:59 a.m., David Faure wrote: > > For the record, this is waiting for an updated version of > > https://codereview.qt-project.org/#change,51166 > > Kevin Ottens wrote: > Which is still not seeing any activity... Alex do you need help there? That patch really needs to sen

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111424/ --- (Updated July 10, 2013, 10:36 p.m.) Review request for KDE Frameworks. D

Re: Review Request 111456: Create KCrash framework

2013-07-10 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111456/ --- (Updated July 10, 2013, 7:02 p.m.) Review request for KDE Frameworks. De

Re: Review Request 111456: Create KCrash framework

2013-07-10 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111456/ --- (Updated July 10, 2013, 6:54 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 8:44 p.m.) Review request for KDE Frameworks. Ch

Re: KIO progress towards tier 1 framework?

2013-07-10 Thread Kevin Ottens
On Wednesday 10 July 2013 13:30:17 Chusslove Illich wrote: > > [: Kevin Ottens :] > > For locale it should be QLocale really. KLocale is likely to disappear at > > some point. QLocale might not fulfill all your needs yet, but we'd need to > > know what you miss sooner than later. > > I don't have

Re: KIO progress towards tier 1 framework?

2013-07-10 Thread Chusslove Illich
> [: Kevin Ottens :] > [ki18n not being tier 1] Means the set of frameworks which will use ki18n > will be reduced though. Maybe not a big deal, our needs for advanced i18n > features are likely not as high there than in applications (I'm unsure > about that statement honestly). I'm not terribly c

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35834 --- This review has been submitted with commit 977d43a86fc9d0f8bf1

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated July 10, 2013, 10:41 a.m.) Status -- This change has been ma

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35835 --- This review has been submitted with commit bd12932aaf7fcb191cf

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review35833 --- Ship it! kioslave/file/file.cpp

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated July 10, 2013, 9:55 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Martin Klapetek
> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, th

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 11:48 a.m.) Review request for KDE Frameworks. D

Re: Review Request 111456: Create KCrash framework

2013-07-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111456/#review35828 --- kdeui/util/kcrash.h

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread David Faure
> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, th

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread Martin Klapetek
> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, th

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/#review35826 --- Only style nitpicks I didn't spot the last time. Since it can't

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-10 Thread Kevin Ottens
> On July 8, 2013, 11:19 a.m., Kevin Ottens wrote: > > khtml/khtml_settings.cpp, line 30 > > > > > > Huh? Shouldn't be needed anymore. > > Aleix Pol Gonzalez wrote: > It's needed for KDE_DEFAULT_CHANGECURSOR.

Re: KIO progress towards tier 1 framework?

2013-07-10 Thread Kevin Ottens
On Wednesday 10 July 2013 10:05:33 Oswald Buddenhagen wrote: > On Wed, Jul 10, 2013 at 10:01:15AM +0200, Kevin Ottens wrote: > > On Tuesday 02 July 2013 23:18:59 Stephen Kelly wrote: > > > Note that QtScript can't be loaded in a plugin, so using it in > > > KTranscript > > > > > > relies on that c

Re: KF5 Update Meeting Minutes 2013-w27

2013-07-10 Thread Kevin Ottens
On Tuesday 02 July 2013 21:37:03 Alexander Neundorf wrote: > Another question: the libraries as they are now in tier1/ and staging/ are > partly really tiny. kinterprocesswindowing consists of 2 cpp files, > kplotting is 4 cpp files. > > Isn't that a bit too fine grained ? As Sune pointed out we

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 10, 2013, 10:08 a.m.) Review request for KDE Frameworks. D

Re: KIO progress towards tier 1 framework?

2013-07-10 Thread Kevin Ottens
Hello, On Tuesday 02 July 2013 22:06:20 Chusslove Illich wrote: > > [: Kevin Ottens :] > > Note that apparently there's no interest from the maintainer in making > > ki18n tier1 (ktranscript plugin being part of it and depending on kjs)... > > Which would make KIO tier3. You might want either to d

Re: KIO progress towards tier 1 framework?

2013-07-10 Thread Oswald Buddenhagen
On Wed, Jul 10, 2013 at 10:01:15AM +0200, Kevin Ottens wrote: > On Tuesday 02 July 2013 23:18:59 Stephen Kelly wrote: > > Note that QtScript can't be loaded in a plugin, so using it in KTranscript > > relies on that changing anyway: > > > > https://bugs.webkit.org/show_bug.cgi?id=38193 > > Is it

Re: KIO progress towards tier 1 framework?

2013-07-10 Thread Kevin Ottens
On Tuesday 02 July 2013 23:18:59 Stephen Kelly wrote: > Note that QtScript can't be loaded in a plugin, so using it in KTranscript > relies on that changing anyway: > > https://bugs.webkit.org/show_bug.cgi?id=38193 Is it still true with Qt5? I thought they switched away from JavaScriptCore to u

Re: Review Request 110988: Port kio-file to QFile

2013-07-10 Thread David Faure
> On July 9, 2013, 9:39 p.m., David Faure wrote: > > kioslave/file/file.cpp, line 476 > > > > > > coding style: no spaces inside parenthesis (same in a few other places). > > Martin Klapetek wrote: > Fwiw, th