Re: Review Request 111385: Port time_t to QDateTime in a couple of files

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111385/ --- (Updated July 5, 2013, 10:56 p.m.) Status -- This change has been mar

Re: Review Request 111385: Port time_t to QDateTime in a couple of files

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111385/#review35651 --- This review has been submitted with commit 8c145711f4f261cdb6d

Re: Review Request 110840: Move KFontComboBox to KDE4Support

2013-07-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110840/ --- (Updated July 5, 2013, 7:40 p.m.) Review request for KDE Frameworks. Cha

Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/ --- Review request for KDE Frameworks. Description --- Finally my patch i

Review Request 111408: Move KConfigDialogManager to KConfigWidgets

2013-07-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111408/ --- Review request for KDE Frameworks. Description --- Moved the class, o

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35644 --- This review has been submitted with commit 2dcb46a0334c6c0ceb2

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:54 p.m.) Status -- This change has been mark

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35643 --- Ship it! Looks good to me. Just add "inactive" / "active" in t

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35642 --- kdeui/util/kglobalsettings.h

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35641 --- So, changes in .cpp reverted, deprecated messages improved and

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:32 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:28 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:28 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

2013-07-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:24 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-07-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:24 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/#review35640 --- OK, so now it builds. Next step, fixing the crashes. You gave

Build failed in Jenkins: kdelibs_frameworks_qt5 #804

2013-07-05 Thread KDE CI System
See Changes: [aleixpol] Move KGlobalSettings::createApplicationPalette to KColorScheme -- [...truncated 15781 lines...]

Re: Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/ --- (Updated July 5, 2013, 3:35 p.m.) Status -- This change has been mark

Re: Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/#review35638 --- This review has been submitted with commit 2bc7b4accfc6daf9ac8

Re: Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread Aleix Pol Gonzalez
> On July 5, 2013, 3:06 p.m., David Faure wrote: > > staging/kwidgets/src/utils/kcolorscheme.h, line 433 > > > > > > Remove this comment, it only applied to one of the two overloads. > > > > We are callin

Build failed in Jenkins: kdelibs_stable #676

2013-07-05 Thread KDE CI System
See Changes: [faure] Tired of the random failures from this test, disabling it. -- [...truncated 7931 lines...] [ 32%] Building CXX object kdeui/CMakeFiles/kdeui.dir/util/kpixmapcache.o [ 32%] Building

Re: Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/#review35636 --- Ship it! Well done for not listening to my suggestion :-). Ind

Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

2013-07-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111405/ --- Review request for KDE Frameworks. Description --- We want to depreca

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 5, 2013, 3:27 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 5, 2013, 2:57 p.m.) Review request for KDE Frameworks. Cha

Re: linking to kde4support (Re: KF5 Update Meeting Minutes 2013-w27)

2013-07-05 Thread Alex Merry
On 04/07/13 22:44, David Faure wrote: > diff --git a/src/plasmapkg/CMakeLists.txt b/src/plasmapkg/CMakeLists.txt > index d2f2427..919dd64 100644 > --- a/src/plasmapkg/CMakeLists.txt > +++ b/src/plasmapkg/CMakeLists.txt > @@ -5,7 +5,7 @@ add_executable(plasmapkg > plasmapkg.cpp > ) > > -targ

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 5, 2013, 12:28 p.m.) Review request for KDE Frameworks. De

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

2013-07-05 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 5, 2013, 12:16 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/ --- (Updated July 5, 2013, 7:53 a.m.) Status -- This change has been mark

Re: Review Request 110858: Cleanup KDE development scripts

2013-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/#review35614 --- This review has been submitted with commit 002eac6f43489b8e3c1