KF5 Update Meeting Reminder

2013-07-01 Thread Kevin Ottens
Hello all, I forgot to send it yesterday, so just a quick reminder: The next KF5 Update Meeting will happen *today* at *4pm* Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: Thi

Review Request 111353: Port time_t to QDateTime in kdirwatch_unittest.cpp

2013-07-01 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111353/ --- Review request for KDE Frameworks. Description --- Port time_t to QDa

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-01 Thread David Faure
> On July 1, 2013, 8:01 p.m., David Gil Oliva wrote: > > staging/kwidgets/src/urlhandler.cpp, line 59 > > > > > > const QString& dir -> const QString &dir > > > > From the kdelibs coding style: > > http:/

Re: Review Request 111301: Port time_t to QDateTime in http_cache_cleaner.cpp

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111301/#review35404 --- This review has been submitted with commit 383c2c1daf35435180e

Re: Review Request 111246: Port time_t to QDateTime in Ftp (kioslave)

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111246/ --- (Updated July 1, 2013, 8:19 p.m.) Status -- This change has been mark

Re: Review Request 111246: Port time_t to QDateTime in Ftp (kioslave)

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111246/#review35405 --- This review has been submitted with commit 4a0dcae9920d2a8dc73

Re: Review Request 111301: Port time_t to QDateTime in http_cache_cleaner.cpp

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111301/ --- (Updated July 1, 2013, 8:17 p.m.) Status -- This change has been mark

Re: Review Request 111320: Port time_t to QDateTime in KHTMLPart (KIO)

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111320/#review35403 --- This review has been submitted with commit f6f30bd7cd56696d094

Re: Review Request 111320: Port time_t to QDateTime in KHTMLPart (KIO)

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111320/ --- (Updated July 1, 2013, 8:14 p.m.) Status -- This change has been mark

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-01 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/#review35401 --- staging/kwidgets/src/urlhandler.cpp

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-07-01 Thread Thomas Lübking
> On July 1, 2013, 2:39 p.m., Kevin Ottens wrote: > > kdeui/util/kglobalsettings.h, line 265 > > > > > > I think it's fine. lxr.kde.org seem to indicate that those colors got > > abused at some places anyway, and

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/#review35386 --- staging/kwidgets/src/CMakeLists.txt

Re: Review Request 111348: Don't require KApplication for using KGlobalSettings

2013-07-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111348/#review35380 --- Veto. This ignores the history behind activate(). Commit log h

Review Request 111348: Don't require KApplication for using KGlobalSettings

2013-07-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111348/ --- Review request for KDE Frameworks. Description --- Initialize it when

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/ --- (Updated July 1, 2013, 5:13 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111319: Move kmessagewidget to kwidgetsaddons

2013-07-01 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111319/ --- (Updated July 1, 2013, 4:16 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111319: Move kmessagewidget to kwidgetsaddons

2013-07-01 Thread Romário Rios
> On July 1, 2013, 3:08 p.m., Kevin Ottens wrote: > > tier1/kwidgetsaddons/src/kmessagewidget.cpp, line 90 > > > > > > Could be changed to "Close this message" I guess. "Close document" has > > always been weird i

Re: Review Request 111319: Move kmessagewidget to kwidgetsaddons

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111319/#review35367 --- tier1/kwidgetsaddons/src/kmessagewidget.cpp

Re: Review Request 111285: reduce KCompletion test dependency

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111285/#review35361 --- This review has been submitted with commit d3d7c5639ad15172302

Re: Review Request 111320: Port time_t to QDateTime in KHTMLPart (KIO)

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111320/#review35360 --- Ship it! Ship It! - Kevin Ottens On June 29, 2013, 10:16 p.

Re: Review Request 111270: move kmodifierkeyinfo to KGuiAddons framework

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111270/ --- (Updated July 1, 2013, 2:49 p.m.) Status -- This change has been mark

Re: Review Request 111270: move kmodifierkeyinfo to KGuiAddons framework

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111270/#review35362 --- This review has been submitted with commit ed56cf2431a6cdfdfe1

Re: Review Request 111184: Url drop functionality in KUrlRequester does not depend on KLineEdit (since we have to port it to QLineEdit)

2013-07-01 Thread Kevin Ottens
> On June 25, 2013, 6:46 a.m., Kevin Ottens wrote: > > kio/kfile/kurlrequester.cpp, line 483 > > > > > > Why don't you use KUrlMimeData like the original code in KLineEdit? > > It'll be more robust AFAICT. > > A

Re: Review Request 111285: reduce KCompletion test dependency

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111285/ --- (Updated July 1, 2013, 2:49 p.m.) Status -- This change has been mark

Re: Review Request 111301: Port time_t to QDateTime in http_cache_cleaner.cpp

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111301/#review35359 --- Ship it! Ship It! - Kevin Ottens On June 28, 2013, 5:41 p.m

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35358 --- kdeui/util/kglobalsettings.h

Re: Review Request 111246: Port time_t to QDateTime in Ftp (kioslave)

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111246/#review35356 --- Ship it! Ship It! - Kevin Ottens On June 27, 2013, 9:45 p.m

Re: Review Request 111270: move kmodifierkeyinfo to KGuiAddons framework

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111270/#review35355 --- Note that a second patch to solve the TODO in the CMakeLists.tx

Re: Review Request 111270: move kmodifierkeyinfo to KGuiAddons framework

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111270/#review35354 --- Ship it! Ship It! - Kevin Ottens On June 27, 2013, 9:22 p.m

Re: Review Request 111285: reduce KCompletion test dependency

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111285/#review35353 --- Ship it! Ship It! - Kevin Ottens On June 27, 2013, 9:17 p.m

Re: DataEngine & KPluginFactory

2013-07-01 Thread Sebastian Kügler
On Monday, July 01, 2013 14:35:51 Kevin Krammer wrote: > > Well, the goal, for me, is to make plugin factories work. Right now, we > > only have a handful constructor, and I want to make it possible to build > > those with as little extra hassle as possible -- it means porting all > > plugins, and

Re: DataEngine & KPluginFactory

2013-07-01 Thread Kevin Krammer
On Monday, 2013-07-01, Sebastian Kügler wrote: > On Monday, July 01, 2013 13:35:27 Kevin Krammer wrote: > > On Monday, 2013-07-01, Sebastian Kügler wrote: > > > On Monday, July 01, 2013 09:03:29 Kevin Krammer wrote: > > > > What if the macro only creates the header content (as its name > > > > alre

Re: e-c-m now installs into non-versioned directory

2013-07-01 Thread David Faure
Le vendredi 28 juin 2013 23:27:13 Alexander Neundorf a écrit : > Hi, > > I just increased the version of e-c- to 0.0.9 and it now installs simply > into share/ECM/ instead share/ECM-0.0.9/. Thank you, thank you, thank you! > You don't have to update it yet, but if you want to see whether this wo

Re: DataEngine & KPluginFactory

2013-07-01 Thread Sebastian Kügler
On Monday, July 01, 2013 13:35:27 Kevin Krammer wrote: > On Monday, 2013-07-01, Sebastian Kügler wrote: > > On Monday, July 01, 2013 09:03:29 Kevin Krammer wrote: > > > What if the macro only creates the header content (as its name already > > > suggests)? > > > > > > name::create() could then be i

Re: DataEngine & KPluginFactory

2013-07-01 Thread Kevin Krammer
On Monday, 2013-07-01, Sebastian Kügler wrote: > On Monday, July 01, 2013 09:03:29 Kevin Krammer wrote: > > What if the macro only creates the header content (as its name already > > suggests)? > > > > name::create() could then be implemented in a plugin specific way, not > > requiring a certain

Re: DataEngine & KPluginFactory

2013-07-01 Thread Sebastian Kügler
On Monday, July 01, 2013 09:03:29 Kevin Krammer wrote: > On Monday, 2013-07-01, Sebastian Kügler wrote: > > Open questions: > > > > > > - KPart and QWidget create* calls: In my current patch, these are simply > > > > ignored. > > I'm getting away with one overridden function in our > > macro

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/#review35340 --- Cool. No testing, though? staging/frameworkintegration/src/in

Re: DataEngine & KPluginFactory

2013-07-01 Thread Kevin Krammer
On Monday, 2013-07-01, Sebastian Kügler wrote: > Open questions: > > - KPart and QWidget create* calls: In my current patch, these are simply > ignored. > I'm getting away with one overridden function in our > macro-generated KPluginFactory subclass, it all seems to boil down to > >