Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35085 --- OK, reexamining that review again... The "move the settings to

Review Request 111246: Port time_t to QDateTime in Ftp (kioslave)

2013-06-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111246/ --- Review request for KDE Frameworks. Description --- Port time_t to QDa

Re: Review Request 110988: Port kio-file to QFile

2013-06-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- (Updated June 25, 2013, 8:08 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- (Updated June 25, 2013, 5:12 p.m.) Status -- This change has been mar

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review35067 --- This review has been submitted with commit 131ea56cdbe336ab5f9

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/78/ --- (Updated June 25, 2013, 4:19 p.m.) Review request for KDE Frameworks. Ch

KF5 Update Meeting Minutes 2013-w26

2013-06-25 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 26 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, apol, ben2367, fregl, scarpino, wojtask9 and myself. Topics discussed: * Barcelona's mini-sprint was a success, should be done in sync with Toulous

Re: Review Request 111184: Url drop functionality in KUrlRequester does not depend on KLineEdit (since we have to port it to QLineEdit)

2013-06-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/84/#review35051 --- KDE5PORTING.html

Re: DataEngine & KPluginFactory

2013-06-25 Thread Sebastian Kügler
Hi David, On Tuesday, June 25, 2013 12:39:08 David Faure wrote: > > Ignoring our home-made deprecation warning, it seems KPlugin* is still > > working. > > Clearly I did too good a job with the hack in the macro. It works so people > want to keep that hack > > The problem is that it again creat

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-25 Thread Chusslove Illich
> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv

Review Request 111236: move kcombobox and khistorycombobox to KCompletion framework.

2013-06-25 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111236/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Descripti

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-25 Thread Aleix Pol Gonzalez
> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv

Re: Review Request 111184: Url drop functionality in KUrlRequester does not depend on KLineEdit (since we have to port it to QLineEdit)

2013-06-25 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/84/ --- (Updated June 25, 2013, 10:46 a.m.) Review request for KDE Frameworks. D

Re: Review Request 111184: Url drop functionality in KUrlRequester does not depend on KLineEdit (since we have to port it to QLineEdit)

2013-06-25 Thread Albert Vaca Cintora
> On June 25, 2013, 6:46 a.m., Kevin Ottens wrote: > > kio/kfile/kurlrequester.cpp, line 483 > > > > > > Why don't you use KUrlMimeData like the original code in KLineEdit? > > It'll be more robust AFAICT. I'm u

Re: DataEngine & KPluginFactory

2013-06-25 Thread David Faure
Le lundi 24 juin 2013 12:48:55 Sebastian Kügler a écrit : > Hey, > > As you know, I'm looking into what's needed for proper plugin support in > KF5, trying to understand what's going on, and at least making our KDE4 > solution work for KF5. Qt's native plugin functionality is clearly lacking > for

Review Request 111232: move klineedit and kcompletionbox to KCompletion framework

2013-06-25 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111232/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Descripti

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-25 Thread Chusslove Illich
> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-25 Thread Aleix Pol Gonzalez
> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv

Jenkins build is back to normal : kdelibs_frameworks_qt5 #758

2013-06-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #757

2013-06-25 Thread KDE CI System
See Changes: [neoclust] Move kdoctool into staging -- [...truncated 3954 lines...] Linking CXX shared library libKNotifications.so [ 30%] Building CXX object tier1/solid/src/solid/CMakeFiles/So

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-25 Thread Albert Astals Cid
> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-25 Thread Kevin Ottens
> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-25 Thread Aurélien Gâteau
> On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-25 Thread Albert Astals Cid
> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv