Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-18 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/#review34647 --- kdeui/util/kwallet.h

Re: Review Request 111106: Fix export marco in kde4support

2013-06-18 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/#review34644 --- Ship it! Ship It! - Kevin Ottens On June 18, 2013, 9:38 p.m

Re: Review Request 111103: KPage* belongs to KWidgetsAddons

2013-06-18 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/#review34643 --- Ship it! Ship It! - Kevin Ottens On June 18, 2013, 5:32 p.m

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-18 Thread Kevin Ottens
> On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: > > kio/tests/jobtest.cpp, line 264 > > > > > > Do we agree that the goal is that both uiDelegate() and > > interactionInterface() will return 0 if you link only

Re: KGlobalSettings move to kde4support

2013-06-18 Thread Kevin Ottens
Hello, On Tuesday 18 June 2013 20:00:40 Aleix Pol wrote: > I added theme here [1]. Can you take a look and see if it's what you > expected? :) Mostly good, I adjusted just a bit. I also removed the tasks which were "deprecate" only. The whole class will get deprecated when moving in kde4support

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-18 Thread Kevin Ottens
On Tuesday 18 June 2013 20:34:31 Anne-Marie Mahfouf wrote: > I won't be able to redo my patch for > https://git.reviewboard.kde.org/r/110907/ because my laptop has a power > supply problem and I won't be able to accede to my KF5 build for some time. > So it's free for someone to pick it up. > > So

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-18 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/#review34636 --- hmmm strange. kwallettest is unit test but was in manual tests

Jenkins build became unstable: kdelibs_frameworks_qt5 #737

2013-06-18 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)

2013-06-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/ --- (Updated June 18, 2013, 11:26 p.m.) Status -- This change has been ma

Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)

2013-06-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/#review34631 --- Ship it! Ship It! - David Faure On June 18, 2013, 9:35 p.m.

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-18 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- (Updated June 18, 2013, 10:38 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 111106: Fix export marco in kde4support

2013-06-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/#review34625 --- Ship it! Cleaning up! ^^ good stuff - Aleix Pol Gonzalez On

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/#review34624 --- Please create the patch with --find-copies-harder argument. It

Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-18 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/05/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Descripti

Review Request 111106: Fix export marco in kde4support

2013-06-18 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/06/ --- Review request for KDE Frameworks. Description --- Lot of files still

Re: Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)

2013-06-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/ --- (Updated June 18, 2013, 9:35 p.m.) Review request for KDE Frameworks. Ch

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-18 Thread Anne-Marie Mahfouf
Hi, I won't be able to redo my patch for https://git.reviewboard.kde.org/r/110907/ because my laptop has a power supply problem and I won't be able to accede to my KF5 build for some time. So it's free for someone to pick it up. Sorry about that, best regards, Anne-Marie - Mail original -

Re: KGlobalSettings move to kde4support

2013-06-18 Thread Aleix Pol
On Tue, Jun 18, 2013 at 8:14 AM, Kevin Ottens wrote: > Hello, > > On Monday 17 June 2013 19:43:33 Aleix Pol wrote: > > So I was looking at KGlobalSettings to see what we need to do to finally > > deprecate all KGlobalSettings, as suggested by the required kdelibs > > cleanups. > > Ah good, it was

Review Request 111103: KPage* belongs to KWidgetsAddons

2013-06-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/03/ --- Review request for KDE Frameworks. Description --- When I moved KPage

Re: Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-18 Thread David Faure
> On June 18, 2013, 2:06 p.m., Kevin Ottens wrote: > > kio/kio/job.cpp, line 209 > > > > > > Interesting... So not having the uiDelegate() but the > > interactionInterface() qualify as interactive... Not sure if

Re: KGlobalSettings move to kde4support

2013-06-18 Thread Aleix Pol
On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote: > On 2013-06-18 03:10, Dominik Haumann wrote: > >> On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: >> >>> On Monday 17 June 2013 19:43:33 Aleix Pol wrote: >>> So I was looking at KGlobalSettings to see what we need to do to finall

Re: KGlobalSettings move to kde4support

2013-06-18 Thread Matthew Woehlke
On 2013-06-18 03:10, Dominik Haumann wrote: On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanu

KF5 Update Meeting Minutes 2013-w25

2013-06-18 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 25 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Announcements: * Tomorrow no new patch should be started, instead we get all the pending ones integrated so that dfaure can do a merge on thursday morning; * On June 22nd

Re: Review Request 111028: Move kkeyserver* to KWindowsSystem

2013-06-18 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/ --- (Updated June 18, 2013, 2:31 p.m.) Status -- This change has been mar

Re: Review Request 111086: Move KXErrorHandler

2013-06-18 Thread Kevin Ottens
> On June 18, 2013, 1:48 p.m., Kevin Ottens wrote: > > Ship It! Hold on... Per Fredrik Höglund email which I totally overlooked until now, we're clearly doing that one wrong. Please rework this patch so that kwindowsystem is untouched but the kdeui copy of kxerrorhandler goes in kde4support in

Re: Review Request 111086: Move KXErrorHandler

2013-06-18 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111086/#review34575 --- Ship it! Ship It! - Kevin Ottens On June 18, 2013, 10:51 a.

Re: Review Request 111028: Move kkeyserver* to KWindowsSystem

2013-06-18 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/#review34572 --- Ship it! Ship It! - Kevin Ottens On June 17, 2013, 10:34 a.

Review Request 111090: Deprecate kdeui/widgets/kstringvalidator.* and kio/kfile/kfilemetainfowidget.*

2013-06-18 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111090/ --- Review request for KDE Frameworks and kdelibs. Description --- Since,

Review Request 111086: Move KXErrorHandler

2013-06-18 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111086/ --- Review request for KDE Frameworks. Description --- Finish to moving K

Jenkins build is back to stable : kdelibs_frameworks_qt5 #732

2013-06-18 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111081: KIO::Job: more core/gui splitup.

2013-06-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111081/ --- Review request for KDE Frameworks. Description --- KIO::Job: more cor

Re: Re: KGlobalSettings move to kde4support

2013-06-18 Thread Dominik Haumann
On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: > Hello, > > On Monday 17 June 2013 19:43:33 Aleix Pol wrote: > > So I was looking at KGlobalSettings to see what we need to do to finally > > deprecate all KGlobalSettings, as suggested by the required kdelibs > > cleanups. > > Ah good, it w