Re: Review Request 110983: Move KToolBarPopupAction to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110983/#review34333 --- Ship it! Ship It! - Kevin Ottens On June 12, 2013, 8:12 p.m

Re: Review Request 110974: Move KToolBarLabelAction to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110974/#review34332 --- Ship it! Ship It! - Kevin Ottens On June 12, 2013, 1:06 p.m

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

> On June 13, 2013, 8:49 p.m., Christoph Feck wrote: > > Using the reviewboard diff viewer, I can only see that you moved files, but > > it is impossible to see if there are any changes to them. Is there a way to > > view those changes, if any? You can apply the files locally and use git. Ther

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110995/ --- (Updated June 13, 2013, 10:29 p.m.) Review request for KDE Frameworks, Dav

Jenkins build became unstable: plasma-framework_master_qt5 #476

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/#review34320 --- Using the reviewboard diff viewer, I can only see that you move

Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Descripti

Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/ --- Review request for KDE Frameworks. Description --- Moved KPage* Also

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110995/ --- (Updated June 13, 2013, 2:33 p.m.) Review request for KDE Frameworks, Davi

Review Request 110995: move jobs from kdeui to kjobswidgets framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110995/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Descripti

Re: Review Request 110988: Port kio-file to QFile

> On June 13, 2013, 11:06 a.m., David Faure wrote: > > kioslave/file/file.cpp, line 453 > > > > > > Bug in the original code? Should be ..._FOR_WRITING if mode & > > QIODevice::WriteOnly? > > Martin Klapetek wro

Re: Review Request 110988: Port kio-file to QFile

> On June 13, 2013, 11:06 a.m., David Faure wrote: > > Good work, not an easy task. > > > > In addition to the issues I found, could you ensure that the unittests > > still pass? In particular jobtest in kio, looks appropriate. Plus the one > > that calls chmod(). Will do. > On June 13, 201

Re: Phonon4Qt5 & Phonon5 Branches

On Tue, Jun 4, 2013 at 12:47 AM, David Faure wrote: > On Wednesday 29 May 2013 16:13:23 Harald Sitter wrote: > > As you may be aware phonon supports building the phonon4 API against Qt5 > by > > building the phonon4qt5 branch. > > > > Due to consolidation efforts at the Phonon sprint last weekend

Re: Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

> On June 12, 2013, 6:51 a.m., Kevin Ottens wrote: > > khtml/misc/loader.h, line 422 > > > > > > qint64 instead of int? probably better since that's what addSecs uses. > > David Gil Oliva wrote: > Ok to chang

Re: Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

> On June 12, 2013, 6:51 a.m., Kevin Ottens wrote: > > khtml/misc/loader.h, line 422 > > > > > > qint64 instead of int? probably better since that's what addSecs uses. Ok to change it, but the docs say addSecs us

Re: Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/#review34280 --- Good work, not an easy task. In addition to the issues I found

Review Request 110988: Port kio-file to QFile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110988/ --- Review request for KDE Frameworks. Description --- Ports away kioslav

Re: File without licence

On Wednesday, June 12, 2013 16:08:27 Benjamin Port wrote: > On Wednesday, June 12, 2013 03:52:32 PM David Faure wrote: > > Le mercredi 12 juin 2013 14:55:07 Benjamin Port a écrit : > > > some files in staging, tier1 and tier2 have no licence perhaps we can > > > fix > > > it. and then don't move a