Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

2013-05-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/#review33247 --- staging/kde4support/src/kdeui/ktoolbarspaceraction.h

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

2013-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- (Updated May 27, 2013, 10:48 p.m.) Review request for KDE Frameworks. Ch

Re: KDE Workspace broken due to upstream CMake changes

2013-05-27 Thread Alexander Neundorf
On Monday 27 May 2013, Ben Cooksley wrote: > On Tue, May 28, 2013 at 7:37 AM, Alexander Neundorf wrote: > > On Monday 27 May 2013, Rolf Eike Beer wrote: > >> Am 27.05.2013 09:13, schrieb Ben Cooksley: > >> > Hi all, > >> > > >> > It seems that a recent upstream change in CMake has now broken the

Re: KDE Workspace broken due to upstream CMake changes

2013-05-27 Thread Ben Cooksley
On Tue, May 28, 2013 at 12:51 AM, Rolf Eike Beer wrote: > Am 27.05.2013 09:13, schrieb Ben Cooksley: > >> Hi all, >> >> It seems that a recent upstream change in CMake has now broken the >> build of KDE Workspace. Can someone please fix or prod CMake upstream >> into revising their policies? >> >>

Re: KDE Workspace broken due to upstream CMake changes

2013-05-27 Thread Ben Cooksley
On Tue, May 28, 2013 at 7:37 AM, Alexander Neundorf wrote: > On Monday 27 May 2013, Rolf Eike Beer wrote: >> Am 27.05.2013 09:13, schrieb Ben Cooksley: >> > Hi all, >> > >> > It seems that a recent upstream change in CMake has now broken the >> > build of KDE Workspace. Can someone please fix or p

Re: KDE Workspace broken due to upstream CMake changes

2013-05-27 Thread Alexander Neundorf
On Monday 27 May 2013, Rolf Eike Beer wrote: > Am 27.05.2013 09:13, schrieb Ben Cooksley: > > Hi all, > > > > It seems that a recent upstream change in CMake has now broken the > > build of KDE Workspace. Can someone please fix or prod CMake upstream > > into revising their policies? > > > > The

Review Request 110674: Moving KToolBarSpacerAction to kde4support

2013-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- Review request for KDE Frameworks. Description --- Just moves the fil

Re: KDE Workspace broken due to upstream CMake changes

2013-05-27 Thread Rolf Eike Beer
Am 27.05.2013 09:13, schrieb Ben Cooksley: Hi all, It seems that a recent upstream change in CMake has now broken the build of KDE Workspace. Can someone please fix or prod CMake upstream into revising their policies? The lack of warning here concerning the change is a little irritating. -- Lo

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-05-27 Thread David Faure
> On May 25, 2013, 5:17 p.m., David Gil Oliva wrote: > > kdeui/dialogs/kpassworddialog.cpp, line 346 > > > > > > Sometimes there are spaces around parentheses, sometimes there is only > > one space and sometimes

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-05-27 Thread David Edmundson
> On May 25, 2013, 5:17 p.m., David Gil Oliva wrote: > > kdeui/dialogs/kpassworddialog.cpp, line 346 > > > > > > Sometimes there are spaces around parentheses, sometimes there is only > > one space and sometimes

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-05-27 Thread David Faure
> On May 25, 2013, 5:17 p.m., David Gil Oliva wrote: > > kdeui/dialogs/kpassworddialog.cpp, line 346 > > > > > > Sometimes there are spaces around parentheses, sometimes there is only > > one space and sometimes

KDE Workspace broken due to upstream CMake changes

2013-05-27 Thread Ben Cooksley
Hi all, It seems that a recent upstream change in CMake has now broken the build of KDE Workspace. Can someone please fix or prod CMake upstream into revising their policies? The lack of warning here concerning the change is a little irritating. -- Looking for XkbLockModifiers in X11 CMake Error