Jenkins build is back to normal : kdelibs_frameworks_qt5 #529

2013-03-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- (Updated March 26, 2013, 11:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review29930 --- Needs more work, for some reason i hadn't realized this breaks

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- (Updated March 26, 2013, 11:05 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: kdelibs_frameworks_qt5 #528

2013-03-26 Thread KDE CI System
See Changes: [tsdgeos] Make some KConfig classes return a bool when saving [tsdgeos] Compile -- [...truncated 4467 lines...] In file included from

Re: KTabWidget task

2013-03-26 Thread David Gil Oliva
Hi! Before implementing setTabBarHidden(bool) and isTabBarHidden() from KTabWidget to QTabWidget, I have made a little program (you can find it attached, rename its extension to .tar.gz) to test whether these methods are really necessary. 2013/3/24 David Faure > On Sunday 24 March 2013 00:28:02

Build failed in Jenkins: kdelibs_frameworks_qt5 #527

2013-03-26 Thread KDE CI System
See Changes: [svenbrauch] If the provider file lists a "register account" URL, provide a link to that. [adawit] Disable SSL compression to prevent the potential for "CRIME" based SSL attacks. [aiacovitti] We do not paint css border

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-26 Thread Oswald Buddenhagen
> On March 23, 2013, 9:56 p.m., Oswald Buddenhagen wrote: > > tier2/kconfig/src/core/kconfig.cpp, line 440 > > > > > > well, it appears to fit the pre-existing logic. any particular reason > > why you are not sur

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-26 Thread Albert Astals Cid
> On March 23, 2013, 9:56 p.m., Oswald Buddenhagen wrote: > > tier2/kconfig/src/core/kconfig.cpp, line 440 > > > > > > well, it appears to fit the pre-existing logic. any particular reason > > why you are not sur

Re: Somebody interested in porting mingw manifest support into cmake ?

2013-03-26 Thread Ralf Habacker
Am 26.03.2013 08:42, schrieb Stephen Kelly: Ralf Habacker wrote: Am 24.03.2013 16:19, schrieb Alexander Neundorf: Hi, in kdelibs in the frameworks branch, we are trying to get rid of KDE-specific extensions, both for Qt and for cmake. This means also no longer kde4_add_executable(), but plain

Re: KTabWidget task

2013-03-26 Thread Kevin Ottens
On Sunday 24 March 2013 10:01:37 David Faure wrote: > On Sunday 24 March 2013 00:28:02 David Gil Oliva wrote: > > By the way, I have found KColorDialog in kde4support, but it seems that > > two tasks haven't been done yet (porting web color line edit and color > > picker button to QColorDialog). Wo

Re: Review Request 109519: Use QUrl::errorString() instead of QUrl::toString() in QMessageBox; adds qWarning as well

2013-03-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109519/#review29899 --- Ship it! Thanks! - David Faure On March 24, 2013, 7:40 p.m.

Re: Somebody interested in porting mingw manifest support into cmake ?

2013-03-26 Thread Ralf Habacker
Am 24.03.2013 16:19, schrieb Alexander Neundorf: Hi, in kdelibs in the frameworks branch, we are trying to get rid of KDE-specific extensions, both for Qt and for cmake. This means also no longer kde4_add_executable(), but plain cmake add_executable() instead. kde_add_executable is a hook to ext