Re: CMake usage requirements in KDE Frameworks

2013-03-25 Thread Alexander Neundorf
On Monday 25 March 2013, Stephen Kelly wrote: > Alexander Neundorf wrote: > > On Sunday 24 March 2013, Stephen Kelly wrote: > >> Alexander Neundorf wrote: > >> > kcodecs doesn't build for me because it doesn't get the QtCore include > >> > dirs. > >> > > >> > It has this code: > >> > target_link_l

Re: CMake usage requirements in KDE Frameworks

2013-03-25 Thread Alexander Neundorf
On Sunday 24 March 2013, Stephen Kelly wrote: > Alexander Neundorf wrote: > > kcodecs doesn't build for me because it doesn't get the QtCore include > > dirs. > > > > It has this code: > > target_link_libraries(KCodecs LINK_PUBLIC ${QT_QTCORE_LIBRARY} ) > > > > This should get it the include dirs

Re: Review Request 109517: Port away from KListWidget to QListWidget

2013-03-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/#review29865 --- staging/kde4support/src/kdeui/klistwidget.h

Re: KF5. QtTest staging.

2013-03-25 Thread David Faure
On Monday 25 March 2013 14:05:28 Alexandr Akulich wrote: > Hi all. > I have discovered a bug with compilation of frameworks branch of kdelibs. > Content of current version of kdelibs/libkdeqt5staging/src/qtest_staging.h > has been commited to upstream, so should be removed to avoid compilation > er

KF5. QtTest staging.

2013-03-25 Thread Alexandr Akulich
Hi all. I have discovered a bug with compilation of frameworks branch of kdelibs. Content of current version of kdelibs/libkdeqt5staging/src/qtest_staging.h has been commited to upstream, so should be removed to avoid compilation errors. kdelibs/libkdeqt5staging/src/qtest_staging.h: http://quickgi